zsturgess / overwatch

src/ServiceBundle/Tests/Expectation/ExpectationDocumentationTest.php

Spacing +5 added lines, -5 removed lines

@@ -20,8 +20,8 @@ 
             $this->fs = new Filesystem();
         }
         
-        $this->docDir = __DIR__ . '/../../../../app/Resources/docs/expectations';
-        $this->expectationDir = __DIR__ . '/../../Expectation';
+        $this->docDir = __DIR__.'/../../../../app/Resources/docs/expectations';
+        $this->expectationDir = __DIR__.'/../../Expectation';
     }
     
     public function testExpectationsDocumented()
@@ -34,7 +34,7 @@ 
     
     public function testExpectationDocsLinked()
     {
-        $indexMd = file_get_contents($this->docDir . '/../index.md');
+        $indexMd = file_get_contents($this->docDir.'/../index.md');
         $expectations = explode("\n", strstr(strstr($indexMd, '##Getting test results', true), '##Expectations'));
         $countExpectationsInIndex = 0;
         
@@ -47,8 +47,8 @@ 
             preg_match('/^- \[[A-Z]+\]\(expectations(\/[A-Z_]+\.md)\)/i', $expectation, $matches);
             
             $this->assertTrue((
-                file_exists(realpath($this->docDir . $matches[1])) &&
-                !is_dir(realpath($this->docDir . $matches[1]))
+                file_exists(realpath($this->docDir.$matches[1])) &&
+                !is_dir(realpath($this->docDir.$matches[1]))
             ));
             
             $countExpectationsInIndex++;

src/ServiceBundle/Expectation/ToPingExpectation.php

Spacing +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@
             socket_close($socket);
 
             if ($rtt > $this->config['unsatisfactory']) {
-                throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (" . $this->config['unsatisfactory'] . ' s)');
+                throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (".$this->config['unsatisfactory'].' s)');
             }
 
-            return 'Pinged in ' . $rtt . 's';
+            return 'Pinged in '.$rtt.'s';
         }
 
         socket_close($socket);
-        throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (" . $this->config['timeout'] . ' s)');
+        throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (".$this->config['timeout'].' s)');
     }
 }

src/ServiceBundle/Expectation/ToRespondHttpExpectation.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             }
         }
         
-        return "Responded HTTP $result " . $response->getReasonPhrase();
+        return "Responded HTTP $result ".$response->getReasonPhrase();
     }
     
     private function isValidStatusCode($code)

src/ServiceBundle/Expectation/ToResolveToExpectation.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
             }
             
             if ($found === $expected) {
-                return $actual . ' has a ' . $dnsRecord['type'] . ' record that resolves to ' . $found;
+                return $actual.' has a '.$dnsRecord['type'].' record that resolves to '.$found;
             }
         }
         

src/ResultBundle/Reporter/ResultReporterManager.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
             try {
                 $reporter->notify($result);
             } catch (\Exception $ex) {
-                $this->logger->error('An error occurred whilst calling ResultReporter ' . \get_class($reporter) . ':' . $ex);
+                $this->logger->error('An error occurred whilst calling ResultReporter '.\get_class($reporter).':'.$ex);
             }
         }
     }

src/ResultBundle/Enum/ResultStatus.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     public static function isValid($status)
     {
         if (!in_array($status, self::getAll())) {
-            throw new \InvalidArgumentException($status . ' is not a valid TestResult status');
+            throw new \InvalidArgumentException($status.' is not a valid TestResult status');
         }
     }
 }

src/ResultBundle/Tests/Controller/ApiControllerTest.php

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
     public function testGetRecentGroupResults()
     {
         $this->logIn('ROLE_SUPER_ADMIN');
-        $this->client->request('GET', '/api/results/group/' . TestGroupFixtures::$groups['group-1']->getId());
+        $this->client->request('GET', '/api/results/group/'.TestGroupFixtures::$groups['group-1']->getId());
 
         $this->assertJsonResponse($this->client->getResponse());
         $this->assertCount(2, $this->getResponseContent());
@@ -48,7 +48,7 @@ 
     public function testGetRecentGroupResultsInsufficentPerms()
     {
         $this->logIn('ROLE_ADMIN');
-        $this->client->request('GET', '/api/results/group/' . TestGroupFixtures::$groups['group-1']->getId());
+        $this->client->request('GET', '/api/results/group/'.TestGroupFixtures::$groups['group-1']->getId());
 
         $this->assertForbidden($this->client->getResponse());
     }
@@ -56,7 +56,7 @@ 
     public function testGetResultsForTest()
     {
         $this->logIn('ROLE_SUPER_ADMIN');
-        $this->client->request('GET', '/api/results/test/' . TestFixtures::$tests['test-1']->getId());
+        $this->client->request('GET', '/api/results/test/'.TestFixtures::$tests['test-1']->getId());
 
         $this->assertJsonResponse($this->client->getResponse());
         $this->assertCount(3, $this->getResponseContent());
@@ -68,7 +68,7 @@ 
     public function testGetResultsForTestInsufficentPerms()
     {
         $this->logIn('ROLE_ADMIN');
-        $this->client->request('GET', '/api/results/test/' . TestFixtures::$tests['test-1']->getId());
+        $this->client->request('GET', '/api/results/test/'.TestFixtures::$tests['test-1']->getId());
 
         $this->assertForbidden($this->client->getResponse());
     }

src/ResultBundle/Tests/E2E/ViewTestTest.php

Spacing +3 added lines, -3 removed lines

@@ -87,13 +87,13 @@ 
     {
         $this->waitForLoadingAnimation();
         $this->webDriver->findElement(
-            WebDriverBy::cssSelector('.tests li:nth-child(' . $number . ') .test a:nth-child(3)')
+            WebDriverBy::cssSelector('.tests li:nth-child('.$number.') .test a:nth-child(3)')
         )->click();
     }
 
     private function getResultsOnPage($selector = ' span')
     {
-        $selector = '.result' . $selector;
+        $selector = '.result'.$selector;
 
         $results = $this->webDriver->findElements(
             WebDriverBy::cssSelector($selector)
@@ -105,7 +105,7 @@ 
     private function getActionItem($number)
     {
         return $this->webDriver->findElement(
-            WebDriverBy::cssSelector('.results li:last-child a:nth-child(' . $number . ')')
+            WebDriverBy::cssSelector('.results li:last-child a:nth-child('.$number.')')
         );
     }
 

src/ResultBundle/Tests/Command/ResultCleanupCommandTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         $command = new ResultCleanupCommand();
         $command->setContainer($this->getContainer());
 
-        $this->application = new Application('Overwatch', '0.0.1-test.' . time());
+        $this->application = new Application('Overwatch', '0.0.1-test.'.time());
         $this->application->add($command);
 
         $this->command = new CommandTester($command);