AppNavigationTest::getBreadcrumbs() - Code Metrics - Inspection of "Front End Rebuild" - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#146)

unknown

created 2016-04-20 12:49 UTC

AppNavigationTest::getBreadcrumbs() A

↳ Parent: AppNavigationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace Overwatch\UserBundle\Tests\E2E;

use Facebook\WebDriver\WebDriverBy;
use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
use Overwatch\UserBundle\DataFixtures\ORM\UserFixtures;
use Overwatch\UserBundle\Tests\Base\WebDriverTestCase;

/**
 * MyAccountTest
 *
 * @author Zac Sturgess <[email protected]>
 */
class AppNavigationTest extends WebDriverTestCase
{
    private $pages = [
        '#/',
        '#/users',
        '#/alerts',
        '#/my-account'
    ];

    public function setUp()
    {
        parent::setUp();

        $groupId = TestGroupFixtures::$groups['group-1']->getId();
        if (!in_array("#/group/$groupId", $this->pages)) {
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            $this->pages[] = "#/group/$groupId";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }
        if (!in_array("#/group/$groupId/add-test", $this->pages)) {
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            $this->pages[] = "#/group/$groupId/add-test";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        $testId = TestFixtures::$tests['test-1']->getId();
        if (!in_array("#/test/$testId", $this->pages)) {
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            $this->pages[] = "#/test/$testId";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();
    }

    // public function testFirstBreadcrumbLinksHome()

    // {
    //     foreach ($this->pages as $page) {

    //         $this->webDriver->get('http://127.0.0.1:8000/' . $page);

    //         $this->waitForLoadingAnimation();


    //         $this->assertEquals('Overwatch', $this->getBreadcrumbs()[0]->getText(), "The breadcrumb text on $page does not equal 'Overwatch'");

    //         $this->assertEquals(
    //             'http://127.0.0.1:8000/#/',
    //             $this->getBreadcrumbs()[0]->findElement(

    //                 WebDriverBy::cssSelector('a')

    //             )->getAttribute('href'),

    //             "The breadcrumb link on $page does not equal '#/'"
    //         );
    //     }
    // }

    // public function testCountBreadcrumbs()

    // {
    //     foreach ($this->pages as $page) {

    //         $this->webDriver->get('http://127.0.0.1:8000/' . $page);

    //         $this->waitForLoadingAnimation();


    //         $this->assertEquals(2, count($this->getBreadcrumbs()), "Breadcrumb count on $page does not equal 2");

    //     }
    // }

    // public function testLastBreadcrumbMatchesPageTitle()

    // {
    //     foreach ($this->pages as $page) {

    //         $this->webDriver->get('http://127.0.0.1:8000/' . $page);

    //         $this->waitForLoadingAnimation();


    //         $breadcrumbs = $this->getBreadcrumbs();


    //         $this->assertContains(
    //             $this->webDriver->findElement(

    //                 WebDriverBy::cssSelector('#page h1')

    //             )->getText(),

    //             end($breadcrumbs)->getText(),

    //             "Final breadcrumb text on $page does not match the page's title"
    //         );
    //     }
    // }

    // private function getBreadcrumbs()

    // {
    //     return $this->webDriver->findElements(

    //         WebDriverBy::cssSelector('ul.breadcrumbs li:not(.ng-hide)')

    //     );
    // }
}


1			<?php
2
3			namespace Overwatch\UserBundle\Tests\E2E;
4
5			use Facebook\WebDriver\WebDriverBy;
6			use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
7			use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
8			use Overwatch\UserBundle\DataFixtures\ORM\UserFixtures;
9			use Overwatch\UserBundle\Tests\Base\WebDriverTestCase;
10
11			/**
12			* MyAccountTest
13			*
14			* @author Zac Sturgess <[email protected]>
15			*/
16			class AppNavigationTest extends WebDriverTestCase
17			{
18			private $pages = [
19			'#/',
20			'#/users',
21			'#/alerts',
22			'#/my-account'
23			];
24
25			public function setUp()
26			{
27			parent::setUp();
28
29			$groupId = TestGroupFixtures::$groups['group-1']->getId();
30			if (!in_array("#/group/$groupId", $this->pages)) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$groupId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
31			$this->pages[] = "#/group/$groupId";
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$groupId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
32			}
33			if (!in_array("#/group/$groupId/add-test", $this->pages)) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$groupId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
34			$this->pages[] = "#/group/$groupId/add-test";
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$groupId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
35			}
36
37			$testId = TestFixtures::$tests['test-1']->getId();
38			if (!in_array("#/test/$testId", $this->pages)) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$testId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
39			$this->pages[] = "#/test/$testId";
			0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$testId` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
40			}
41
42			$this->logInAsUser('user-1');
43			$this->waitForLoadingAnimation();
44			}
45
46			// public function testFirstBreadcrumbLinksHome()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
47			// {
48			// foreach ($this->pages as $page) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
49			// $this->webDriver->get('http://127.0.0.1:8000/' . $page);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
50			// $this->waitForLoadingAnimation();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
51
52			// $this->assertEquals('Overwatch', $this->getBreadcrumbs()[0]->getText(), "The breadcrumb text on $page does not equal 'Overwatch'");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `76%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
53			// $this->assertEquals(
54			// 'http://127.0.0.1:8000/#/',
55			// $this->getBreadcrumbs()[0]->findElement(
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
56			// WebDriverBy::cssSelector('a')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
57			// )->getAttribute('href'),
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			// "The breadcrumb link on $page does not equal '#/'"
59			// );
60			// }
61			// }
62
63			// public function testCountBreadcrumbs()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
64			// {
65			// foreach ($this->pages as $page) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
66			// $this->webDriver->get('http://127.0.0.1:8000/' . $page);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67			// $this->waitForLoadingAnimation();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
68
69			// $this->assertEquals(2, count($this->getBreadcrumbs()), "Breadcrumb count on $page does not equal 2");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
70			// }
71			// }
72
73			// public function testLastBreadcrumbMatchesPageTitle()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
74			// {
75			// foreach ($this->pages as $page) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
76			// $this->webDriver->get('http://127.0.0.1:8000/' . $page);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
77			// $this->waitForLoadingAnimation();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
78
79			// $breadcrumbs = $this->getBreadcrumbs();
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `55%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
80
81			// $this->assertContains(
82			// $this->webDriver->findElement(
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
83			// WebDriverBy::cssSelector('#page h1')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
84			// )->getText(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
85			// end($breadcrumbs)->getText(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
86			// "Final breadcrumb text on $page does not match the page's title"
87			// );
88			// }
89			// }
90
91			// private function getBreadcrumbs()
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
92			// {
93			// return $this->webDriver->findElements(
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
94			// WebDriverBy::cssSelector('ul.breadcrumbs li:not(.ng-hide)')
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-20 13:14 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95			// );
96			// }
97			}
98

zsturgess / overwatch

Pull Request — master (#146)

AppNavigationTest::getBreadcrumbs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like