DashboardTest - Code Metrics - Inspection of "Front-end redesign" - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#148)

unknown

created 2016-04-27 14:45 UTC

DashboardTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	236
Duplicated Lines	9.32 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	17
c	1
b	0
f	0
lcom	1
cbo	9
dl	22
loc	236
rs	10

How to fix Duplicated Code

<?php

namespace Overwatch\TestBundle\Tests\E2E;

use Facebook\WebDriver\WebDriverBy;
use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
use Overwatch\UserBundle\Tests\Base\WebDriverTestCase;

/**
 * DashboardTest
 * Tests the dashboard view
 */
class DashboardTest extends WebDriverTestCase
{
    public function testDisplayGroupsAndTests()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->assertEquals('Dashboard', $this->getHeaderText());
        $this->assertCount(3, $this->getGroups());
        $this->assertCount(2, $this->getTestsForGroup(0));
        $this->assertCount(1, $this->getTestsForGroup(1));
        $this->assertCount(0, $this->getTestsForGroup(2));

        $this->assertContains(TestGroupFixtures::$groups['group-1']->getName(), $this->getGroups()[0]->getText());
        $this->assertContains(TestGroupFixtures::$groups['group-2']->getName(), $this->getGroups()[1]->getText());
        $this->assertContains(TestGroupFixtures::$groups['group-3']->getName(), $this->getGroups()[2]->getText());

        $this->assertContains('2 users', $this->getGroups()[0]->getText());
        $this->assertContains('1 user', $this->getGroups()[1]->getText());
        $this->assertContains('0 users', $this->getGroups()[2]->getText());
    }

    public function testDisplayGroupsAndTestsAsUser()
    {
        $this->logInAsUser('user-2');
        $this->waitForLoadingAnimation();

        $this->assertEquals('Dashboard', $this->getHeaderText());
        $this->assertCount(1, $this->getGroups());
        $this->assertCount(2, $this->getTestsForGroup(0));

        $this->assertContains(TestGroupFixtures::$groups['group-1']->getName(), $this->getGroups()[0]->getText());
        $this->assertContains('2 users', $this->getGroups()[0]->getText());

        $this->assertFalse($this->webDriver->findElement(
            //Edit group button
            WebDriverBy::cssSelector('.groups .widget-box:first-child .widget-header .right a:first-child')
        )->isDisplayed());
        $this->assertFalse($this->getFirstTestDeleteButton()->isDisplayed());
        $this->assertFalse($this->webDriver->findElement(
            //Second test's delete button
            WebDriverBy::cssSelector('ul.tests li:nth-child(2) a:nth-child(4)')
        )->isDisplayed());
        $this->assertFalse($this->webDriver->findElement(
            //Add test button
            WebDriverBy::cssSelector('ul.tests li:last-child a:first-child')
        )->isDisplayed());
        $this->assertFalse($this->getAddGroupButton()->isDisplayed());
    }

    public function testResultAgeWarningHidden()
    {
        foreach (['user-1', 'user-2', 'user-3'] as $user) {
            $this->logInAsUser($user);
            $this->waitForLoadingAnimation();

            $this->assertFalse($this->webDriver->findElement(
                //Test Result Age Warning
                WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
            )->isDisplayed());

            $this->webDriver->get('http://127.0.0.1:8000/logout');
        }
    }

    public function testResultAgeWarningShown()
    {
        $query = "UPDATE TestResult SET created_at = '" . date('Y-m-d H:i:s', time() - (10 * 60 * 60)) . "' WHERE 1";
        $sql = $this->em->getConnection()->prepare($query);
        $sql->execute();

        foreach (['user-1', 'user-2'] as $user) {
            $this->logInAsUser($user);
            $this->waitForLoadingAnimation();

            $this->assertTrue($this->webDriver->findElement(
                //Test Result Age Warning
                WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
            )->isDisplayed());

            $this->webDriver->get('http://127.0.0.1:8000/logout');
        }

        //User 3 has no results, so should not be shown the message
        $this->logInAsUser('user-3');
        $this->waitForLoadingAnimation();

        $this->assertFalse($this->webDriver->findElement(
            //Test Result Age Warning
            WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
        )->isDisplayed());
    }

    public function testDisplayResults()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->assertCount(2, $this->getGroups()[0]->findElements(
            WebDriverBy::cssSelector('.tests li .test .status.passed')
        ));

        $tests = $this->getGroups()[0]->findElements(
            WebDriverBy::cssSelector('.tests li .test')
        );
        $this->assertContains(TestFixtures::$tests['test-1']->getName(), $tests[0]->getText());

        $this->assertEquals($this->getTextForTest(TestFixtures::$tests['test-1']), $this->getTextForTest($tests[0]));

        $this->assertContains(TestFixtures::$tests['test-2']->getName(), $tests[1]->getText());
        $this->assertEquals($this->getHoverTextForTest(TestFixtures::$tests['test-2']), $this->getHoverTextForTest($tests[1]));

        $tests = $this->getGroups()[1]->findElements(
            WebDriverBy::cssSelector('.tests li .test')
        );
        $this->assertCount(1, $tests);
        $this->assertContains(TestFixtures::$tests['test-3']->getName(), $tests[0]->getText());
        $this->assertEquals($this->getHoverTextForTest(TestFixtures::$tests['test-3']), $this->getHoverTextForTest($tests[0]));
    }

    public function testDeleteGroup()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->getGroups()[2]->findElement(
            //Delete group button
            WebDriverBy::cssSelector('.widget-header .right a:nth-child(2)')
        )->click();

        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->dismiss();
        $this->assertCount(3, $this->getGroups());

        $this->getGroups()[2]->findElement(
            //Delete group button
            WebDriverBy::cssSelector('.widget-header .right a:nth-child(2)')
        )->click();

        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->accept();

        $this->waitForLoadingAnimation();
        $this->assertCount(2, $this->getGroups());
    }

    public function testAddGroup()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->getAddGroupButton()->click();
        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->dismiss();
        $this->assertCount(3, $this->getGroups());

        $this->getAddGroupButton()->click();
        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->sendKeys('Not quite untitled group');
        $this->webDriver->switchTo()->alert()->accept();
        $this->waitForLoadingAnimation();
        $this->assertCount(4, $this->getGroups());
        $this->assertContains('Not quite untitled group', $this->getGroups()[3]->getText());
    }

    public function testDeleteTest()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->getFirstTestDeleteButton()->click();
        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->dismiss();
        $this->assertCount(2, $this->getTestsForGroup(0));

        $this->getFirstTestDeleteButton()->click();
        $this->waitForAlert();
        $this->webDriver->switchTo()->alert()->accept();
        $this->waitForLoadingAnimation();
        $this->assertCount(1, $this->getTestsForGroup(0));
    }

    public function testRunTest()
    {
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();

        $this->webDriver->findElement(
            //First test's run button
            WebDriverBy::cssSelector('.tests li:nth-child(1) a:nth-child(1)')
        )->click();
        $this->waitForLoadingAnimation();

        $this->assertContains(TestFixtures::$tests['test-1']->getName(), $this->getHeaderText());
        $this->assertCount(4, $this->webDriver->findElements(
            WebDriverBy::cssSelector('.result span')
        ));
    }

    private function getGroups()
    {
        return $this->webDriver->findElements(
            WebDriverBy::cssSelector('.groups .widget-box')
        );
    }

    private function getTestsForGroup($group)
    {
        return $this->getGroups()[$group]->findElements(
            WebDriverBy::cssSelector('.tests li.ng-scope')
        );
    }

    private function getTextForTest($test)
    {
        //If passed a fixture, construct expected value
        if ($test instanceof \Overwatch\TestBundle\Entity\Test) {

            return 'Expect ' . $test->getActual() . ' ' . $test->getExpectation() . ' ' . $test->getExpected();
        }

        //Else, find text
        return $test->findElement(
            WebDriverBy::cssSelector('p.test-expect')
        )->getText();
    }

    private function getHoverTextForTest($test)
    {
        //If passed a fixture, construct expected value
        if ($test instanceof \Overwatch\TestBundle\Entity\Test) {
            return 'Expect ' . $test->getActual() . ' ' . $test->getExpectation() . ' ' . $test->getExpected();
        }

        //Else, find actual hover text
        return $test->findElement(
            WebDriverBy::tagName('span')
        )->getAttribute('title');
    }

    private function getAddGroupButton()
    {
        return $this->webDriver->findElement(
            WebDriverBy::cssSelector('.groups .add-group a')
        );
    }

    private function getFirstTestDeleteButton()
    {
        return $this->webDriver->findElement(
            WebDriverBy::cssSelector('.tests li:nth-child(1) a:nth-child(4)')
        );
    }
}


1			<?php
2
3			namespace Overwatch\TestBundle\Tests\E2E;
4
5			use Facebook\WebDriver\WebDriverBy;
6			use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
7			use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
8			use Overwatch\UserBundle\Tests\Base\WebDriverTestCase;
9
10			/**
11			* DashboardTest
12			* Tests the dashboard view
13			*/
14			class DashboardTest extends WebDriverTestCase
15			{
16			public function testDisplayGroupsAndTests()
17			{
18			$this->logInAsUser('user-1');
19			$this->waitForLoadingAnimation();
20
21			$this->assertEquals('Dashboard', $this->getHeaderText());
22			$this->assertCount(3, $this->getGroups());
23			$this->assertCount(2, $this->getTestsForGroup(0));
24			$this->assertCount(1, $this->getTestsForGroup(1));
25			$this->assertCount(0, $this->getTestsForGroup(2));
26
27			$this->assertContains(TestGroupFixtures::$groups['group-1']->getName(), $this->getGroups()[0]->getText());
28			$this->assertContains(TestGroupFixtures::$groups['group-2']->getName(), $this->getGroups()[1]->getText());
29			$this->assertContains(TestGroupFixtures::$groups['group-3']->getName(), $this->getGroups()[2]->getText());
30
31			$this->assertContains('2 users', $this->getGroups()[0]->getText());
32			$this->assertContains('1 user', $this->getGroups()[1]->getText());
33			$this->assertContains('0 users', $this->getGroups()[2]->getText());
34			}
35
36			public function testDisplayGroupsAndTestsAsUser()
37			{
38			$this->logInAsUser('user-2');
39			$this->waitForLoadingAnimation();
40
41			$this->assertEquals('Dashboard', $this->getHeaderText());
42			$this->assertCount(1, $this->getGroups());
43			$this->assertCount(2, $this->getTestsForGroup(0));
44
45			$this->assertContains(TestGroupFixtures::$groups['group-1']->getName(), $this->getGroups()[0]->getText());
46			$this->assertContains('2 users', $this->getGroups()[0]->getText());
47
48			$this->assertFalse($this->webDriver->findElement(
49			//Edit group button
50			WebDriverBy::cssSelector('.groups .widget-box:first-child .widget-header .right a:first-child')
51			)->isDisplayed());
52			$this->assertFalse($this->getFirstTestDeleteButton()->isDisplayed());
53			$this->assertFalse($this->webDriver->findElement(
54			//Second test's delete button
55			WebDriverBy::cssSelector('ul.tests li:nth-child(2) a:nth-child(4)')
56			)->isDisplayed());
57			$this->assertFalse($this->webDriver->findElement(
58			//Add test button
59			WebDriverBy::cssSelector('ul.tests li:last-child a:first-child')
60			)->isDisplayed());
61			$this->assertFalse($this->getAddGroupButton()->isDisplayed());
62			}
63
64			public function testResultAgeWarningHidden()
65			{
66			foreach (['user-1', 'user-2', 'user-3'] as $user) {
67			$this->logInAsUser($user);
68			$this->waitForLoadingAnimation();
69
70			$this->assertFalse($this->webDriver->findElement(
71			//Test Result Age Warning
72			WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
73			)->isDisplayed());
74
75			$this->webDriver->get('http://127.0.0.1:8000/logout');
76			}
77			}
78
79			public function testResultAgeWarningShown()
80			{
81			$query = "UPDATE TestResult SET created_at = '" . date('Y-m-d H:i:s', time() - (10 * 60 * 60)) . "' WHERE 1";
82			$sql = $this->em->getConnection()->prepare($query);
83			$sql->execute();
84
85			foreach (['user-1', 'user-2'] as $user) {
86			$this->logInAsUser($user);
87			$this->waitForLoadingAnimation();
88
89			$this->assertTrue($this->webDriver->findElement(
90			//Test Result Age Warning
91			WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
92			)->isDisplayed());
93
94			$this->webDriver->get('http://127.0.0.1:8000/logout');
95			}
96
97			//User 3 has no results, so should not be shown the message
98			$this->logInAsUser('user-3');
99			$this->waitForLoadingAnimation();
100
101			$this->assertFalse($this->webDriver->findElement(
102			//Test Result Age Warning
103			WebDriverBy::cssSelector("div[data-ng-show='shouldWarnOfTestAge()']")
104			)->isDisplayed());
105			}
106
107			public function testDisplayResults()
108			{
109			$this->logInAsUser('user-1');
110			$this->waitForLoadingAnimation();
111
112			$this->assertCount(2, $this->getGroups()[0]->findElements(
113			WebDriverBy::cssSelector('.tests li .test .status.passed')
114			));
115
116			$tests = $this->getGroups()[0]->findElements(
117			WebDriverBy::cssSelector('.tests li .test')
118			);
119			$this->assertContains(TestFixtures::$tests['test-1']->getName(), $tests[0]->getText());
120
121			$this->assertEquals($this->getTextForTest(TestFixtures::$tests['test-1']), $this->getTextForTest($tests[0]));
122
123			$this->assertContains(TestFixtures::$tests['test-2']->getName(), $tests[1]->getText());
124			$this->assertEquals($this->getHoverTextForTest(TestFixtures::$tests['test-2']), $this->getHoverTextForTest($tests[1]));
125
126			$tests = $this->getGroups()[1]->findElements(
127			WebDriverBy::cssSelector('.tests li .test')
128			);
129			$this->assertCount(1, $tests);
130			$this->assertContains(TestFixtures::$tests['test-3']->getName(), $tests[0]->getText());
131			$this->assertEquals($this->getHoverTextForTest(TestFixtures::$tests['test-3']), $this->getHoverTextForTest($tests[0]));
132			}
133
134			public function testDeleteGroup()
135			{
136			$this->logInAsUser('user-1');
137			$this->waitForLoadingAnimation();
138
139			$this->getGroups()[2]->findElement(
140			//Delete group button
141			WebDriverBy::cssSelector('.widget-header .right a:nth-child(2)')
142			)->click();
143
144			$this->waitForAlert();
145			$this->webDriver->switchTo()->alert()->dismiss();
146			$this->assertCount(3, $this->getGroups());
147
148			$this->getGroups()[2]->findElement(
149			//Delete group button
150			WebDriverBy::cssSelector('.widget-header .right a:nth-child(2)')
151			)->click();
152
153			$this->waitForAlert();
154			$this->webDriver->switchTo()->alert()->accept();
155
156			$this->waitForLoadingAnimation();
157			$this->assertCount(2, $this->getGroups());
158			}
159
160			public function testAddGroup()
161			{
162			$this->logInAsUser('user-1');
163			$this->waitForLoadingAnimation();
164
165			$this->getAddGroupButton()->click();
166			$this->waitForAlert();
167			$this->webDriver->switchTo()->alert()->dismiss();
168			$this->assertCount(3, $this->getGroups());
169
170			$this->getAddGroupButton()->click();
171			$this->waitForAlert();
172			$this->webDriver->switchTo()->alert()->sendKeys('Not quite untitled group');
173			$this->webDriver->switchTo()->alert()->accept();
174			$this->waitForLoadingAnimation();
175			$this->assertCount(4, $this->getGroups());
176			$this->assertContains('Not quite untitled group', $this->getGroups()[3]->getText());
177			}
178
179			public function testDeleteTest()
180			{
181			$this->logInAsUser('user-1');
182			$this->waitForLoadingAnimation();
183
184			$this->getFirstTestDeleteButton()->click();
185			$this->waitForAlert();
186			$this->webDriver->switchTo()->alert()->dismiss();
187			$this->assertCount(2, $this->getTestsForGroup(0));
188
189			$this->getFirstTestDeleteButton()->click();
190			$this->waitForAlert();
191			$this->webDriver->switchTo()->alert()->accept();
192			$this->waitForLoadingAnimation();
193			$this->assertCount(1, $this->getTestsForGroup(0));
194			}
195
196			public function testRunTest()
197			{
198			$this->logInAsUser('user-1');
199			$this->waitForLoadingAnimation();
200
201			$this->webDriver->findElement(
202			//First test's run button
203			WebDriverBy::cssSelector('.tests li:nth-child(1) a:nth-child(1)')
204			)->click();
205			$this->waitForLoadingAnimation();
206
207			$this->assertContains(TestFixtures::$tests['test-1']->getName(), $this->getHeaderText());
208			$this->assertCount(4, $this->webDriver->findElements(
209			WebDriverBy::cssSelector('.result span')
210			));
211			}
212
213			private function getGroups()
214			{
215			return $this->webDriver->findElements(
216			WebDriverBy::cssSelector('.groups .widget-box')
217			);
218			}
219
220			private function getTestsForGroup($group)
221			{
222			return $this->getGroups()[$group]->findElements(
223			WebDriverBy::cssSelector('.tests li.ng-scope')
224			);
225			}
226
227			private function getTextForTest($test)
228			{
229			//If passed a fixture, construct expected value
230			if ($test instanceof \Overwatch\TestBundle\Entity\Test) {
			0 ignored issues – show Bug introduced 2016-04-27 14:48 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING Loading history...
231			return 'Expect ' . $test->getActual() . ' ' . $test->getExpectation() . ' ' . $test->getExpected();
232			}
233
234			//Else, find text
235			return $test->findElement(
236			WebDriverBy::cssSelector('p.test-expect')
237			)->getText();
238			}
239
240			private function getHoverTextForTest($test)
241			{
242			//If passed a fixture, construct expected value
243			if ($test instanceof \Overwatch\TestBundle\Entity\Test) {
244			return 'Expect ' . $test->getActual() . ' ' . $test->getExpectation() . ' ' . $test->getExpected();
245			}
246
247			//Else, find actual hover text
248			return $test->findElement(
249			WebDriverBy::tagName('span')
250			)->getAttribute('title');
251			}
252
253			private function getAddGroupButton()
254			{
255			return $this->webDriver->findElement(
256			WebDriverBy::cssSelector('.groups .add-group a')
257			);
258			}
259
260			private function getFirstTestDeleteButton()
261			{
262			return $this->webDriver->findElement(
263			WebDriverBy::cssSelector('.tests li:nth-child(1) a:nth-child(4)')
264			);
265			}
266			}
267

zsturgess / overwatch

Pull Request — master (#148)

DashboardTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like