Overwatch\UserBundle\Tests\E2E\ChangeAlertSettingTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	12	12	1
A	testChangeSetting()	0	12	1
A	getSettingLink()	0	12	2
A	getSettingRow()	0	6	1

<?php

namespace Overwatch\UserBundle\Tests\E2E;

use Facebook\WebDriver\WebDriverBy;
use Overwatch\UserBundle\Tests\Base\WebDriverTestCase;

/**
 * ChangeAlertSettingTest
 * Tests Change Alert Settings Screen
 */
class ChangeAlertSettingTest extends WebDriverTestCase
{
    public function setUp()

This method seems to be duplicated in your project.

    {
        parent::setUp();
        
        $this->logInAsUser('user-1');
        $this->waitForLoadingAnimation();
        
        $this->webDriver->findElement(
            WebDriverBy::cssSelector('#sidebar li:nth-child(3) a')
        )->click();
        $this->waitForLoadingAnimation();
    }
    
    public function testChangeSetting()
    {
        $this->assertFalse($this->getSettingLink(5)->isDisplayed());
        $this->assertTrue($this->getSettingLink(5, true)->isDisplayed());
        
        $this->getSettingLink(1)->click();
        $this->waitForLoadingAnimation();
        $this->assertTrue($this->getSettingLink(5)->isDisplayed());
        $this->assertFalse($this->getSettingLink(5, true)->isDisplayed());
        $this->assertFalse($this->getSettingLink(1)->isDisplayed());
        $this->assertTrue($this->getSettingLink(1, true)->isDisplayed());
    }
    
    private function getSettingLink($number, $isCurrent = false)
    {
        $selector = '[data-ng-click]';
        
        if ($isCurrent) {
            $selector = ":not($selector)";

As per coding-style, please use concatenation or sprintf for the variable $selector instead of interpolation.

        }
        
        return $this->getSettingRow($number)->findElement(
            WebDriverBy::cssSelector("a$selector")

As per coding-style, please use concatenation or sprintf for the variable $selector instead of interpolation.

        );
    }
    
    private function getSettingRow($number)
    {
        return $this->webDriver->findElement(
            WebDriverBy::cssSelector(".settings li:nth-child($number)")

As per coding-style, please use concatenation or sprintf for the variable $number instead of interpolation.

        );
    }
}