ApiTestHelperTrait - Code Metrics - Inspection of "Merge pull request #139 from zsturgess/sensio-insi..." - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( b9670c...4ba57f )

by Zac

created 2016-01-29 12:33 UTC

ApiTestHelperTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	63
rs	10

6 Methods

Rating	Name	Size	Complexity
A	assertCollectionContainsObject()	4	1
A	assertJsonResponse()	6	1
A	assertForbidden()	4	1
A	logIn()	13	1
A	makeJsonRequest()	11	1
A	getResponseContent()	10	2

<?php

namespace Overwatch\UserBundle\Tests\Base;

use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken;

/**
 * ApiTestHelperTrait
 */
trait ApiTestHelperTrait
{
    public function assertCollectionContainsObject($object, $collection)
    {
        return $this->assertContains(json_encode($object), json_encode($collection));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    public function assertJsonResponse($response)
    {
        $this->assertTrue($response->isSuccessful());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertTrue($response->headers->contains('Content-Type', 'application/json'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $this->assertJson($response->getContent());

    }
    
    public function assertForbidden($response)
    {
        $this->assertEquals(Response::HTTP_FORBIDDEN, $response->getStatusCode());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
    
    /**
     * @param string $role
     */
    protected function logIn($role)
    {
        $firewall = 'overwatchApi';
        
        $token = new PreAuthenticatedToken(
            'testUser',
            null,
            $firewall,
            [$role]
        );
        
        $this->client->getContainer()->get('security.context')->setToken($token);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
    
    /**
     * @param string $method
     * @param string $url
     */
    protected function makeJsonRequest($method, $url, $body = [])
    {
        return $this->client->request(
            $method,
            $url,
            [],
            [],
            ['CONTENT_TYPE' => 'application/json'],
            json_encode($body)
        );
    }
    
    protected function getResponseContent($asJson = false)
    {
        $response = $this->client->getResponse()->getContent();
        
        if ($asJson === false) {
            return json_decode($response);
        }
        
        return $response;
    }
}


1			<?php
2
3			namespace Overwatch\UserBundle\Tests\Base;
4
5			use Symfony\Component\HttpFoundation\Response;
6			use Symfony\Component\Security\Core\Authentication\Token\PreAuthenticatedToken;
7
8			/**
9			* ApiTestHelperTrait
10			*/
11			trait ApiTestHelperTrait
12			{
13			public function assertCollectionContainsObject($object, $collection)
14			{
15			return $this->assertContains(json_encode($object), json_encode($collection));
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report It seems like `assertContains()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17
18			public function assertJsonResponse($response)
19			{
20			$this->assertTrue($response->isSuccessful());
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
21			$this->assertTrue($response->headers->contains('Content-Type', 'application/json'));
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report It seems like `assertTrue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
22			$this->assertJson($response->getContent());
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report The method `assertJson()` does not exist on `Overwatch\UserBundle\Tests\Base\ApiTestHelperTrait`. Did you maybe mean `assertJsonResponse()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
23			}
24
25			public function assertForbidden($response)
26			{
27			$this->assertEquals(Response::HTTP_FORBIDDEN, $response->getStatusCode());
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report It seems like `assertEquals()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28			}
29
30			/**
31			* @param string $role
32			*/
33			protected function logIn($role)
34			{
35			$firewall = 'overwatchApi';
36
37			$token = new PreAuthenticatedToken(
38			'testUser',
39			null,
40			$firewall,
41			[$role]
42			);
43
44			$this->client->getContainer()->get('security.context')->setToken($token);
			0 ignored issues – show Bug introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report The property `client` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45			}
46
47			/**
48			* @param string $method
49			* @param string $url
50			*/
51			protected function makeJsonRequest($method, $url, $body = [])
52			{
53			return $this->client->request(
54			$method,
55			$url,
56			[],
57			[],
58			['CONTENT_TYPE' => 'application/json'],
59			json_encode($body)
60			);
61			}
62
63			protected function getResponseContent($asJson = false)
64			{
65			$response = $this->client->getResponse()->getContent();
66
67			if ($asJson === false) {
68			return json_decode($response);
69			}
70
71			return $response;
72			}
73			}
74

zsturgess / overwatch

Push — master ( b9670c...4ba57f )

ApiTestHelperTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like