TestApiControllerTest - Code Metrics - Inspection of "Merge pull request #139 from zsturgess/sensio-insi..." - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( b9670c...4ba57f )

by Zac

created 2016-01-29 12:33 UTC

TestApiControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	259
Duplicated Lines	48.65 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	19
c	1
b	0
f	0
lcom	1
cbo	5
dl	126
loc	259
rs	10

19 Methods

Rating	Name	Duplication	Size	Complexity
B	testCreateTest()	0	34	1
A	testCreateTestInsufficentPerms()	7	7	1
B	testCreateTestInvalidExpectation()	0	28	1
B	testCreateTestInvalidActual()	0	25	1
A	testGetTestsInGroup()	0	16	1
A	testGetTestsInGroupInsufficentPerms()	7	7	1
A	testGetTestsInGroupInvalidGroup()	7	7	1
A	testGetTest()	13	13	1
A	testGetTestInsufficentPerms()	7	7	1
A	testGetTestInvalidTest()	7	7	1
A	testUpdateTest()	23	23	1
A	testUpdateTestInsufficentPerms()	7	7	1
A	testUpdateTestInvalidTest()	7	7	1
A	testDeleteTest()	0	9	1
A	testDeleteTestInsufficentPerms()	7	7	1
A	testDeleteTestInvalidTest()	7	7	1
A	testRunTest()	13	13	1
A	testRunTestInsufficentPerms()	7	7	1
A	testRunTestInvalidTest()	7	7	1

How to fix Duplicated Code

<?php

namespace Overwatch\TestBundle\Tests\Controller;

use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
use Overwatch\TestBundle\Entity\Test;
use Overwatch\UserBundle\Tests\Base\DatabaseAwareTestCase;
use Symfony\Component\HttpFoundation\Response;

/**
 * TestApiControllerTest
 * Functional test of API methods provided by the APIController
 */
class TestApiControllerTest extends DatabaseAwareTestCase
{
    public function testCreateTest()
    {
        $newTest = new Test;
        $newTest
            ->setName('Ping 1234')
            ->setActual('1.2.3.4')
            ->setExpectation('toPing')
        ;
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/tests/group/' . TestGroupFixtures::$groups['group-2']->getId(),
            [
                'name'        => $newTest->getName(),
                'actual'      => $newTest->getActual(),
                'expectation' => $newTest->getExpectation()
            ]
        );
        
        $test = $this->em->getRepository("Overwatch\TestBundle\Entity\Test")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => $newTest->getName()
        ]);
       
        $this->assertNotNull($test);
        $this->assertEquals($newTest->getActual(), $test->getActual());
        $this->assertEquals($newTest->getExpectation(), $test->getExpectation());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode($test),
            $this->getResponseContent(true)
        );
    }
    
    public function testCreateTestInsufficentPerms()

    {
        $this->logIn('ROLE_USER');
        $this->client->request('POST', '/api/tests/group/' . TestGroupFixtures::$groups['group-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testCreateTestInvalidExpectation()
    {
        $newTest = new Test;
        $newTest
            ->setName('Ping 1234')
            ->setActual('1.2.3.4')
            ->setExpectation('IfThisExpectationExistsIBrokeIt')
        ;
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/tests/group/' . TestGroupFixtures::$groups['group-2']->getId(),
            [
                'name'        => $newTest->getName(),
                'actual'      => $newTest->getActual(),
                'expectation' => $newTest->getExpectation()
            ]
        );
        
        $this->assertEquals(Response::HTTP_UNPROCESSABLE_ENTITY, $this->client->getResponse()->getStatusCode());
        $this->assertContains($newTest->getExpectation(), $this->getResponseContent(true));
        $this->assertContains('could not be found', $this->getResponseContent(true));
        
        $this->assertNull($this->em->getRepository("Overwatch\TestBundle\Entity\Test")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => $newTest->getName()
        ]));
    }
    
    public function testCreateTestInvalidActual()
    {
        $newTest = new Test;
        $newTest
            ->setName('Ping 1234')
            ->setExpectation('toPing')
        ;
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/tests/group/' . TestGroupFixtures::$groups['group-2']->getId(),
            [
                'name'        => $newTest->getName(),
                'expectation' => $newTest->getExpectation()
            ]
        );
        
        $this->assertEquals(Response::HTTP_UNPROCESSABLE_ENTITY, $this->client->getResponse()->getStatusCode());
        $this->assertContains('An actual value to test against must be provided.', $this->getResponseContent(true));
        
        $this->assertNull($this->em->getRepository("Overwatch\TestBundle\Entity\Test")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => $newTest->getName()
        ]));
    }
    
    public function testGetTestsInGroup()
    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/tests/group/' . TestGroupFixtures::$groups['group-1']->getId());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertCount(2, $this->getResponseContent());
        $this->assertCollectionContainsObject(
            $this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-1']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->getResponseContent()
        );
        $this->assertCollectionContainsObject(
            $this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-2']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->getResponseContent()
        );
    }
    
    public function testGetTestsInGroupInsufficentPerms()

    {
        $this->logIn('ROLE_ADMIN');
        $this->client->request('GET', '/api/tests/group/' . TestGroupFixtures::$groups['group-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testGetTestsInGroupInvalidGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/tests/group/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testGetTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode(
                $this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-1']->getId())
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ),
            $this->getResponseContent(true)
        );
    }
    
    public function testGetTestInsufficentPerms()

    {
        $this->logIn('ROLE_ADMIN');
        $this->client->request('GET', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testGetTestInvalidTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/tests/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testUpdateTest()

    {
        $newName = 'Renamed Test';
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'PUT',
            '/api/tests/' . TestFixtures::$tests['test-1']->getId(),
            [
                'name' => $newName
            ]
        );
        
        $test = $this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-1']->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertEquals($newName, $test->getName());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode($test),
            $this->getResponseContent(true)
        );
    }
    
    public function testUpdateTestInsufficentPerms()

    {
        $this->logIn('ROLE_USER');
        $this->client->request('PUT', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testUpdateTestInvalidTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('PUT', '/api/tests/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testDeleteTest()
    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertTrue($this->client->getResponse()->isSuccessful());
        $this->assertEquals(Response::HTTP_NO_CONTENT, $this->client->getResponse()->getStatusCode());
        $this->assertNull($this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-1']->getId()));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    
    public function testDeleteTestInsufficentPerms()

    {
        $this->logIn('ROLE_USER');
        $this->client->request('DELETE', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testDeleteTestInvalidTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/tests/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testRunTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('POST', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $test = $this->em->find("Overwatch\TestBundle\Entity\Test", TestFixtures::$tests['test-1']->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode($test->getResults()->last()),
            $this->getResponseContent(true)
        );
    }
    
    public function testRunTestInsufficentPerms()

    {
        $this->logIn('ROLE_USER');
        $this->client->request('POST', '/api/tests/' . TestFixtures::$tests['test-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testRunTestInvalidTest()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('POST', '/api/tests/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
}


1			<?php
2
3			namespace Overwatch\TestBundle\Tests\Controller;
4
5			use Overwatch\TestBundle\DataFixtures\ORM\TestFixtures;
6			use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
7			use Overwatch\TestBundle\Entity\Test;
8			use Overwatch\UserBundle\Tests\Base\DatabaseAwareTestCase;
9			use Symfony\Component\HttpFoundation\Response;
10
11			/**
12			* TestApiControllerTest
13			* Functional test of API methods provided by the APIController
14			*/
15			class TestApiControllerTest extends DatabaseAwareTestCase
16			{
17			public function testCreateTest()
18			{
19			$newTest = new Test;
20			$newTest
21			->setName('Ping 1234')
22			->setActual('1.2.3.4')
23			->setExpectation('toPing')
24			;
25
26			$this->logIn('ROLE_SUPER_ADMIN');
27			$this->makeJsonRequest(
28			'POST',
29			'/api/tests/group/' . TestGroupFixtures::$groups['group-2']->getId(),
30			[
31			'name' => $newTest->getName(),
32			'actual' => $newTest->getActual(),
33			'expectation' => $newTest->getExpectation()
34			]
35			);
36
37			$test = $this->em->getRepository("Overwatch\TestBundle\Entity\Test")->findOneBy([
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report The string literal `Overwatch\TestBundle\Entity\Test` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
38			'name' => $newTest->getName()
39			]);

zsturgess / overwatch

Push — master ( b9670c...4ba57f )

TestApiControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

19 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like