zsturgess / overwatch

src/ServiceBundle/Tests/Expectation/ExpectationDocumentationTest.php

Spacing +5 added lines, -5 removed lines

@@ -20,8 +20,8 @@ 
             $this->fs = new Filesystem();
         }
         
-        $this->docDir = __DIR__ . '/../../../../app/Resources/docs/expectations';
-        $this->expectationDir = __DIR__ . '/../../Expectation';
+        $this->docDir = __DIR__.'/../../../../app/Resources/docs/expectations';
+        $this->expectationDir = __DIR__.'/../../Expectation';
     }
     
     public function testExpectationsDocumented()
@@ -34,7 +34,7 @@ 
     
     public function testExpectationDocsLinked()
     {
-        $indexMd = file_get_contents($this->docDir . '/../index.md');
+        $indexMd = file_get_contents($this->docDir.'/../index.md');
         $expectations = explode("\n", strstr(strstr($indexMd, '##Getting test results', true), '##Expectations'));
         $countExpectationsInIndex = 0;
         
@@ -47,8 +47,8 @@ 
             preg_match('/^- \[[A-Z]+\]\(expectations(\/[A-Z_]+\.md)\)/i', $expectation, $matches);
             
             $this->assertTrue((
-                file_exists(realpath($this->docDir . $matches[1])) &&
-                !is_dir(realpath($this->docDir . $matches[1]))
+                file_exists(realpath($this->docDir.$matches[1])) &&
+                !is_dir(realpath($this->docDir.$matches[1]))
             ));
             
             $countExpectationsInIndex++;

src/ServiceBundle/Expectation/ToPingExpectation.php

Spacing +3 added lines, -3 removed lines

@@ -36,13 +36,13 @@
             socket_close($socket);
 
             if ($rtt > $this->config['unsatisfactory']) {
-                throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (" . $this->config['unsatisfactory'] . ' s)');
+                throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (".$this->config['unsatisfactory'].' s)');
             }
 
-            return 'Pinged in ' . $rtt . 's';
+            return 'Pinged in '.$rtt.'s';
         }
 
         socket_close($socket);
-        throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (" . $this->config['timeout'] . ' s)');
+        throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (".$this->config['timeout'].' s)');
     }
 }

src/ServiceBundle/Expectation/ToRespondHttpExpectation.php

Spacing +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
             }
         }
         
-        return "Responded HTTP $result " . $response->getReasonPhrase();
+        return "Responded HTTP $result ".$response->getReasonPhrase();
     }
     
     private function isValidStatusCode($code)

src/ServiceBundle/Expectation/ToResolveToExpectation.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
             }
             
             if ($found === $expected) {
-                return $actual . ' has a ' . $dnsRecord['type'] . ' record that resolves to ' . $found;
+                return $actual.' has a '.$dnsRecord['type'].' record that resolves to '.$found;
             }
         }
         

src/ResultBundle/Reporter/ResultReporterManager.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
             try {
                 $reporter->notify($result);
             } catch (\Exception $ex) {
-                $this->logger->error('An error occurred whilst calling ResultReporter ' . \get_class($reporter) . ':' . $ex);
+                $this->logger->error('An error occurred whilst calling ResultReporter '.\get_class($reporter).':'.$ex);
             }
         }
     }

src/ResultBundle/Enum/ResultStatus.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     public static function isValid($status)
     {
         if (!in_array($status, self::getAll())) {
-            throw new \InvalidArgumentException($status . ' is not a valid TestResult status');
+            throw new \InvalidArgumentException($status.' is not a valid TestResult status');
         }
     }
 }

src/ResultBundle/Tests/Controller/ApiControllerTest.php

Spacing +4 added lines, -4 removed lines

@@ -37,7 +37,7 @@ 
     public function testGetRecentGroupResults()
     {
         $this->logIn('ROLE_SUPER_ADMIN');
-        $this->client->request('GET', '/api/results/group/' . TestGroupFixtures::$groups['group-1']->getId());
+        $this->client->request('GET', '/api/results/group/'.TestGroupFixtures::$groups['group-1']->getId());
 
         $this->assertJsonResponse($this->client->getResponse());
         $this->assertCount(2, $this->getResponseContent());
@@ -48,7 +48,7 @@ 
     public function testGetRecentGroupResultsInsufficentPerms()
     {
         $this->logIn('ROLE_ADMIN');
-        $this->client->request('GET', '/api/results/group/' . TestGroupFixtures::$groups['group-1']->getId());
+        $this->client->request('GET', '/api/results/group/'.TestGroupFixtures::$groups['group-1']->getId());
 
         $this->assertForbidden($this->client->getResponse());
     }
@@ -56,7 +56,7 @@ 
     public function testGetResultsForTest()
     {
         $this->logIn('ROLE_SUPER_ADMIN');
-        $this->client->request('GET', '/api/results/test/' . TestFixtures::$tests['test-1']->getId());
+        $this->client->request('GET', '/api/results/test/'.TestFixtures::$tests['test-1']->getId());
 
         $this->assertJsonResponse($this->client->getResponse());
         $this->assertCount(3, $this->getResponseContent());
@@ -68,7 +68,7 @@ 
     public function testGetResultsForTestInsufficentPerms()
     {
         $this->logIn('ROLE_ADMIN');
-        $this->client->request('GET', '/api/results/test/' . TestFixtures::$tests['test-1']->getId());
+        $this->client->request('GET', '/api/results/test/'.TestFixtures::$tests['test-1']->getId());
 
         $this->assertForbidden($this->client->getResponse());
     }

src/ResultBundle/Tests/Command/ResultCleanupCommandTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
         $command = new ResultCleanupCommand();
         $command->setContainer($this->getContainer());
 
-        $this->application = new Application('Overwatch', '0.0.1-test.' . time());
+        $this->application = new Application('Overwatch', '0.0.1-test.'.time());
         $this->application->add($command);
 
         $this->command = new CommandTester($command);

src/ResultBundle/Command/ResultCleanupCommand.php

Spacing +10 added lines, -10 removed lines

@@ -74,7 +74,7 @@ 
         $delete = $this->convertOption($input->getOption('delete'));
         $compress = $this->convertOption($input->getOption('compress'));
 
-        $this->output->writeln($this->getApplication()->getLongVersion() . ', running a cleanup');
+        $this->output->writeln($this->getApplication()->getLongVersion().', running a cleanup');
 
         if ($delete === null && $compress === null) {
             throw new \InvalidArgumentException('Neither the --delete or --compress options were passed. No operation will be completed.');
@@ -87,7 +87,7 @@ 
         $this->deleteResults($delete);
         $this->compressResults($compress);
 
-        $output->writeln(' > Applying <info>' . count($this->em->getUnitOfWork()->getScheduledEntityDeletions()) . '</info> cleanup operations');
+        $output->writeln(' > Applying <info>'.count($this->em->getUnitOfWork()->getScheduledEntityDeletions()).'</info> cleanup operations');
         $this->em->flush();
         $output->writeln('<info>Cleanup finished</info>');
     }
@@ -103,13 +103,13 @@ 
 
     private function prepareArchive()
     {
-        $archiveDir = $this->getContainer()->get('kernel')->getRootDir() . '/logs/';
-        $header = $this->getApplication()->getName() . ' ' . $this->getApplication()->getVersion() . ', running a cleanup';
+        $archiveDir = $this->getContainer()->get('kernel')->getRootDir().'/logs/';
+        $header = $this->getApplication()->getName().' '.$this->getApplication()->getVersion().', running a cleanup';
 
-        $this->archiveFile = $archiveDir . 'overwatch_archive_' . date('YmdHis') . '.log';
-        $this->output->writeln(' > Preparing archive file <info>' . $this->archiveFile . '</info>');
+        $this->archiveFile = $archiveDir.'overwatch_archive_'.date('YmdHis').'.log';
+        $this->output->writeln(' > Preparing archive file <info>'.$this->archiveFile.'</info>');
 
-        if (!file_put_contents($this->archiveFile, $header . PHP_EOL, FILE_APPEND)) {
+        if (!file_put_contents($this->archiveFile, $header.PHP_EOL, FILE_APPEND)) {
             throw new \InvalidArgumentException('Could not write to the archive file.');
         }
     }
@@ -123,7 +123,7 @@ 
             return;
         }
 
-        $this->output->writeln(' > Finding results older than <info>' . $delete->format('Y-m-d H:i:s') . '</info> to delete');
+        $this->output->writeln(' > Finding results older than <info>'.$delete->format('Y-m-d H:i:s').'</info> to delete');
         $resultsToCleanup = $this->resultRepo->getResultsOlderThan($delete);
 
         foreach ($resultsToCleanup as $row) {
@@ -143,7 +143,7 @@ 
         }
 
         $lastResult = ResultStatus::PASSED;
-        $this->output->writeln(' > Finding results older than <info>' . $compress->format('Y-m-d H:i:s') . '</info> to compress');
+        $this->output->writeln(' > Finding results older than <info>'.$compress->format('Y-m-d H:i:s').'</info> to compress');
         $resultsToCleanup = $this->resultRepo->getResultsOlderThan($compress);
 
         foreach ($resultsToCleanup as $row) {
@@ -160,7 +160,7 @@ 
     private function archiveResult(TestResult $result)
     {
         if ($this->archiveFile !== null) {
-            file_put_contents($this->archiveFile, (string) $result . PHP_EOL, FILE_APPEND);
+            file_put_contents($this->archiveFile, (string) $result.PHP_EOL, FILE_APPEND);
         }
 
         $this->em->remove($result);