AlertSetting::getAll() - Code Metrics - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

AlertSetting::getAll() A
last analyzed 2016-11-23 12:35 UTC

↳ Parent: AlertSetting

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0
crap	1

<?php

namespace Overwatch\UserBundle\Enum;

/**
 * AlertSetting
 * The different possible alert settings for users
 */
class AlertSetting
{
    const NONE = 0;
    const CHANGE_BAD = 1;
    const CHANGE = 2;
    const CHANGE_ALL = 3;
    const ALL = 4;
    
    public static function getAll()
    {
        return [
            self::NONE       => 'Send me no alerts, ever',
            self::CHANGE_BAD => 'Only send me an alert when the result of a test changes to FAILED (or ERROR)',
            self::CHANGE     => 'Send me alerts when the result of a test changes (default)',
            self::CHANGE_ALL => 'Send me alerts for every test failure and when the result of a test changes',
            self::ALL        => 'Send me the results of every test, regardless of if the status changes'
        ];
    }
    
    public static function isValid($setting)
    {
        if (!in_array($setting, array_keys(self::getAll()))) {
            throw new \InvalidArgumentException("$setting is not a valid AlertSetting");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }
    }
}


1		<?php
2
3		namespace Overwatch\UserBundle\Enum;
4
5		/**
6		* AlertSetting
7		* The different possible alert settings for users
8		*/
9		class AlertSetting
10		{
11		const NONE = 0;
12		const CHANGE_BAD = 1;
13		const CHANGE = 2;
14		const CHANGE_ALL = 3;
15		const ALL = 4;
16
17	136	public static function getAll()
18		{
19		return [
20	136	self::NONE => 'Send me no alerts, ever',
21	136	self::CHANGE_BAD => 'Only send me an alert when the result of a test changes to FAILED (or ERROR)',
22	136	self::CHANGE => 'Send me alerts when the result of a test changes (default)',
23	136	self::CHANGE_ALL => 'Send me alerts for every test failure and when the result of a test changes',
24	136	self::ALL => 'Send me the results of every test, regardless of if the status changes'
25	136	];
26		}
27
28	136	public static function isValid($setting)
29		{
30	136	if (!in_array($setting, array_keys(self::getAll()))) {
31	1	throw new \InvalidArgumentException("$setting is not a valid AlertSetting");
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$setting` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
32		}
33	135	}
34		}
35

zsturgess / overwatch

AlertSetting::getAll() A last analyzed 2016-11-23 12:35 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

AlertSetting::getAll() A
last analyzed 2016-11-23 12:35 UTC