ToPingExpectation::__construct() - Code Metrics - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

ToPingExpectation::__construct() A
last analyzed 2016-11-23 12:35 UTC

↳ Parent: ToPingExpectation

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	1

<?php

namespace Overwatch\ServiceBundle\Expectation;

use Overwatch\ExpectationBundle\Exception as Result;
use Overwatch\ExpectationBundle\Expectation\ExpectationInterface;

/**
 * ToPingExpectation
 * Expectation classes are the actual runners of tests.
 * This is the runner for the "toPing" expectation.
 */
class ToPingExpectation implements ExpectationInterface
{
    private $config;

    public function __construct($config)
    {
        $this->config = $config;
    }

    public function run($actual, $expected = null)
    {
        // From http://php.net/manual/en/function.socket-create.php#101012
        $package = "\x08\x00\x7d\x4b\x00\x00\x00\x00PingHost";
        $socket  = socket_create(AF_INET, SOCK_RAW, 1);

        socket_set_option($socket, SOL_SOCKET, SO_RCVTIMEO, ['sec' => floor($this->config['timeout']), 'usec' => (($this->config['timeout'] - floor($this->config['timeout'])) * 1000)]);
        socket_connect($socket, $actual, null);

        $sent = microtime(true);
        socket_send($socket, $package, strLen($package), 0);

        if (socket_read($socket, 255)) {
            $rtt = microtime(true) - $sent;
            socket_close($socket);

            if ($rtt > $this->config['unsatisfactory']) {
                throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (" . $this->config['unsatisfactory'] . ' s)');
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
            }

            return 'Pinged in ' . $rtt . 's';
        }

        socket_close($socket);
        throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (" . $this->config['timeout'] . ' s)');
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }
}


1		<?php
2
3		namespace Overwatch\ServiceBundle\Expectation;
4
5		use Overwatch\ExpectationBundle\Exception as Result;
6		use Overwatch\ExpectationBundle\Expectation\ExpectationInterface;
7
8		/**
9		* ToPingExpectation
10		* Expectation classes are the actual runners of tests.
11		* This is the runner for the "toPing" expectation.
12		*/
13		class ToPingExpectation implements ExpectationInterface
14		{
15		private $config;
16
17	37	public function __construct($config)
18		{
19	37	$this->config = $config;
20	37	}
21
22	10	public function run($actual, $expected = null)
23		{
24		// From http://php.net/manual/en/function.socket-create.php#101012
25	10	$package = "\x08\x00\x7d\x4b\x00\x00\x00\x00PingHost";
26	10	$socket = socket_create(AF_INET, SOCK_RAW, 1);
27
28	9	socket_set_option($socket, SOL_SOCKET, SO_RCVTIMEO, ['sec' => floor($this->config['timeout']), 'usec' => (($this->config['timeout'] - floor($this->config['timeout'])) * 1000)]);
29	9	socket_connect($socket, $actual, null);
30
31	9	$sent = microtime(true);
32	9	socket_send($socket, $package, strLen($package), 0);
33
34	9	if (socket_read($socket, 255)) {
35	8	$rtt = microtime(true) - $sent;
36	8	socket_close($socket);
37
38	8	if ($rtt > $this->config['unsatisfactory']) {
39	3	throw new Result\ExpectationUnsatisfactoryException("$actual responded in $rtt s, above the unsatisfactory threshold (" . $this->config['unsatisfactory'] . ' s)');
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$actual` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history... Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$rtt` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
40		}
41
42	7	return 'Pinged in ' . $rtt . 's';
43		}
44
45	3	socket_close($socket);
46	3	throw new Result\ExpectationFailedException("$actual failed to respond in the timeout threshold (" . $this->config['timeout'] . ' s)');
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$actual` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
47		}
48		}
49

zsturgess / overwatch

ToPingExpectation::__construct() A last analyzed 2016-11-23 12:35 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ToPingExpectation::__construct() A
last analyzed 2016-11-23 12:35 UTC