TestGroupApiControllerTest - Code Metrics - zsturgess/overwatch - Measure and Improve Code Quality continuously with Scrutinizer

TestGroupApiControllerTest A
last analyzed 2016-11-23 12:35 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	310
Duplicated Lines	59.35 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	23
lcom	1
cbo	4
dl	184
loc	310
rs	10
c	0
b	0
f	0

23 Methods

Rating	Name	Duplication	Size	Complexity
A	testCreateGroup()	0	22	1
A	testCreateGroupInsufficentPerms()	0	20	1
A	testCreateGroupNoName()	0	16	1
A	testGetAllGroups()	16	16	1
A	testGetAllGroupsAsUser()	16	16	1
A	testGetGroup()	13	13	1
A	testGetGroupInsufficentPerms()	7	7	1
A	testGetGroupInvalidGroup()	7	7	1
A	testUpdateGroup()	23	23	1
A	testUpdateGroupInsufficentPerms()	7	7	1
A	testUpdateGroupInvalidGroup()	7	7	1
A	testDeleteGroup()	8	8	1
A	testDeleteGroupPopulatedGroup()	8	8	1
A	testDeleteGroupInsufficentPerms()	0	8	1
A	testDeleteGroupInvalidGroup()	7	7	1
A	testAddUserToGroup()	14	14	1
A	testAddUserToGroupInsufficentPerms()	0	13	1
A	testAddUserToGroupInvalidGroup()	0	9	1
A	testAddUserToGroupInvalidUser()	12	12	1
A	testRemoveUserFromGroup()	14	14	1
A	testRemoveUserFromGroupInsufficentPerms()	0	13	1
A	testRemoveUserFromGroupInvalidGroup()	13	13	1
A	testRemoveUserFromGroupInvalidUser()	12	12	1

How to fix Duplicated Code

<?php

namespace Overwatch\TestBundle\Tests\Controller;

use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
use Overwatch\TestBundle\Entity\TestGroup;
use Overwatch\UserBundle\DataFixtures\ORM\UserFixtures;
use Overwatch\UserBundle\Tests\Base\DatabaseAwareTestCase;
use Symfony\Component\HttpFoundation\Response;

/**
 * TestGroupApiControllerTest
 * Functional test of API methods provided by the APIController
 */
class TestGroupApiControllerTest extends DatabaseAwareTestCase
{
    public function testCreateGroup()
    {
        $newGroupName = 'New Group 1';
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/groups',
            [
                'name' => $newGroupName,
            ]
        );
        
        $group = $this->em->getRepository("Overwatch\TestBundle\Entity\TestGroup")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => $newGroupName
        ]);
        
        $this->assertNotNull($group);
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertEquals($newGroupName, $this->getResponseContent()->name);
    }
    
    public function testCreateGroupInsufficentPerms()
    {
        $newGroupName = 'New Group 2';
        
        $this->logIn('ROLE_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/groups',
            [
                'name' => $newGroupName,
            ]
        );
        
        $group = $this->em->getRepository("Overwatch\TestBundle\Entity\TestGroup")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => $newGroupName
        ]);
        
        $this->assertNull($group);
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testCreateGroupNoName()
    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'POST',
            '/api/groups',
            []
        );
        
        $group = $this->em->getRepository("Overwatch\TestBundle\Entity\TestGroup")->findOneBy([
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'name' => null
        ]);
        
        $this->assertNull($group);
        $this->assertEquals(422, $this->client->getResponse()->getStatusCode());
    }
    
    public function testGetAllGroups()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/groups');
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertCount(3, $this->getResponseContent());
        $this->assertCollectionContainsObject(
            $this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-1']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->getResponseContent()
        );
        $this->assertCollectionContainsObject(
            $this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-2']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->getResponseContent()
        );
    }
    
    public function testGetAllGroupsAsUser()

    {
        $this->loginAs(
            $this->em->find("Overwatch\UserBundle\Entity\User", UserFixtures::$users['user-2']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            'overwatch'
        );
        $this->client = $this->makeClient(); //When using loginAs, we must use a new client
        $this->client->request('GET', '/api/groups');
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertCount(1, $this->getResponseContent());
        $this->assertCollectionContainsObject(
            $this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-1']->getId()),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $this->getResponseContent()
        );
    }
    
    public function testGetGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/groups/' . TestGroupFixtures::$groups['group-1']->getId());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode(
                $this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-1']->getId())
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ),
            $this->getResponseContent(true)
        );
    }
    
    public function testGetGroupInsufficentPerms()

    {
        $this->logIn('ROLE_ADMIN');
        $this->client->request('GET', '/api/groups/' . TestGroupFixtures::$groups['group-1']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testGetGroupInvalidGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('GET', '/api/groups/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testUpdateGroup()

    {
        $newName = 'Renamed Group';
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->makeJsonRequest(
            'PUT',
            '/api/groups/' . TestGroupFixtures::$groups['group-2']->getId(),
            [
                'name' => $newName
            ]
        );
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-2']->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertEquals($newName, $group->getName());
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(
            json_encode($group),
            $this->getResponseContent(true)
        );
    }
    
    public function testUpdateGroupInsufficentPerms()

    {
        $this->logIn('ROLE_USER');
        $this->client->request('PUT', '/api/groups/' . TestGroupFixtures::$groups['group-2']->getId());
        
        $this->assertForbidden($this->client->getResponse());
    }
    
    public function testUpdateGroupInvalidGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('PUT', '/api/groups/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testDeleteGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . TestGroupFixtures::$groups['group-3']->getId());
        
        $this->assertEquals(Response::HTTP_NO_CONTENT, $this->client->getResponse()->getStatusCode());
        $this->assertNull($this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-3']->getId()));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    
    public function testDeleteGroupPopulatedGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . TestGroupFixtures::$groups['group-2']->getId());
        
        $this->assertEquals(Response::HTTP_UNPROCESSABLE_ENTITY, $this->client->getResponse()->getStatusCode());
        $this->assertNotNull($this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-2']->getId()));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    
    public function testDeleteGroupInsufficentPerms()
    {
        $this->logIn('ROLE_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . TestGroupFixtures::$groups['group-3']->getId());
        
        $this->assertForbidden($this->client->getResponse());
        $this->assertNotNull($this->em->find("Overwatch\TestBundle\Entity\TestGroup", TestGroupFixtures::$groups['group-2']->getId()));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }
    
    public function testDeleteGroupInvalidGroup()

    {
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/1000');
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testAddUserToGroup()

    {
        $user = UserFixtures::$users['user-2'];
        $group = TestGroupFixtures::$groups['group-3'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('POST', '/api/groups/' . $group->getId() . '/user/' . $user->getId());
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(json_encode($user), $this->getResponseContent(true));
        $this->assertCount(1, $group->getUsers());
    }
    
    public function testAddUserToGroupInsufficentPerms()
    {
        $user = UserFixtures::$users['user-2'];
        $group = TestGroupFixtures::$groups['group-3'];
        
        $this->logIn('ROLE_ADMIN');
        $this->client->request('POST', '/api/groups/' . $group->getId() . '/user/' . $user->getId());
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertForbidden($this->client->getResponse());
        $this->assertCount(0, $group->getUsers());
    }
    
    public function testAddUserToGroupInvalidGroup()
    {
        $user = UserFixtures::$users['user-2'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('POST', '/api/groups/1000/user/' . $user->getId());
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
    }
    
    public function testAddUserToGroupInvalidUser()

    {
        $group = TestGroupFixtures::$groups['group-3'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('POST', '/api/groups/' . $group->getId() . '/user/1000');
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
        $this->assertCount(0, $group->getUsers());
    }
    
    public function testRemoveUserFromGroup()

    {
        $user = UserFixtures::$users['user-2'];
        $group = TestGroupFixtures::$groups['group-1'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . $group->getId() . '/user/' . $user->getId());
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertJsonResponse($this->client->getResponse());
        $this->assertJsonStringEqualsJsonString(json_encode($user), $this->getResponseContent(true));
        $this->assertCount(1, $group->getUsers());
    }
    
    public function testRemoveUserFromGroupInsufficentPerms()
    {
        $user = UserFixtures::$users['user-2'];
        $group = TestGroupFixtures::$groups['group-1'];
        
        $this->logIn('ROLE_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . $group->getId() . '/user/' . $user->getId());
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertForbidden($this->client->getResponse());
        $this->assertCount(2, $group->getUsers());
    }
    
    public function testRemoveUserFromGroupInvalidGroup()

    {
        $user = UserFixtures::$users['user-2'];
        $group = TestGroupFixtures::$groups['group-1'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/1000/user/' . $user->getId());
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
        $this->assertCount(2, $group->getUsers());
    }
    
    public function testRemoveUserFromGroupInvalidUser()

    {
        $group = TestGroupFixtures::$groups['group-1'];
        
        $this->logIn('ROLE_SUPER_ADMIN');
        $this->client->request('DELETE', '/api/groups/' . $group->getId() . '/user/1000');
        
        $group = $this->em->find("Overwatch\TestBundle\Entity\TestGroup", $group->getId());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        
        $this->assertEquals(Response::HTTP_NOT_FOUND, $this->client->getResponse()->getStatusCode());
        $this->assertCount(2, $group->getUsers());
    }
}


1			<?php
2
3			namespace Overwatch\TestBundle\Tests\Controller;
4
5			use Overwatch\TestBundle\DataFixtures\ORM\TestGroupFixtures;
6			use Overwatch\TestBundle\Entity\TestGroup;
7			use Overwatch\UserBundle\DataFixtures\ORM\UserFixtures;
8			use Overwatch\UserBundle\Tests\Base\DatabaseAwareTestCase;
9			use Symfony\Component\HttpFoundation\Response;
10
11			/**
12			* TestGroupApiControllerTest
13			* Functional test of API methods provided by the APIController
14			*/
15			class TestGroupApiControllerTest extends DatabaseAwareTestCase
16			{
17			public function testCreateGroup()
18			{
19			$newGroupName = 'New Group 1';
20
21			$this->logIn('ROLE_SUPER_ADMIN');
22			$this->makeJsonRequest(
23			'POST',
24			'/api/groups',
25			[
26			'name' => $newGroupName,
27			]
28			);
29
30			$group = $this->em->getRepository("Overwatch\TestBundle\Entity\TestGroup")->findOneBy([
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-29 12:49 UTC by Report Bug Copy Issue Report The string literal `Overwatch\TestBundle\Entity\TestGroup` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
31			'name' => $newGroupName
32			]);
33
34			$this->assertNotNull($group);
35
36			$this->assertJsonResponse($this->client->getResponse());
37			$this->assertEquals($newGroupName, $this->getResponseContent()->name);
38			}
39

zsturgess / overwatch

TestGroupApiControllerTest A last analyzed 2016-11-23 12:35 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

23 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

TestGroupApiControllerTest A
last analyzed 2016-11-23 12:35 UTC