Client::getLinkData() - Code Metrics - zrashwani/news-scrapper - Measure and Improve Code Quality continuously with Scrutinizer

Client::getLinkData() A
last analyzed 2017-08-17 08:42 UTC

↳ Parent: Client

Complexity

Conditions	3
Paths	2

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
nc	2
cc	3
eloc	12
nop	1

<?php

namespace Zrashwani\NewsScrapper;

use Goutte\Client as GoutteClient;
use Symfony\Component\DomCrawler\Crawler;
use Symfony\Component\BrowserKit\CookieJar;

/**
 * Client to scrap article/news contents from serveral news sources
 *
 * @author Zeid Rashwani <[email protected]>
 */
class Client
{

    protected $scrapClient;
    protected $adaptersList = ['Microdata', 'HAtom', 'OpenGraph', 'JsonLD', 'Parsely', 'Default'];

    /**
     * Adapter to scrap content
     * @var Adapters\AbstractAdapter
     */
    protected $adapter;

    /**
     * Constructor
     */
    public function __construct($adapter_name = null, CookieJar $cookie_jar = null)
    {
        $this->scrapClient = new GoutteClient([], null, $cookie_jar);
        
        $this->scrapClient->followRedirects();
        $this->scrapClient->getClient()->setDefaultOption(
            'config/curl/'.
            CURLOPT_SSL_VERIFYHOST,
            false
        );
        $this->scrapClient->getClient()->setDefaultOption(
            'config/curl/'.
            CURLOPT_SSL_VERIFYPEER,
            false
        );
        
        $this->setAdapter($adapter_name);
    }

    /**
     * Getting selected adapter
     * @return Adapters\AbstractAdapter
     */
    public function getAdapter()
    {
        return $this->adapter;
    }

    /**
     * Setting adapter preferred for scrapping
     * @param string $adapter_name
     * @throws \Exception
     */
    public function setAdapter($adapter_name)
    {
        $adapterClass = "\Zrashwani\NewsScrapper\Adapters\\".$adapter_name."Adapter";
        if (class_exists($adapterClass)) {
            $this->adapter = new $adapterClass();
        } else {
            $this->adapter = null;
        }

        return $this;
    }

    /**
     * scrap one source of news
     * @param string   $baseUrl      url to scrap list of news from
     * @param string   $linkSelector css selector for news links in page
     * @param int|NULL $limit        limit of news article to scrap,
     *      if not set it will scrap all matching the selector
     * @return array array of article items scrapped
     */
    public function scrapLinkGroup($baseUrl, $linkSelector, $limit = null)
    {
        $crawler = $this->scrapClient->request('GET', $baseUrl);

        $scrap_result = array();
        $theAdapter = new Adapters\DefaultAdapter();
        $theAdapter->currentUrl = $baseUrl;

        $isXpath = Selector::isXPath($linkSelector);
        $method = ($isXpath === false) ? 'filter' : 'filterXPath';
        
        $crawler->$method($linkSelector)
            ->each(
                function(Crawler $link_node) use (&$scrap_result, $theAdapter, &$limit) {
                    if (!is_null($limit) && count($scrap_result) >= $limit) {
                        return;
                    }
                            $link = $theAdapter
                                ->normalizeLink($link_node->attr('href'), true); //remove hash before scrapping

                            $article_info = $this->getLinkData($link);
                            $this->setAdapter(''); //reset default adapter after scrapping one link
                            $scrap_result[$link] = $article_info;
                }
            );

        return $scrap_result;
    }

    /**
     * Scrap information for single url
     * @param string $link
     * @return \stdClass
     */
    public function getLinkData($link)
    {
        $article_info = new \stdClass();
        $article_info->url = $link;

        $pageCrawler = $this->scrapClient->request('GET', $article_info->url);

        $selected_adapter = $this->getAdapter();
        if ($selected_adapter !== null) {
            $this->extractPageData($article_info, $pageCrawler, $selected_adapter);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        } else { //apply smart scrapping by iterating over all adapters
            foreach ($this->adaptersList as $adapter_name) {
                $this->setAdapter($adapter_name);
                $this->extractPageData($article_info, $pageCrawler, $this->getAdapter());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            }
        }


        return $article_info;
    }

    /**
     * Extracting page data from domCrawler according to rules defined by adapter
     * @param \stdClass                                        $article_info
     * @param Crawler                                          $pageCrawler
     * @param \Zrashwani\NewsScrapper\Adapters\AbstractAdapter $adapter      adapter used for scrapping
     */
    protected function extractPageData(
        $article_info,
        Crawler $pageCrawler,
        Adapters\AbstractAdapter $adapter
    ) {
        $adapter->currentUrl = $article_info->url; //associate link url to adapter
        
        $article_info->title = empty($article_info->title) === true ?
                    $adapter->extractTitle($pageCrawler) : $article_info->title;
        $article_info->image = empty($article_info->image) === true ?
                $adapter->extractImage($pageCrawler, $article_info->url) : $article_info->image;

        $article_info->description = empty($article_info->description) === true ?
                $adapter->extractDescription($pageCrawler) : $article_info->description;
        $article_info->keywords = !isset($article_info->keywords) || count($article_info->keywords) === 0 ?
                $adapter->extractKeywords($pageCrawler) : $article_info->keywords;
        
        $article_info->author = empty($article_info->author) === true ?
                $adapter->extractAuthor($pageCrawler) : $article_info->author;
        $article_info->publishDate = empty($article_info->publishDate) === true ?
                $adapter->extractPublishDate($pageCrawler) : $article_info->publishDate;
        $article_info->body = empty($article_info->body) === true ?
                $adapter->extractBody($pageCrawler) : $article_info->body;
        
    }
}


1			<?php
2
3			namespace Zrashwani\NewsScrapper;
4
5			use Goutte\Client as GoutteClient;
6			use Symfony\Component\DomCrawler\Crawler;
7			use Symfony\Component\BrowserKit\CookieJar;
8
9			/**
10			* Client to scrap article/news contents from serveral news sources
11			*
12			* @author Zeid Rashwani <[email protected]>
13			*/
14			class Client
15			{
16
17			protected $scrapClient;
18			protected $adaptersList = ['Microdata', 'HAtom', 'OpenGraph', 'JsonLD', 'Parsely', 'Default'];
19
20			/**
21			* Adapter to scrap content
22			* @var Adapters\AbstractAdapter
23			*/
24			protected $adapter;
25
26			/**
27			* Constructor
28			*/
29			public function __construct($adapter_name = null, CookieJar $cookie_jar = null)
30			{
31			$this->scrapClient = new GoutteClient([], null, $cookie_jar);
32
33			$this->scrapClient->followRedirects();
34			$this->scrapClient->getClient()->setDefaultOption(
35			'config/curl/'.
36			CURLOPT_SSL_VERIFYHOST,
37			false
38			);
39			$this->scrapClient->getClient()->setDefaultOption(
40			'config/curl/'.
41			CURLOPT_SSL_VERIFYPEER,
42			false
43			);
44
45			$this->setAdapter($adapter_name);
46			}
47
48			/**
49			* Getting selected adapter
50			* @return Adapters\AbstractAdapter
51			*/
52			public function getAdapter()
53			{
54			return $this->adapter;
55			}
56
57			/**
58			* Setting adapter preferred for scrapping
59			* @param string $adapter_name
60			* @throws \Exception
61			*/
62			public function setAdapter($adapter_name)
63			{
64			$adapterClass = "\Zrashwani\NewsScrapper\Adapters\\".$adapter_name."Adapter";
65			if (class_exists($adapterClass)) {
66			$this->adapter = new $adapterClass();
67			} else {
68			$this->adapter = null;
69			}
70
71			return $this;
72			}
73
74			/**
75			* scrap one source of news
76			* @param string $baseUrl url to scrap list of news from
77			* @param string $linkSelector css selector for news links in page
78			* @param int\|NULL $limit limit of news article to scrap,
79			* if not set it will scrap all matching the selector
80			* @return array array of article items scrapped
81			*/
82			public function scrapLinkGroup($baseUrl, $linkSelector, $limit = null)
83			{
84			$crawler = $this->scrapClient->request('GET', $baseUrl);
85
86			$scrap_result = array();
87			$theAdapter = new Adapters\DefaultAdapter();
88			$theAdapter->currentUrl = $baseUrl;
89
90			$isXpath = Selector::isXPath($linkSelector);
91			$method = ($isXpath === false) ? 'filter' : 'filterXPath';
92
93			$crawler->$method($linkSelector)
94			->each(
95			function(Crawler $link_node) use (&$scrap_result, $theAdapter, &$limit) {
96			if (!is_null($limit) && count($scrap_result) >= $limit) {
97			return;
98			}
99			$link = $theAdapter
100			->normalizeLink($link_node->attr('href'), true); //remove hash before scrapping
101
102			$article_info = $this->getLinkData($link);
103			$this->setAdapter(''); //reset default adapter after scrapping one link
104			$scrap_result[$link] = $article_info;
105			}
106			);
107
108			return $scrap_result;
109			}
110
111			/**
112			* Scrap information for single url
113			* @param string $link
114			* @return \stdClass
115			*/
116			public function getLinkData($link)
117			{
118			$article_info = new \stdClass();
119			$article_info->url = $link;
120
121			$pageCrawler = $this->scrapClient->request('GET', $article_info->url);
122
123			$selected_adapter = $this->getAdapter();
124			if ($selected_adapter !== null) {
125			$this->extractPageData($article_info, $pageCrawler, $selected_adapter);
			0 ignored issues – show Bug introduced 2016-02-29 22:20 UTC by Report Bug Copy Issue Report It seems like `$pageCrawler` defined by `$this->scrapClient->requ...T', $article_info->url)` on line `121` can be `null`; however, `Zrashwani\NewsScrapper\Client::extractPageData()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
126			} else { //apply smart scrapping by iterating over all adapters
127			foreach ($this->adaptersList as $adapter_name) {
128			$this->setAdapter($adapter_name);
129			$this->extractPageData($article_info, $pageCrawler, $this->getAdapter());
			0 ignored issues – show Bug introduced 2016-02-29 22:20 UTC by Report Bug Copy Issue Report It seems like `$pageCrawler` defined by `$this->scrapClient->requ...T', $article_info->url)` on line `121` can be `null`; however, `Zrashwani\NewsScrapper\Client::extractPageData()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
130			}
131			}
132
133
134			return $article_info;
135			}
136
137			/**
138			* Extracting page data from domCrawler according to rules defined by adapter
139			* @param \stdClass $article_info
140			* @param Crawler $pageCrawler
141			* @param \Zrashwani\NewsScrapper\Adapters\AbstractAdapter $adapter adapter used for scrapping
142			*/
143			protected function extractPageData(
144			$article_info,
145			Crawler $pageCrawler,
146			Adapters\AbstractAdapter $adapter
147			) {
148			$adapter->currentUrl = $article_info->url; //associate link url to adapter
149
150			$article_info->title = empty($article_info->title) === true ?
151			$adapter->extractTitle($pageCrawler) : $article_info->title;
152			$article_info->image = empty($article_info->image) === true ?
153			$adapter->extractImage($pageCrawler, $article_info->url) : $article_info->image;
			0 ignored issues – show Unused Code introduced 2015-11-28 14:05 UTC by Report Bug Copy Issue Report The call to `AbstractAdapter::extractImage()` has too many arguments starting with `$article_info->url`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
154			$article_info->description = empty($article_info->description) === true ?
155			$adapter->extractDescription($pageCrawler) : $article_info->description;
156			$article_info->keywords = !isset($article_info->keywords) \|\| count($article_info->keywords) === 0 ?
157			$adapter->extractKeywords($pageCrawler) : $article_info->keywords;
158
159			$article_info->author = empty($article_info->author) === true ?
160			$adapter->extractAuthor($pageCrawler) : $article_info->author;
161			$article_info->publishDate = empty($article_info->publishDate) === true ?
162			$adapter->extractPublishDate($pageCrawler) : $article_info->publishDate;
163			$article_info->body = empty($article_info->body) === true ?
164			$adapter->extractBody($pageCrawler) : $article_info->body;
165
166			}
167			}
168

zrashwani / news-scrapper

Client::getLinkData() A last analyzed 2017-08-17 08:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Client::getLinkData() A
last analyzed 2017-08-17 08:42 UTC