Zortje\MVC\Routing\Dispatcher::dispatch()

Complexity

Conditions	17
Paths	378

Size

Total Lines	135
Code Lines	61

Duplication

Lines	21
Ratio	15.56 %

Code Coverage

Tests	0
CRAP Score	306

Importance

Changes	15
Bugs	0	Features	0

<?php
    public function dispatch(Request $request): Response
    {
        /**
         * Figure out what controller to use and what action to call
         */
        $controllerFactory = new ControllerFactory($this->pdo, $this->configuration, $request, $this->getUserFromRequest($request));

It seems like $this->getUserFromRequest($request) targeting Zortje\MVC\Routing\Dispatcher::getUserFromRequest() can also be of type object<Zortje\MVC\Model\Table\Entity\Entity>; however, Zortje\MVC\Controller\ControllerFactory::__construct() does only seem to accept null|object<Zortje\MVC\User\User>, maybe add an additional type check?

        try {
            /**
             * @var Router $router
             */
            $router = $this->configuration->get('Router');

            list($controllerName, $action) = array_values($router->route($request->getPath()));

            /**
             * Validate and initialize controller
             */
            try {
                $controller = $controllerFactory->create($controllerName);
            } catch (\Exception $e) {
                if ($e instanceof ControllerNonexistentException || $e instanceof ControllerInvalidSuperclassException) {
                    /**
                     * Log invalid superclass
                     */
                    if ($this->logger && $e instanceof ControllerInvalidSuperclassException) {
                        $this->logger->addCritical('Controller must be an subclass of Zortje\MVC\Controller', [
                            'path'       => $request->getPath(),
                            'controller' => $controllerName
                        ]);
                    }

                    /**
                     * Log nonexistent
                     */
                    if ($this->logger && $e instanceof ControllerNonexistentException) {
                        $this->logger->addCritical('Controller is nonexistent', [
                            'path'       => $request->getPath(),
                            'controller' => $controllerName
                        ]);
                    }

                    $controller = $controllerFactory->create(NotFoundController::class);
                    $action     = 'index';
                } else {
                    throw $e;
                }
            }
        } catch (RouteNonexistentException $e) {
            /**
             * Log nonexistent route (404)
             */
            if ($this->logger) {
                $this->logger->addWarning('Route not connected', [
                    'path' => $request->getPath()
                ]);
            }

            $controller = $controllerFactory->create(NotFoundController::class);
            $action     = 'index';
        }

        /**
         * Validate and set controller action
         */
        try {
            $controller->setAction($action);
        } catch (ControllerActionProtectedInsufficientAuthenticationException $e) {
            /**
             * Log unauthed protected controller action (403)
             */
            if ($this->logger) {

This code seems to be duplicated across your project.

                $this->logger->addWarning('Unauthenticated attempt to access protected action', [
                    'path'       => $request->getPath(),
                    'controller' => $controller->getShortName(),
                    'action'     => $action
                ]);
            }

            /**
             * Save what controller and action was requested and then redirect to sign in form
             */
            $cookie = $request->getCookie();

            $cookie->set('SignIn.onSuccess.controller', $controller->getShortName());
            $cookie->set('SignIn.onSuccess.action', $action);

            $controller = $controllerFactory->create(SignInsController::class);
            $controller->setAction('form');
        } catch (ControllerActionPrivateInsufficientAuthenticationException $e) {
            /**
             * Log unauthed private controller action (403)
             */
            if ($this->logger) {

This code seems to be duplicated across your project.

                $this->logger->addWarning('Unauthenticated attempt to access private action', [
                    'path'       => $request->getPath(),
                    'controller' => $controller->getShortName(),
                    'action'     => $action
                ]);
            }

            $controller = $controllerFactory->create(NotFoundController::class);
            $controller->setAction('index');
        } catch (ControllerActionNonexistentException $e) {
            /**
             * Log nonexistent controller action
             */
            if ($this->logger) {

This code seems to be duplicated across your project.

                $this->logger->addCritical('Controller action is nonexistent', [
                    'path'       => $request->getPath(),
                    'controller' => $controller->getShortName(),
                    'action'     => $action
                ]);
            }

            $controller = $controllerFactory->create(NotFoundController::class);
            $controller->setAction('index');
        }

        /**
         * Create response from controller action headers and output
         */
        list($headers, $output) = array_values($controller->callAction());

        /**
         * Performance logging
         */
        if ($this->logger) {
            $time = number_format((microtime(true) - $_SERVER['REQUEST_TIME_FLOAT']) * 1000, 2);

            $this->logger->addDebug("Dispatched request in $time ms", ['path' => $request->getPath()]);
        }

        return new Response($headers, $request->getCookie(), $output);
    }