zordius /
lightncandy
Complex classes like Compiler often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Compiler, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 31 | class Compiler extends Validator |
||
| 32 | { |
||
| 33 | public static $lastParsed; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Compile template into PHP code |
||
| 37 | * |
||
| 38 | * @param array<string,array|string|integer> $context Current context |
||
| 39 | * @param string $template handlebars template |
||
| 40 | * |
||
| 41 | * @return string|null generated PHP code |
||
| 42 | */ |
||
| 43 | 640 | public static function compileTemplate(&$context, $template) { |
|
| 77 | |||
| 78 | /** |
||
| 79 | * Compose LightnCandy render codes for include() |
||
| 80 | * |
||
| 81 | * @param array<string,array|string|integer> $context Current context |
||
| 82 | * @param string $code generated PHP code |
||
| 83 | * |
||
| 84 | * @return string Composed PHP code |
||
| 85 | */ |
||
| 86 | 575 | public static function composePHPRender($context, $code) { |
|
| 138 | |||
| 139 | /** |
||
| 140 | * Get function name for standalone or none standalone template. |
||
| 141 | * |
||
| 142 | * @param array<string,array|string|integer> $context Current context of compiler progress. |
||
| 143 | * @param string $name base function name |
||
| 144 | * @param string $tag original handlabars tag for debug |
||
| 145 | * |
||
| 146 | * @return string compiled Function name |
||
| 147 | * |
||
| 148 | * @expect 'LR::test(' when input array('flags' => array('standalone' => 0, 'debug' => 0), 'runtime' => 'Runtime'), 'test', '' |
||
| 149 | * @expect 'LR::test2(' when input array('flags' => array('standalone' => 0, 'debug' => 0), 'runtime' => 'Runtime'), 'test2', '' |
||
| 150 | * @expect "\$cx['funcs']['test3'](" when input array('flags' => array('standalone' => 1, 'debug' => 0), 'runtime' => 'Runtime'), 'test3', '' |
||
| 151 | * @expect 'LR::debug(\'abc\', \'test\', ' when input array('flags' => array('standalone' => 0, 'debug' => 1), 'runtime' => 'Runtime'), 'test', 'abc' |
||
| 152 | */ |
||
| 153 | 511 | protected static function getFuncName(&$context, $name, $tag) { |
|
| 166 | |||
| 167 | /** |
||
| 168 | * Get string presentation of variables |
||
| 169 | * |
||
| 170 | * @param array<string,array|string|integer> $context current compile context |
||
| 171 | * @param array<array> $vn variable name array. |
||
| 172 | * @param array<string>|null $blockParams block param list |
||
| 173 | * |
||
| 174 | * @return array<string|array> variable names |
||
| 175 | * |
||
| 176 | * @expect array('array(array($in),array())', array('this')) when input array('flags'=>array('spvar'=>true)), array(null) |
||
| 177 | * @expect array('array(array($in,$in),array())', array('this', 'this')) when input array('flags'=>array('spvar'=>true)), array(null, null) |
||
| 178 | * @expect array('array(array(),array(\'a\'=>$in))', array('this')) when input array('flags'=>array('spvar'=>true)), array('a' => null) |
||
| 179 | */ |
||
| 180 | 207 | protected static function getVariableNames(&$context, $vn, $blockParams = null) { |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Get string presentation of a sub expression |
||
| 198 | * |
||
| 199 | * @param array<string,array|string|integer> $context current compile context |
||
| 200 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 201 | * |
||
| 202 | * @return array<string> code representing passed expression |
||
| 203 | */ |
||
| 204 | 35 | public static function compileSubExpression(&$context, $vars) { |
|
| 218 | |||
| 219 | /** |
||
| 220 | * Get string presentation of a subexpression or a variable |
||
| 221 | * |
||
| 222 | * @param array<array|string|integer> $context current compile context |
||
| 223 | * @param array<array|string|integer> $var variable parsed path |
||
| 224 | * |
||
| 225 | * @return array<string> variable names |
||
| 226 | */ |
||
| 227 | 344 | protected static function getVariableNameOrSubExpression(&$context, $var) { |
|
| 230 | |||
| 231 | /** |
||
| 232 | * Get string presentation of a variable |
||
| 233 | * |
||
| 234 | * @param array<array|string|integer> $var variable parsed path |
||
| 235 | * @param array<array|string|integer> $context current compile context |
||
| 236 | * @param array<string> $lookup extra lookup string as valid PHP variable name |
||
|
|
|||
| 237 | * |
||
| 238 | * @return array<string> variable names |
||
| 239 | * |
||
| 240 | * @expect array('$in', 'this') when input array('flags'=>array('spvar'=>true,'debug'=>0)), array(null) |
||
| 241 | * @expect array('((isset($in[\'true\']) && is_array($in)) ? $in[\'true\'] : null)', '[true]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('true') |
||
| 242 | * @expect array('((isset($in[\'false\']) && is_array($in)) ? $in[\'false\'] : null)', '[false]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('false') |
||
| 243 | * @expect array('true', 'true') when input array('flags'=>array('spvar'=>true,'debug'=>0)), array(0, 'true') |
||
| 244 | * @expect array('false', 'false') when input array('flags'=>array('spvar'=>true,'debug'=>0)), array(0, 'false') |
||
| 245 | * @expect array('((isset($in[\'2\']) && is_array($in)) ? $in[\'2\'] : null)', '[2]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('2') |
||
| 246 | * @expect array('2', '2') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0)), array(0, '2') |
||
| 247 | * @expect array('((isset($in[\'@index\']) && is_array($in)) ? $in[\'@index\'] : null)', '[@index]') when input array('flags'=>array('spvar'=>false,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('@index') |
||
| 248 | * @expect array("((isset(\$cx['sp_vars']['index']) && is_array(\$cx['sp_vars'])) ? \$cx['sp_vars']['index'] : null)", '@[index]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('@index') |
||
| 249 | * @expect array("((isset(\$cx['sp_vars']['key']) && is_array(\$cx['sp_vars'])) ? \$cx['sp_vars']['key'] : null)", '@[key]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('@key') |
||
| 250 | * @expect array("((isset(\$cx['sp_vars']['first']) && is_array(\$cx['sp_vars'])) ? \$cx['sp_vars']['first'] : null)", '@[first]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('@first') |
||
| 251 | * @expect array("((isset(\$cx['sp_vars']['last']) && is_array(\$cx['sp_vars'])) ? \$cx['sp_vars']['last'] : null)", '@[last]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('@last') |
||
| 252 | * @expect array('((isset($in[\'"a"\']) && is_array($in)) ? $in[\'"a"\'] : null)', '["a"]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('"a"') |
||
| 253 | * @expect array('"a"', '"a"') when input array('flags'=>array('spvar'=>true,'debug'=>0)), array(0, '"a"') |
||
| 254 | * @expect array('((isset($in[\'a\']) && is_array($in)) ? $in[\'a\'] : null)', '[a]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array('a') |
||
| 255 | * @expect array('((isset($cx[\'scopes\'][count($cx[\'scopes\'])-1][\'a\']) && is_array($cx[\'scopes\'][count($cx[\'scopes\'])-1])) ? $cx[\'scopes\'][count($cx[\'scopes\'])-1][\'a\'] : null)', '../[a]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array(1,'a') |
||
| 256 | * @expect array('((isset($cx[\'scopes\'][count($cx[\'scopes\'])-3][\'a\']) && is_array($cx[\'scopes\'][count($cx[\'scopes\'])-3])) ? $cx[\'scopes\'][count($cx[\'scopes\'])-3][\'a\'] : null)', '../../../[a]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array(3,'a') |
||
| 257 | * @expect array('((isset($in[\'id\']) && is_array($in)) ? $in[\'id\'] : null)', 'this.[id]') when input array('flags'=>array('spvar'=>true,'debug'=>0,'prop'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0)), array(null, 'id') |
||
| 258 | * @expect array('LR::v($cx, isset($in) ? $in : null, array(\'id\'))', 'this.[id]') when input array('flags'=>array('prop'=>true,'spvar'=>true,'debug'=>0,'method'=>0,'mustlok'=>0,'mustlam'=>0, 'lambda'=>0,'standalone'=>0), 'runtime' => 'Runtime'), array(null, 'id') |
||
| 259 | */ |
||
| 260 | 508 | protected static function getVariableName(&$context, $var, $lookup = null) { |
|
| 300 | |||
| 301 | /** |
||
| 302 | * Return compiled PHP code for a handlebars token |
||
| 303 | * |
||
| 304 | * @param array<string,array|string|integer> $context current compile context |
||
| 305 | * @param array<string,array|boolean> $info parsed information |
||
| 306 | * |
||
| 307 | * @return string Return compiled code segment for the token |
||
| 308 | */ |
||
| 309 | 535 | protected static function compileToken(&$context, $info) { |
|
| 338 | |||
| 339 | /** |
||
| 340 | * handle partial |
||
| 341 | * |
||
| 342 | * @param array<string,array|string|integer> $context current compile context |
||
| 343 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 344 | * |
||
| 345 | * @return string Return compiled code segment for the partial |
||
| 346 | */ |
||
| 347 | 64 | public static function partial(&$context, $vars) { |
|
| 370 | |||
| 371 | /** |
||
| 372 | * Return compiled PHP code for a handlebars inverted section begin token |
||
| 373 | * |
||
| 374 | * @param array<string,array|string|integer> $context current compile context |
||
| 375 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 376 | * |
||
| 377 | * @return string Return compiled code segment for the token |
||
| 378 | */ |
||
| 379 | 37 | protected static function invertedSection(&$context, $vars) { |
|
| 383 | |||
| 384 | /** |
||
| 385 | * Return compiled PHP code for a handlebars block custom helper begin token |
||
| 386 | * |
||
| 387 | * @param array<string,array|string|integer> $context current compile context |
||
| 388 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 389 | * @param boolean $inverted the logic will be inverted |
||
| 390 | * |
||
| 391 | * @return string Return compiled code segment for the token |
||
| 392 | */ |
||
| 393 | 54 | protected static function blockCustomHelper(&$context, $vars, $inverted = false) { |
|
| 404 | |||
| 405 | /** |
||
| 406 | * Return compiled PHP code for a handlebars block end token |
||
| 407 | * |
||
| 408 | * @param array<string,array|string|integer> $context current compile context |
||
| 409 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 410 | * |
||
| 411 | * @return string Return compiled code segment for the token |
||
| 412 | */ |
||
| 413 | 288 | protected static function blockEnd(&$context, $vars) { |
|
| 444 | |||
| 445 | /** |
||
| 446 | * Return compiled PHP code for a handlebars block begin token |
||
| 447 | * |
||
| 448 | * @param array<string,array|string|integer> $context current compile context |
||
| 449 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 450 | * |
||
| 451 | * @return string Return compiled code segment for the token |
||
| 452 | */ |
||
| 453 | 212 | protected static function blockBegin(&$context, $vars) { |
|
| 473 | |||
| 474 | /** |
||
| 475 | * compile {{#foo}} token |
||
| 476 | * |
||
| 477 | * @param array<string,array|string|integer> $context current compile context |
||
| 478 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 479 | * @param boolean $isEach the section is #each |
||
| 480 | * |
||
| 481 | * @return string|null Return compiled code segment for the token |
||
| 482 | */ |
||
| 483 | 153 | protected static function section(&$context, $vars, $isEach = false) { |
|
| 499 | |||
| 500 | /** |
||
| 501 | * compile {{with}} token |
||
| 502 | * |
||
| 503 | * @param array<string,array|string|integer> $context current compile context |
||
| 504 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 505 | * |
||
| 506 | * @return string|null Return compiled code segment for the token |
||
| 507 | */ |
||
| 508 | 17 | protected static function with(&$context, $vars) { |
|
| 515 | |||
| 516 | /** |
||
| 517 | * Return compiled PHP code for a handlebars custom helper token |
||
| 518 | * |
||
| 519 | * @param array<string,array|string|integer> $context current compile context |
||
| 520 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 521 | * @param boolean $raw is this {{{ token or not |
||
| 522 | * |
||
| 523 | * @return string|null Return compiled code segment for the token when the token is custom helper |
||
| 524 | */ |
||
| 525 | 397 | protected static function customHelper(&$context, $vars, $raw) { |
|
| 537 | |||
| 538 | /** |
||
| 539 | * Return compiled PHP code for a handlebars else token |
||
| 540 | * |
||
| 541 | * @param array<string,array|string|integer> $context current compile context |
||
| 542 | * |
||
| 543 | * @return string Return compiled code segment for the token when the token is else |
||
| 544 | */ |
||
| 545 | 46 | protected static function doElse(&$context) { |
|
| 555 | |||
| 556 | /** |
||
| 557 | * Return compiled PHP code for a handlebars lookup token |
||
| 558 | * |
||
| 559 | * @param array<string,array|string|integer> $context current compile context |
||
| 560 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 561 | * @param boolean $raw is this {{{ token or not |
||
| 562 | * |
||
| 563 | * @return string Return compiled code segment for the token |
||
| 564 | */ |
||
| 565 | 2 | protected static function compileLookup(&$context, &$vars, $raw) { |
|
| 574 | |||
| 575 | /** |
||
| 576 | * Return compiled PHP code for a handlebars variable token |
||
| 577 | * |
||
| 578 | * @param array<string,array|string|integer> $context current compile context |
||
| 579 | * @param array<boolean|integer|string|array> $vars parsed arguments list |
||
| 580 | * @param boolean $raw is this {{{ token or not |
||
| 581 | * |
||
| 582 | * @return string Return compiled code segment for the token |
||
| 583 | */ |
||
| 584 | 322 | protected static function compileVariable(&$context, &$vars, $raw) { |
|
| 592 | |||
| 593 | /** |
||
| 594 | * Add usage count to context |
||
| 595 | * |
||
| 596 | * @param array<string,array|string|integer> $context current context |
||
| 597 | * @param string $category ctegory name, can be one of: 'var', 'helpers', 'blockhelpers' |
||
| 598 | * @param string $name used name |
||
| 599 | * @param integer $count increment |
||
| 600 | * |
||
| 601 | * @expect 1 when input array('usedCount' => array('test' => array())), 'test', 'testname' |
||
| 602 | * @expect 3 when input array('usedCount' => array('test' => array('testname' => 2))), 'test', 'testname' |
||
| 603 | * @expect 5 when input array('usedCount' => array('test' => array('testname' => 2))), 'test', 'testname', 3 |
||
| 604 | */ |
||
| 605 | 511 | protected static function addUsageCount(&$context, $category, $name, $count = 1) { |
|
| 611 | } |
||
| 612 | |||
| 613 |
Loading history...
This check looks for
@paramannotations where the type inferred by our type inference engine differs from the declared type.It makes a suggestion as to what type it considers more descriptive.
Most often this is a case of a parameter that can be null in addition to its declared types.