ContextTest::testString() - Code Metrics - Inspection of "addContext method" - znarf/bouncer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf7eff...772dda )

by François

created 2016-06-17 11:04 UTC

ContextTest::testString() A

↳ Parent: ContextTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php

/*
 * This file is part of the Bouncer package.
 *
 * (c) François Hodierne <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Bouncer;

class ContextTest extends \PHPUnit_Framework_TestCase
{

    public function testString()
    {
        $bouncer = new Bouncer();

        $bouncer->addContext('key', 'value');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $context = $bouncer->getContext();
        $this->assertEquals($context['key'], 'value');

        $bouncer->addContext('key', 'newvalue');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $context = $bouncer->getContext();
        $this->assertEquals($context['key'], 'newvalue');
    }

    public function testArray()
    {
        $bouncer = new Bouncer();

        $bouncer->addContext('key', array('property' => 'value', 'property2' => 'value2'));
        $context = $bouncer->getContext();
        $this->assertEquals($context['key']['property'], 'value');

        $bouncer->addContext('key', array('property' => 'newvalue'));
        $context = $bouncer->getContext();
        $this->assertEquals($context['key']['property'], 'newvalue');
        $this->assertEquals($context['key']['property2'], 'value2');
    }

}


1			<?php
2
3			/*
4			* This file is part of the Bouncer package.
5			*
6			* (c) François Hodierne <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Bouncer;
13
14			class ContextTest extends \PHPUnit_Framework_TestCase
15			{
16
17			public function testString()
18			{
19			$bouncer = new Bouncer();
20
21			$bouncer->addContext('key', 'value');
			0 ignored issues – show Documentation introduced 2016-06-17 11:07 UTC by Report Bug Copy Issue Report `'value'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
22			$context = $bouncer->getContext();
23			$this->assertEquals($context['key'], 'value');
24
25			$bouncer->addContext('key', 'newvalue');
			0 ignored issues – show Documentation introduced 2016-06-17 11:07 UTC by Report Bug Copy Issue Report `'newvalue'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			$context = $bouncer->getContext();
27			$this->assertEquals($context['key'], 'newvalue');
28			}
29
30			public function testArray()
31			{
32			$bouncer = new Bouncer();
33
34			$bouncer->addContext('key', array('property' => 'value', 'property2' => 'value2'));
35			$context = $bouncer->getContext();
36			$this->assertEquals($context['key']['property'], 'value');
37
38			$bouncer->addContext('key', array('property' => 'newvalue'));
39			$context = $bouncer->getContext();
40			$this->assertEquals($context['key']['property'], 'newvalue');
41			$this->assertEquals($context['key']['property2'], 'value2');
42			}
43
44			}
45

znarf / bouncer

Push — master ( bf7eff...772dda )

ContextTest::testString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like