CacheTest   A
last analyzed

Complexity

Total Complexity 2

Size/Duplication

Total Lines 18
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 2

Importance

Changes 1
Bugs 1 Features 0
Metric Value
wmc 2
c 1
b 1
f 0
lcom 0
cbo 2
dl 0
loc 18
rs 10

1 Method

Rating   Name   Duplication   Size   Complexity  
A testMemcached() 0 13 2
1
<?php
2
3
/*
4
 * This file is part of the Bouncer package.
5
 *
6
 * (c) François Hodierne <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Bouncer;
13
14
class CacheTest extends \PHPUnit_Framework_TestCase
15
{
16
17
    public function testMemcached()
18
    {
19
      if (!class_exists('Memcached')) {
20
        $this->markTestSkipped('The Memcached extension is not available.');
21
        return;
22
      }
23
24
      $client = new \Memcached;
25
      $cache = new \Bouncer\Cache\Memcache(array('client' => $client));
26
      $bouncer = new \Bouncer\Bouncer(array('cache' => $cache));
27
      $this->assertInstanceOf('\\Bouncer\\Cache\\Memcache', $bouncer->getCache());
28
      $this->assertInstanceOf('\\Memcached', $bouncer->getCache()->getClient());
0 ignored issues
show
Bug introduced by
It seems like you code against a concrete implementation and not the interface Bouncer\Cache\CacheInterface as the method getClient() does only exist in the following implementations of said interface: Bouncer\Cache\Memcache, Bouncer\Cache\Redis.

Let’s take a look at an example:

interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the interface:

    interface User
    {
        /** @return string */
        public function getPassword();
    
        /** @return string */
        public function getDisplayName();
    }
    
Loading history...
29
    }
30
31
}
32