Zmaglica\RickAndMortyApiWrapper\Model\Character

Complexity

Total Complexity

12

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	locations()	0	6	1
A	getLocations()	0	4	1
A	origins()	0	6	1
A	getOrigins()	0	4	1
A	episodes()	0	6	1
A	getEpisodes()	0	4	1
B	extractIdsFromResponseBasedOnKey()	0	26	6

<?php

namespace Zmaglica\RickAndMortyApiWrapper\Model;

class Character extends AbstractModel
{
    /**
     * Get all locations without running API call. Useful if you want to perform additional filtering.
     *
     * @param bool $removeDuplicates
     * @return array|\Zmaglica\RickAndMortyApiWrapper\Api\AbstractApi
     */
    public function locations($removeDuplicates = false)
    {
        $ids = $this->extractIdsFromResponseBasedOnKey('location', $removeDuplicates);

        return $this->api->location()->whereId($ids);
    }

    /**
     * Get all locations.
     * @param bool $removeDuplicates
     * @return mixed
     */
    public function getLocations($removeDuplicates = false)
    {
        return $this->locations($removeDuplicates)->get();
    }

    /**
     * Get all origin locations. Useful if you want to perform additional filtering.
     *
     * @param bool $removeDuplicates
     * @return array|\Zmaglica\RickAndMortyApiWrapper\Api\AbstractApi
     */
    public function origins($removeDuplicates = false)
    {
        $ids = $this->extractIdsFromResponseBasedOnKey('origin', $removeDuplicates);

        return $this->api->location()->whereId($ids);
    }

    /**
     * Get all origin locations.
     *
     * @param bool $removeDuplicates
     * @return mixed
     */
    public function getOrigins($removeDuplicates = false)
    {
        return $this->origins($removeDuplicates)->get();
    }

    /**
     * Get all episodes. Useful if you want to perform additional filtering.
     *
     * @param bool $removeDuplicates
     * @return \Zmaglica\RickAndMortyApiWrapper\Api\AbstractApi
     */
    public function episodes($removeDuplicates = false)
    {
        $ids = $this->extractIdsFromResponseBasedOnKey('episode', $removeDuplicates);

        return $this->api->episode()->whereId($ids);
    }

    /**
     * Get all episodes
     *
     * @param bool $removeDuplicates
     * @return mixed
     */
    public function getEpisodes($removeDuplicates = false)
    {
        return $this->episodes($removeDuplicates)->get();
    }

    /**
     * This helper function will extract all URL ids by key. Key can be location, residence or episode
     * @param $key
     * @param $removeDuplicates
     * @return array
     */
    private function extractIdsFromResponseBasedOnKey($key, $removeDuplicates)

The parameter $key is not used and could be removed.

    {
        $ids = [];
        $urls = [];
        if ($this->info) {
            $urls = array_column($this->data['results'], 'location');
        } elseif (isset($this->data[0])) {
            $urls = array_column($this->data, 'location');
        } else {
            $urls[] = $this->data['location'];
        }
        $urls = array_column($urls, 'url');
        if ($removeDuplicates) {
            $urls = array_unique($urls);
        }

        foreach ($urls as $url) {
            $ids[] = substr(strrchr($url, '/'), 1);
            ;
        }
        if (!$ids) {

The expression $ids of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        return $ids;
    }
}