Zing\LaravelSentry\Middleware\SentryContext

Complexity

Total Complexity

6

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	handle()	0	17	3
A	resolveUserContext()	0	5	1
A	sentryIsBound()	0	3	1

<?php

declare(strict_types=1);

namespace Zing\LaravelSentry\Middleware;

use Closure;
use Illuminate\Contracts\Auth\Authenticatable;
use Illuminate\Contracts\Auth\Factory;
use function Sentry\configureScope;
use Sentry\State\Scope;
use Zing\LaravelSentry\Support\SentryIntegration;

class SentryContext
{
    /**
     * The authentication factory instance.
     *
     * @var \Illuminate\Contracts\Auth\Factory
     */
    protected $auth;

    /**
     * Create a new middleware instance.
     *
     * @param \Illuminate\Contracts\Auth\Factory $auth
     *
     * @return void
     */
    public function __construct(Factory $auth)
    {
        $this->auth = $auth;
    }

    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        if ($this->auth->guard()->guest()) {
            return $next($request);
        }

        if (! $this->sentryIsBound()) {
            return $next($request);
        }

        configureScope(
            function (Scope $scope): void {
                $scope->setUser($this->resolveUserContext($this->auth->getDefaultDriver(), $this->auth->guard()->user()));

It seems like $this->auth->guard()->user() can also be of type null; however, parameter $user of Zing\LaravelSentry\Middleware\SentryContext::resolveUserContext() does only seem to accept Illuminate\Contracts\Auth\Authenticatable, maybe add an additional type check?

            }
        );

        return $next($request);
    }

    protected function sentryIsBound(): bool
    {
        return SentryIntegration::bound();
    }

    /**
     * @param string $guard
     * @param \Illuminate\Contracts\Auth\Authenticatable $user
     *
     * @return array
     */
    protected function resolveUserContext($guard, Authenticatable $user): array

The parameter $guard is not used and could be removed.

    {
        return [
            'id' => $user->getAuthIdentifier(),
            'email' => $user->email,

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        ];
    }
}