Zing\QueryBuilder\Concerns\WithSorts::applySort()

Complexity

Conditions	3
Paths	2

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function applySort($inputs, $sorts)

The parameter $inputs is not used and could be removed.

    {
        foreach (['desc', 'asc'] as $direction) {
            $this->when($this->request->input($direction),

It seems like when() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                function (Builder $query, $descAttribute) use ($sorts, $direction) {
                    if (array_key_exists($descAttribute, $sorts)) {
                        $descAttribute = Arr::get($sorts, $descAttribute);
                    }

                    return $query->orderBy($descAttribute, $direction);
                }
            );
        }

        return $this;
    }