Zing\QueryBuilder\Concerns\WithSorts

Complexity

Total Complexity

3

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	applySort()	0	15	3

<?php

namespace Zing\QueryBuilder\Concerns;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Arr;

trait WithSorts
{
    /**
     * 排序逻辑.
     *
     * @param array $inputs
     * @param array $sorts
     *
     * @return mixed
     */
    protected function applySort($inputs, $sorts)

The parameter $inputs is not used and could be removed.

    {
        foreach (['desc', 'asc'] as $direction) {
            $this->when($this->request->input($direction),

It seems like when() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                function (Builder $query, $descAttribute) use ($sorts, $direction) {
                    if (array_key_exists($descAttribute, $sorts)) {
                        $descAttribute = Arr::get($sorts, $descAttribute);
                    }

                    return $query->orderBy($descAttribute, $direction);
                }
            );
        }

        return $this;
    }
}