Zing\QueryBuilder\Filters\FiltersExact

Complexity

Total Complexity

9

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isRelationProperty()	0	11	3
A	withRelationConstraint()	0	18	1
A	apply()	0	11	3
A	withPropertyConstraint()	0	7	2

<?php

declare(strict_types=1);

namespace Zing\QueryBuilder\Filters;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Query\Expression;
use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use Zing\QueryBuilder\Contracts\Filter;

class FiltersExact implements Filter
{
    protected $relationConstraints = [];

    public function apply(Builder $query, $value, $property): Builder
    {
        if ($property instanceof Expression) {
            return $this->withPropertyConstraint($query, $value, $property);

The expression return $this->withPropertyConstraint($query, $value, $property) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

        }

        if ($this->isRelationProperty($query, $property)) {
            return $this->withRelationConstraint($query, $value, $property);
        }

        return $this->withPropertyConstraint($query, $value, $property);

The expression return $this->withPropertyConstraint($query, $value, $property) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }

    protected function withPropertyConstraint(Builder $query, $value, $property)
    {
        if (is_array($value)) {
            return $query->whereIn($property, $value);
        }

        return $query->where($property, '=', $value);
    }

    protected function isRelationProperty(Builder $query, string $property): bool
    {
        if (! Str::contains($property, '.')) {
            return false;
        }

        if (in_array($property, $this->relationConstraints, true)) {
            return false;
        }

        return ! Str::startsWith($property, $query->getModel()->getTable() . '.');
    }

    protected function withRelationConstraint($query, $value, string $property)
    {
        [$relation, $property] = collect(explode('.', $property))
            ->pipe(
                function (Collection $parts) {
                    return [
                        $parts->except(count($parts) - 1)->map([Str::class, 'camel'])->implode('.'),
                        $parts->last(),
                    ];
                }
            );

        return $query->whereHas(
            $relation,
            function ($query) use ($value, $property): void {
                $this->relationConstraints[] = $property = $query->getModel()->getTable() . '.' . $property;

                $this->apply($query, $value, $property);
            }
        );
    }
}