Zing\QueryBuilder\Concerns\Queryable

Complexity

Total Complexity

5

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	paginate()	0	5	2
A	__construct()	0	9	1
A	fromBuilder()	0	7	2

<?php

declare(strict_types=1);

namespace Zing\QueryBuilder\Concerns;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Http\Request;

trait Queryable
{
    use WithFilters;
    use WithSearchable;
    use WithSorts;

    /**
     * @var \Illuminate\Http\Request
     */
    protected $request;

    public function __construct(Builder $builder, $request)
    {
        parent::__construct($builder->getQuery());

        $this->setModel($builder->getModel())->setEagerLoads($builder->getEagerLoads());

It seems like setModel() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->scopes = $builder->scopes;

The property scopes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->localMacros = $builder->localMacros;

The property localMacros does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->onDelete = $builder->onDelete;

The property onDelete does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->request = $request;
    }

    /**
     * @param \Illuminate\Database\Eloquent\Builder|string $baseQuery
     * @param \Illuminate\Http\Request $request
     *
     * @return \Zing\QueryBuilder\QueryBuilder
     */
    public static function fromBuilder($baseQuery, Request $request): self
    {
        if (is_subclass_of($baseQuery, Model::class)) {
            $baseQuery = forward_static_call([$baseQuery, 'query']);
        }

        return new self($baseQuery, $request);

It seems like $baseQuery can also be of type string; however, parameter $builder of Zing\QueryBuilder\Concerns\Queryable::__construct() does only seem to accept Illuminate\Database\Eloquent\Builder, maybe add an additional type check?

    }

    public function paginate($perPage = null, $columns = ['*'], $pageName = 'page', $page = null)
    {
        $perPage = $perPage ?: $this->request->input(config('query-builder.per_page.key', 'per_page'), config('query-builder.per_page.value', $this->model->getPerPage()));

        return parent::paginate((int) $perPage, $columns, $pageName, $page);
    }
}