Passed
Pull Request — master (#30)
by Zing
05:50
created

QueryBuilderFactory::create()   A

Complexity

Conditions 4
Paths 6

Size

Total Lines 15
Code Lines 7

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 8
CRAP Score 4

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 4
eloc 7
c 1
b 0
f 0
nc 6
nop 2
dl 0
loc 15
ccs 8
cts 8
cp 1
crap 4
rs 10
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Zing\QueryBuilder;
6
7
use Illuminate\Database\Eloquent\Model;
8
use Illuminate\Http\Request;
9
use Jenssegers\Mongodb\Eloquent\Builder;
10
use Jenssegers\Mongodb\Helpers\EloquentBuilder;
11
use Zing\QueryBuilder\Builders\HybridQueryBuilder;
12
use Zing\QueryBuilder\Builders\MongodbQueryBuilder;
13
use Zing\QueryBuilder\Builders\QueryBuilder;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Zing\QueryBuilder\QueryBuilder. Consider defining an alias.

Let?s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let?s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
14
15
class QueryBuilderFactory
16
{
17 1
    public static function create($baseQuery, Request $request)
18
    {
19 1
        if (is_subclass_of($baseQuery, Model::class)) {
20 1
            $baseQuery = forward_static_call([$baseQuery, 'query']);
21
        }
22
23 1
        if ($baseQuery instanceof Builder) {
24 1
            return new MongodbQueryBuilder($baseQuery, $request);
25
        }
26
27 1
        if ($baseQuery instanceof EloquentBuilder) {
28 1
            return new HybridQueryBuilder($baseQuery, $request);
29
        }
30
31 1
        return new QueryBuilder($baseQuery, $request);
32
    }
33
}
34