zikula / core

src/system/ExtensionsModule/Helper/ExtensionDependencyHelper.php

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
      * @param ExtensionDependencyEntity $dependency
      * @return bool
      */
-    private function bundleDependencySatisfied(ExtensionDependencyEntity &$dependency)
+    private function bundleDependencySatisfied(ExtensionDependencyEntity & $dependency)
     {
         if ($dependency->getModname() == "php") {
             // Do not use PHP_VERSION constant, because it might throw off the semver parser.

src/system/ThemeModule/Engine/Asset/Merger.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                 }
             }
         }
-        $cacheName = in_array($type, ['js', 'css']) ? "{$type}Cache" : null;
+        $cacheName = in_array($type, ['js', 'css']) ? "{$type}cache" : null;
         /** @var CacheProvider $cacheService */
         $cacheService = $this->$cacheName;
         $key = md5(serialize($assets)) . (int)$this->minify . (int)$this->compress . $this->lifetime . '.' . $type;

src/system/RoutesModule/Validator/Constraints/Base/AbstractListEntryValidator.php

Indentation +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 
         if ($constraint->propertyName == 'workflowState' && in_array($value, ['initial', 'deleted'])) {
             return;
-    	}
+        }
 
         $listEntries = $this->listEntriesHelper->getEntries($constraint->entityName, $constraint->propertyName);
         $allowedValues = [];

src/system/RoutesModule/Listener/Base/AbstractEntityLifecycleListener.php

Doc Comments +1 added lines, -1 removed lines

@@ -262,7 +262,7 @@
      *
      * @param EntityAccess $entity The given entity
      *
-     * @return Event The created event instance
+     * @return string The created event instance
      */
     protected function createFilterEvent($entity)
     {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Zikula\Core\Doctrine\EntityAccess;
 use Zikula\RoutesModule\RoutesEvents;
-use Zikula\RoutesModule\Event\FilterRouteEvent;
 
 /**
  * Event subscriber base class for entity lifecycle events.

src/system/UsersModule/Controller/AccessController.php

Braces +2 added lines, -1 removed lines

@@ -91,7 +91,8 @@
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
                 $loginFormEvent = new UserFormAwareEvent($form);
                 $dispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
+                if ($form->count() > 3) {
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
                     $form->handleRequest($request);
                     if ($form->isValid() && $form->isSubmitted()) {
                         $uid = $form->get('uid')->getData();

src/system/RoutesModule/Helper/Base/AbstractViewHelper.php

Indentation +4 added lines, -4 removed lines

@@ -243,10 +243,10 @@
         $siteName = $this->variableApi->getSystemVar('sitename');
         $pageTitle = iconv('UTF-8', 'ASCII//TRANSLIT', $this->pageVars->get('title', ''));
         $fileTitle = iconv('UTF-8', 'ASCII//TRANSLIT', $siteName)
-                   . '-'
-                   . ($pageTitle != '' ? $pageTitle . '-' : '')
-                   . date('Ymd') . '.pdf';
-       $fileTitle = str_replace(' ', '_', $fileTitle);
+                    . '-'
+                    . ($pageTitle != '' ? $pageTitle . '-' : '')
+                    . date('Ymd') . '.pdf';
+        $fileTitle = str_replace(' ', '_', $fileTitle);
     
         /*
         if (true === $this->request->query->getBoolean('dbg', false)) {

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,8 +20,8 @@
 use Zikula\Core\Response\PlainResponse;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
 use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;
-use Zikula\ThemeModule\Engine\ParameterBag;
 use Zikula\RoutesModule\Helper\ControllerHelper;
+use Zikula\ThemeModule\Engine\ParameterBag;
 
 /**
  * Helper base class for view layer methods.

src/system/UsersModule/Twig/Extension/ProfileExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Displays the avatar of a given user.
      *
-     * @param int|string $uid        The user's id or name
+     * @param integer $uid        The user's id or name
      * @param array      $parameters Any additional arguments (e.g. width, height, size, rating)
      *
      * @return string

src/system/RoutesModule/Controller/RouteController.php

Unused Use Statements +3 added lines, -4 removed lines

@@ -12,15 +12,14 @@
 
 namespace Zikula\RoutesModule\Controller;
 
-use Zikula\RoutesModule\Controller\Base\AbstractRouteController;
-
 use RuntimeException;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
-use Zikula\ThemeModule\Engine\Annotation\Theme;
+use Symfony\Component\Security\Core\Exception\AccessDeniedException;
+use Zikula\RoutesModule\Controller\Base\AbstractRouteController;
 use Zikula\RoutesModule\Entity\RouteEntity;
+use Zikula\ThemeModule\Engine\Annotation\Theme;
 
 /**
  * Route controller class providing navigation and interaction functionality.

src/system/RoutesModule/Entity/Repository/Base/AbstractRouteRepository.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -13,17 +13,16 @@
 namespace Zikula\RoutesModule\Entity\Repository\Base;
 
 use Doctrine\Common\Collections\ArrayCollection;
-use Gedmo\Sortable\Entity\Repository\SortableRepository;
-
 use Doctrine\ORM\Query;
 use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Tools\Pagination\Paginator;
+use Gedmo\Sortable\Entity\Repository\SortableRepository;
 use InvalidArgumentException;
 use Psr\Log\LoggerInterface;
 use Zikula\Common\Translator\TranslatorInterface;
-use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\RoutesModule\Entity\RouteEntity;
 use Zikula\RoutesModule\Helper\CollectionFilterHelper;
+use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 
 /**
  * Repository class used to implement own convenience methods for performing certain DQL queries.

Indentation +18 added lines, -18 removed lines

@@ -150,9 +150,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.createdBy', $newUserId)
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->set('tbl.createdBy', $newUserId)
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -183,9 +183,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.updatedBy', $newUserId)
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->set('tbl.updatedBy', $newUserId)
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -214,8 +214,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -244,8 +244,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -330,7 +330,7 @@ 
     {
         if (count($exclusions) > 0) {
             $qb->andWhere('tbl.id NOT IN (:excludedIdentifiers)')
-               ->setParameter('excludedIdentifiers', $exclusions);
+                ->setParameter('excludedIdentifiers', $exclusions);
         }
     
         return $qb;
@@ -390,7 +390,7 @@ 
         $offset = ($currentPage - 1) * $resultsPerPage;
     
         $query->setFirstResult($offset)
-              ->setMaxResults($resultsPerPage);
+                ->setMaxResults($resultsPerPage);
     
         return $query;
     }
@@ -487,7 +487,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (!empty($where)) {
             $qb->andWhere($where);
@@ -536,7 +536,7 @@ 
     {
         $qb = $this->getCountQuery('', false);
         $qb->andWhere('tbl.' . $fieldName . ' = :' . $fieldName)
-           ->setParameter($fieldName, $fieldValue);
+            ->setParameter($fieldName, $fieldValue);
     
         if ($excludeId > 0) {
             $qb = $this->addExclusion($qb, [$excludeId]);
@@ -579,7 +579,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (true === $useJoins) {
             $this->addJoinsToFrom($qb);
@@ -607,7 +607,7 @@ 
         if ($orderBy == 'RAND()') {
             // random selection
             $qb->addSelect('MOD(tbl.id, ' . mt_rand(2, 15) . ') AS HIDDEN randomIdentifiers')
-               ->add('orderBy', 'randomIdentifiers');
+                ->add('orderBy', 'randomIdentifiers');
     
             return $qb;
         }
@@ -626,12 +626,12 @@ 
         }
         if (false !== strpos($orderBy, 'tbl.createdBy')) {
             $qb->addSelect('tblCreator')
-               ->leftJoin('tbl.createdBy', 'tblCreator');
+                ->leftJoin('tbl.createdBy', 'tblCreator');
             $orderBy = str_replace('tbl.createdBy', 'tblCreator.uname', $orderBy);
         }
         if (false !== strpos($orderBy, 'tbl.updatedBy')) {
             $qb->addSelect('tblUpdater')
-               ->leftJoin('tbl.updatedBy', 'tblUpdater');
+                ->leftJoin('tbl.updatedBy', 'tblUpdater');
             $orderBy = str_replace('tbl.updatedBy', 'tblUpdater.uname', $orderBy);
         }
         $qb->add('orderBy', $orderBy);

Doc Comments +1 added lines, -1 removed lines

@@ -281,7 +281,7 @@
     /**
      * Selects an object from the database.
      *
-     * @param mixed   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
+     * @param integer   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
      * @param boolean $useJoins Whether to include joining related objects (optional) (default=true)
      * @param boolean $slimMode If activated only some basic fields are selected without using any joins (optional) (default=false)
      *