SearchableModuleCollectorPass::process() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/1.4'" - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d7040d...7fcf0d )

by Craig

created 2017-01-29 19:27 UTC

SearchableModuleCollectorPass::process() B

↳ Parent: SearchableModuleCollectorPass

Complexity

Conditions	5
Paths	5

Size

Total Lines	19
Code Lines	10

Duplication

Lines	19
Ratio	100 %

Importance

Changes

Metric	Value
cc	5
eloc	10
nc	5
nop	1
dl	19
loc	19
rs	8.8571
c	0
b	0
f	0

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\SearchModule\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Reference;

class SearchableModuleCollectorPass implements CompilerPassInterface

{
    public function process(ContainerBuilder $container)
    {
        if (!$container->hasDefinition('zikula_search_module.internal.searchable_module_collector')) {
            return;
        }

        $definition = $container->getDefinition('zikula_search_module.internal.searchable_module_collector');

        foreach ($container->findTaggedServiceIds('zikula.searchable_module') as $id => $tagParameters) {
            foreach ($tagParameters as $tagParameter) {
                if (!isset($tagParameter['bundleName'])) {
                    throw new \InvalidArgumentException(sprintf('Service "%s" must define the "bundleName" attribute on "zikula.searchable_module" tags.', $id));
                }
                $bundleName = $tagParameter['bundleName'];
            }

            $definition->addMethodCall('add', [$bundleName, new Reference($id)]);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
    }
}


1		<?php
2
3		/*
4		* This file is part of the Zikula package.
5		*
6		* Copyright Zikula Foundation - http://zikula.org/
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Zikula\SearchModule\DependencyInjection\Compiler;
13
14		use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
15		use Symfony\Component\DependencyInjection\ContainerBuilder;
16		use Symfony\Component\DependencyInjection\Reference;
17
18	View Code Duplication	class SearchableModuleCollectorPass implements CompilerPassInterface
		0 ignored issues – show Duplication introduced 2017-01-29 19:35 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		public function process(ContainerBuilder $container)
21		{
22		if (!$container->hasDefinition('zikula_search_module.internal.searchable_module_collector')) {
23		return;
24		}
25
26		$definition = $container->getDefinition('zikula_search_module.internal.searchable_module_collector');
27
28		foreach ($container->findTaggedServiceIds('zikula.searchable_module') as $id => $tagParameters) {
29		foreach ($tagParameters as $tagParameter) {
30		if (!isset($tagParameter['bundleName'])) {
31		throw new \InvalidArgumentException(sprintf('Service "%s" must define the "bundleName" attribute on "zikula.searchable_module" tags.', $id));
32		}
33		$bundleName = $tagParameter['bundleName'];
34		}
35
36		$definition->addMethodCall('add', [$bundleName, new Reference($id)]);
		0 ignored issues – show Bug introduced 2017-01-29 19:35 UTC by Report Bug Copy Issue Report The variable `$bundleName` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
37		}
38		}
39		}
40

zikula / core

Push — master ( d7040d...7fcf0d )

SearchableModuleCollectorPass::process() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like