Completed
Push — master ( 7065a9...1a6be8 )
by Craig
08:16
created
src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/AbstractController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     }
75 75
 
76 76
     /**
77
-     * @param $moduleName
77
+     * @param string $moduleName
78 78
      * @return bool
79 79
      */
80 80
     protected function installModule($moduleName)
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     /**
119 119
      * Set an admin category for a module or set to default
120 120
      * @param $moduleName
121
-     * @param $translatedCategoryName
121
+     * @param string $translatedCategoryName
122 122
      */
123 123
     protected function setModuleCategory($moduleName, $translatedCategoryName)
124 124
     {
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreBundle/Translation/ZikulaJsFileExtractor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
         preg_match_all($argumentsRegex, file_get_contents($file), $singularMatches);
46 46
         foreach ($singularMatches[2] as $string) {
47 47
             $message = new Message($string, self::JAVASCRIPT_DOMAIN);
48
-            $message->addSource(new FileSource((string) $file));
48
+            $message->addSource(new FileSource((string)$file));
49 49
             $catalogue->add($message);
50 50
         }
51 51
         // plural type
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         foreach ($pluralMatches[2] as $key => $singularString) {
55 55
             $fullString = $singularString . '|' . $pluralMatches[4][$key];
56 56
             $message = new Message($fullString, self::JAVASCRIPT_DOMAIN);
57
-            $message->addSource(new FileSource((string) $file));
57
+            $message->addSource(new FileSource((string)$file));
58 58
             $catalogue->add($message);
59 59
         }
60 60
     }
Please login to merge, or discard this patch.
src/system/MenuModule/Controller/MenuController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,10 +75,10 @@
 block discarded – undo
75 75
             [
76 76
                 'decorate' => true,
77 77
                 'html' => true,
78
-                'childOpen' => function ($node) {
78
+                'childOpen' => function($node) {
79 79
                     return '<li class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
80 80
                 },
81
-                'nodeDecorator' => function ($node) {
81
+                'nodeDecorator' => function($node) {
82 82
                     return '<a href="#">' . $node['title'] . ' (' . $node['id'] . ')</a>';
83 83
                 }
84 84
             ]
Please login to merge, or discard this patch.
src/system/RoutesModule/Controller/Base/AbstractRouteController.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -122,6 +122,10 @@
 block discarded – undo
122 122
 
123 123
     /**
124 124
      * This method includes the common implementation code for adminView() and view().
125
+     * @param string $sort
126
+     * @param string $sortdir
127
+     * @param integer $pos
128
+     * @param integer $num
125 129
      */
126 130
     protected function viewInternal(Request $request, $sort, $sortdir, $pos, $num, $isAdmin = false)
127 131
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -506,7 +506,7 @@
 block discarded – undo
506 506
             try {
507 507
                 // execute the workflow action
508 508
                 $success = $workflowHelper->executeAction($entity, $action);
509
-            } catch(\Exception $e) {
509
+            } catch (\Exception $e) {
510 510
                 $this->addFlash('error', $this->__f('Sorry, but an error occured during the %action% action.', ['%action%' => $action]) . '  ' . $e->getMessage());
511 511
                 $logger->error('{app}: User {user} tried to execute the {action} workflow action for the {entity} with id {id}, but failed. Error details: {errorMessage}.', ['app' => 'ZikulaRoutesModule', 'user' => $userName, 'action' => $action, 'entity' => 'route', 'id' => $itemId, 'errorMessage' => $e->getMessage()]);
512 512
             }
Please login to merge, or discard this patch.
src/system/SearchModule/DependencyInjection/ZikulaSearchExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      */
27 27
     public function load(array $configs, ContainerBuilder $container)
28 28
     {
29
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
29
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
30 30
 
31 31
         $loader->load('services.yml');
32 32
         $loader->load('doctrine.yml');
Please login to merge, or discard this patch.
src/system/SearchModule/Block/SearchBlock.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
         }
96 96
         // remove disabled
97 97
         foreach ($searchModules as $displayName => $moduleName) {
98
-            if ((bool) $this->getVar('disable_' . $moduleName, false)) {
98
+            if ((bool)$this->getVar('disable_' . $moduleName, false)) {
99 99
                 unset($searchModules[$displayName]);
100 100
             }
101 101
         }
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/FormExtensionBundle/Twig/Extension/FormExtension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     /**
48 48
      * Returns a list of functions to add to the existing list.
49 49
      *
50
-     * @return array An array of functions
50
+     * @return \Twig_SimpleFunction[] An array of functions
51 51
      */
52 52
     public function getFunctions()
53 53
     {
Please login to merge, or discard this patch.
src/system/ThemeModule/EventListener/CreateThemedResponseListener.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -108,6 +108,9 @@
 block discarded – undo
108 108
         $response->setContent($content);
109 109
     }
110 110
 
111
+    /**
112
+     * @param string $search
113
+     */
111 114
     private function readdUntrimmedBlocks($search, $replace, &$subject)
112 115
     {
113 116
         $len = strlen($search);
Please login to merge, or discard this patch.
src/system/UsersModule/Controller/AccessController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
     /**
135 135
      * @param UserEntity $user
136 136
      * @param $selectedMethod
137
-     * @param $returnUrl
137
+     * @param string $returnUrl
138 138
      * @return mixed
139 139
      */
140 140
     private function dispatchLoginSuccessEvent(UserEntity $user, $selectedMethod, $returnUrl)
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,8 @@
 block discarded – undo
91 91
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
92 92
                 $loginFormEvent = new UserFormAwareEvent($form);
93 93
                 $dispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
94
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
94
+                if ($form->count() > 3) {
95
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
95 96
                     $form->handleRequest($request);
96 97
                     if ($form->isValid() && $form->isSubmitted()) {
97 98
                         $uid = $form->get('uid')->getData();
Please login to merge, or discard this patch.