Completed
Push — master ( f1d9df...fe9150 )
by Craig
07:11
created
src/system/CategoriesModule/Form/Type/CategoriesType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -57,10 +57,10 @@  discard block
 block discarded – undo
57 57
 
58 58
         /** @var CategoryRegistryEntity[] $registries */
59 59
         foreach ($registries as $registry) {
60
-            $queryBuilderClosure = function (CategoryRepositoryInterface $repo) use ($registry, $options) {
60
+            $queryBuilderClosure = function(CategoryRepositoryInterface $repo) use ($registry, $options) {
61 61
                 return $repo->getChildrenQueryBuilder($registry->getCategory(), $options['direct']);
62 62
             };
63
-            $choiceLabelClosure = function (CategoryEntity $category) use ($registry) {
63
+            $choiceLabelClosure = function(CategoryEntity $category) use ($registry) {
64 64
                 $indent = str_repeat('--', $category->getLvl() - $registry->getCategory()->getLvl() - 1);
65 65
 
66 66
                 return (!empty($indent) ? '|' : '') . $indent . $category->getName();
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         $resolver->setAllowedTypes('entityCategoryClass', 'string');
120 120
         $resolver->setAllowedTypes('em', [ObjectManager::class, 'null']);
121 121
 
122
-        $resolver->addAllowedValues('entityCategoryClass', function ($value) {
122
+        $resolver->addAllowedValues('entityCategoryClass', function($value) {
123 123
             return is_subclass_of($value, AbstractCategoryAssignment::class);
124 124
         });
125 125
     }
Please login to merge, or discard this patch.
src/system/CategoriesModule/Controller/NodeController.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
                 $newCategory->setName($category->getName() . 'copy');
55 55
                 $displayNames = [];
56 56
                 foreach ($newCategory->getDisplay_name() as $locale => $displayName) {
57
-                    $displayNames[$locale] = $displayName . ' ' .$this->__('copy');
57
+                    $displayNames[$locale] = $displayName . ' ' . $this->__('copy');
58 58
                 }
59 59
                 $newCategory->setDisplay_name($displayNames);
60 60
                 $action = 'edit';
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,8 @@
 block discarded – undo
70 70
                         $parent = $repo->find($parentId);
71 71
                         $category->setParent($parent);
72 72
                         $category->setRoot($parent->getRoot());
73
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
73
+                    } elseif (empty($parent) && $request->request->has('after')) {
74
+// sibling of top-level child
74 75
                         $sibling = $repo->find($request->request->get('after'));
75 76
                         $category->setParent($sibling->getParent());
76 77
                         $category->setRoot($sibling->getRoot());
Please login to merge, or discard this patch.
src/system/CategoriesModule/Controller/CategoryController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         return [
80 80
             'decorate' => true,
81 81
             'html' => true,
82
-            'childOpen' => function ($node) {
82
+            'childOpen' => function($node) {
83 83
                 $jsTreeData = [];
84 84
                 $jsTreeData['disabled'] = $node['status'] != 'A';
85 85
                 $jsTreeData['type'] = $node['is_leaf'] ? 'leaf' : 'default';
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
                 return '<li ' . $jsTreeData . 'class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
89 89
             },
90
-            'nodeDecorator' => function ($node) use ($locale) {
90
+            'nodeDecorator' => function($node) use ($locale) {
91 91
                 $displayName = isset($node['display_name'][$locale]) ? $node['display_name'][$locale] : $node['name'];
92 92
                 $title = ' title="' . $this->createTitleAttribute($node, $displayName, $locale) . '"';
93 93
                 $classes = [];
Please login to merge, or discard this patch.
src/system/RoutesModule/Listener/InstallerListener.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
     /**
50 50
      * InstallerListener constructor.
51 51
      *
52
-     * @param ObjectManager $objectManager
53 52
      */
54 53
     public function __construct(
55 54
         CacheClearer $cacheClearer,
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Handler/Route/EditHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,8 +63,8 @@
 block discarded – undo
63 63
     {
64 64
         $entity = $this->entityRef;
65 65
 
66
-        list($controller, ) = $this->sanitizeHelper->sanitizeController($entity['controller']);
67
-        list($action, ) = $this->sanitizeHelper->sanitizeAction($entity['action']);
66
+        list($controller,) = $this->sanitizeHelper->sanitizeController($entity['controller']);
67
+        list($action,) = $this->sanitizeHelper->sanitizeAction($entity['action']);
68 68
 
69 69
         $entity['controller'] = $controller;
70 70
         $entity['action'] = $action;
Please login to merge, or discard this patch.
src/system/SearchModule/Twig/TwigExtension.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     /**
80 80
      * Returns a list of custom Twig functions.
81 81
      *
82
-     * @return array
82
+     * @return \Twig_SimpleFunction[]
83 83
      */
84 84
     public function getFunctions()
85 85
     {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
     /**
97 97
      * Returns a list of custom Twig filters.
98 98
      *
99
-     * @return array
99
+     * @return \Twig_SimpleFilter[]
100 100
      */
101 101
     public function getFilters()
102 102
     {
Please login to merge, or discard this patch.
src/system/ExtensionsModule/Helper/ExtensionDependencyHelper.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -203,9 +203,9 @@
 block discarded – undo
203 203
     /**
204 204
      * Determine if a $currentVersion value is between $requiredMin and $requiredMax.
205 205
      *
206
-     * @param $requiredMin
207
-     * @param $requiredMax
208
-     * @param $currentVersion
206
+     * @param string $requiredMin
207
+     * @param string $requiredMax
208
+     * @param string $currentVersion
209 209
      * @return bool
210 210
      */
211 211
     private function meetsVersionRequirements($requiredMin, $requiredMax, $currentVersion)
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
      * @param ExtensionDependencyEntity $dependency
159 159
      * @return bool
160 160
      */
161
-    private function bundleDependencySatisfied(ExtensionDependencyEntity &$dependency)
161
+    private function bundleDependencySatisfied(ExtensionDependencyEntity & $dependency)
162 162
     {
163 163
         if ($dependency->getModname() == "php") {
164 164
             // Do not use PHP_VERSION constant, because it might throw off the semver parser.
Please login to merge, or discard this patch.
RoutesModule/Validator/Constraints/Base/AbstractListEntryValidator.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
 
64 64
         if ($constraint->propertyName == 'workflowState' && in_array($value, ['initial', 'deleted'])) {
65 65
             return;
66
-    	}
66
+        }
67 67
 
68 68
         $listEntries = $this->listEntriesHelper->getEntries($constraint->entityName, $constraint->propertyName);
69 69
         $allowedValues = [];
Please login to merge, or discard this patch.
lib/Zikula/Bundle/CoreInstallerBundle/Controller/AjaxUpgradeController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -43,8 +43,8 @@  discard block
 block discarded – undo
43 43
     public function __construct(ContainerInterface $container)
44 44
     {
45 45
         parent::__construct($container);
46
-        $originalParameters = Yaml::parse(file_get_contents($this->container->get('kernel')->getRootDir() .'/config/parameters.yml'));
47
-        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
46
+        $originalParameters = Yaml::parse(file_get_contents($this->container->get('kernel')->getRootDir() . '/config/parameters.yml'));
47
+        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
48 48
         // load and set new default values from the original parameters.yml file into the custom_parameters.yml file.
49 49
         $this->yamlManager->setParameters(array_merge($originalParameters['parameters'], $this->yamlManager->getParameters()));
50 50
         $currentVersion = $this->container->getParameter(ZikulaKernel::CORE_INSTALLED_VERSION_PARAM);
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
         $stage = $request->request->get('stage');
57 57
         $this->container->setParameter('upgrading', true);
58 58
         $status = $this->executeStage($stage);
59
-        $response = ['status' => (bool) $status];
59
+        $response = ['status' => (bool)$status];
60 60
         if (is_array($status)) {
61 61
             $response['results'] = $status;
62 62
         }
Please login to merge, or discard this patch.