Completed
Pull Request — master (#4111)
by Craig
07:44 queued 02:51
created
src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -163,17 +163,17 @@  discard block
 block discarded – undo
163 163
             if ((!is_numeric($v) && '' !== $v) || (is_numeric($v) && 0 < $v)) {
164 164
                 if ('workflowState' === $k && 0 === strpos($v, '!')) {
165 165
                     $qb->andWhere('tbl.' . $k . ' != :' . $k)
166
-                       ->setParameter($k, substr($v, 1));
166
+                        ->setParameter($k, substr($v, 1));
167 167
                 } elseif (0 === strpos($v, '%')) {
168 168
                     $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
169
-                       ->setParameter($k, '%' . substr($v, 1) . '%');
169
+                        ->setParameter($k, '%' . substr($v, 1) . '%');
170 170
                 } elseif (in_array($k, ['schemes', 'methods'], true)) {
171 171
                     // multi list filter
172 172
                     $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
173
-                       ->setParameter($k, '%' . $v . '%');
173
+                        ->setParameter($k, '%' . $v . '%');
174 174
                 } else {
175 175
                     $qb->andWhere('tbl.' . $k . ' = :' . $k)
176
-                       ->setParameter($k, $v);
176
+                        ->setParameter($k, $v);
177 177
                 }
178 178
             }
179 179
         }
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
             // per default we show approved routes only
207 207
             $onlineStates = ['approved'];
208 208
             $qb->andWhere('tbl.workflowState IN (:onlineStates)')
209
-               ->setParameter('onlineStates', $onlineStates);
209
+                ->setParameter('onlineStates', $onlineStates);
210 210
         }
211 211
     
212 212
         return $qb;
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
         }
271 271
     
272 272
         $qb->andWhere('tbl.createdBy = :userId')
273
-           ->setParameter('userId', $userId);
273
+            ->setParameter('userId', $userId);
274 274
     
275 275
         return $qb;
276 276
     }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@
 block discarded – undo
191 191
             return $qb;
192 192
         }
193 193
     
194
-        $showOnlyOwnEntries = (bool)$request->query->getInt('own', (int) $this->showOnlyOwnEntries);
194
+        $showOnlyOwnEntries = (bool)$request->query->getInt('own', (int)$this->showOnlyOwnEntries);
195 195
         if ($showOnlyOwnEntries) {
196 196
             $qb = $this->addCreatorFilter($qb);
197 197
         }
Please login to merge, or discard this patch.
src/system/UsersModule/Controller/AccessController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,8 @@
 block discarded – undo
123 123
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
124 124
                 $loginFormEvent = new UserFormAwareEvent($form);
125 125
                 $eventDispatcher->dispatch($loginFormEvent, AccessEvents::AUTHENTICATION_FORM);
126
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
126
+                if ($form->count() > 3) {
127
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
127 128
                     $form->handleRequest($request);
128 129
                     if ($form->isSubmitted() && $form->isValid()) {
129 130
                         $uid = $form->get('uid')->getData();
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Handler/Route/Base/AbstractEditHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@
 block discarded – undo
282 282
                 return $this->router->generate($routePrefix . 'view');
283 283
             case 'userOwnView':
284 284
             case 'adminOwnView':
285
-                return $this->router->generate($routePrefix . 'view', [ 'own' => 1 ]);
285
+                return $this->router->generate($routePrefix . 'view', ['own' => 1]);
286 286
             case 'userDisplay':
287 287
             case 'adminDisplay':
288 288
                 if (
Please login to merge, or discard this patch.
src/system/MailerModule/Api/MailerApi.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -256,7 +256,7 @@
 block discarded – undo
256 256
                 // access the logging channel
257 257
                 $logger = new Logger('mailer');
258 258
                 $logger->pushHandler(new StreamHandler($logFile, Logger::INFO));
259
-                $logger->addError("Could not send message to: ${emailList} :: " . $this->message->toString());
259
+                $logger->addError("Could not send message to: ${emaillist} :: " . $this->message->toString());
260 260
             }
261 261
 
262 262
             $this->eventDispatcher->dispatch($event, MailerEvents::SEND_MESSAGE_FAILURE);
Please login to merge, or discard this patch.
src/system/ExtensionsModule/Command/ZikulaExtensionUninstallCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
         $requiredDependents = $this->dependencyHelper->getDependentExtensions($extension);
56 56
         if (!empty($requiredDependents)) {
57 57
             if ($input->isInteractive()) {
58
-                $names = implode(', ', array_map(function ($dependent) {
58
+                $names = implode(', ', array_map(function($dependent) {
59 59
                     return $dependent->getModname();
60 60
                 }, $requiredDependents));
61 61
 
Please login to merge, or discard this patch.
src/system/ZAuthModule/Listener/UserDeleteListener.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 
55 55
     public function deleteUsers(GenericEvent $event): void
56 56
     {
57
-        $deletedUid = (int) $event->getSubject();
57
+        $deletedUid = (int)$event->getSubject();
58 58
         $this->mappingRepository->removeByZikulaId($deletedUid);
59 59
         $this->verificationRepository->removeByZikulaId($deletedUid);
60 60
     }
Please login to merge, or discard this patch.
src/system/RoutesModule/Listener/Base/AbstractUserListener.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
      */
121 121
     public function delete(GenericEvent $event): void
122 122
     {
123
-        $userId = (int) $event->getSubject();
123
+        $userId = (int)$event->getSubject();
124 124
     
125 125
         
126 126
         $repo = $this->entityFactory->getRepository('route');
Please login to merge, or discard this patch.
src/system/RoutesModule/Helper/Base/AbstractControllerHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
         $templateParameters['all'] = 'csv' === $request->getRequestFormat() ? 1 : $request->query->getInt('all');
153 153
         $showOnlyOwnEntriesSetting = (bool)$request->query->getInt(
154 154
             'own',
155
-            (int) $this->variableApi->get('ZikulaRoutesModule', 'showOnlyOwnEntries')
155
+            (int)$this->variableApi->get('ZikulaRoutesModule', 'showOnlyOwnEntries')
156 156
         );
157 157
         $showOnlyOwnEntriesSetting = $showOnlyOwnEntriesSetting ? 1 : 0;
158 158
         $templateParameters['own'] = $showOnlyOwnEntriesSetting;
Please login to merge, or discard this patch.
src/system/PermissionsModule/Tests/Api/PermissionApiTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         $this->userRepo
77 77
             ->method('findByUids')
78 78
             ->with($this->anything())
79
-            ->willReturnCallback(function (array $uids) {
79
+            ->willReturnCallback(function(array $uids) {
80 80
                 $groups = new ArrayCollection();
81 81
                 // getGroups returns [gid => $group, gid => $group, ...]
82 82
                 if (in_array(self::RANDOM_USER_ID, $uids, true)) {
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
         $this->currentUserApi
145 145
             ->method('get')
146 146
             ->with($this->equalTo('uid'))
147
-            ->willReturnCallback(static function () use ($userId) {
147
+            ->willReturnCallback(static function() use ($userId) {
148 148
                 return $userId ?? Constant::USER_ID_ANONYMOUS;
149 149
             });
150 150
         $api = new PermissionApi($this->permRepo, $this->userRepo, $this->currentUserApi, $this->translator);
Please login to merge, or discard this patch.