zikula / core

src/system/CategoriesModule/Controller/NodeController.php

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
                         $parent = $repo->find($parentId);
                         $category->setParent($parent);
                         $category->setRoot($parent->getRoot());
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
+                    } elseif (empty($parent) && $request->request->has('after')) {
+// sibling of top-level child
                         $sibling = $repo->find($request->request->get('after'));
                         $category->setParent($sibling->getParent());
                         $category->setRoot($sibling->getRoot());

src/system/RoutesModule/Routing/RouteLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -246,7 +246,7 @@
      * @param AbstractBundle $bundle The bundle
      * @param string         $bundleName The bundle's name
      *
-     * @return array The legacy $type and $func parameters
+     * @return string[] The legacy $type and $func parameters
      */
     private function setZikulaDefaults(Route $route, AbstractBundle $bundle, $bundleName)
     {

src/system/ExtensionsModule/Helper/ExtensionDependencyHelper.php

Spacing +1 added lines, -1 removed lines

@@ -158,7 +158,7 @@
      * @param ExtensionDependencyEntity $dependency
      * @return bool
      */
-    private function bundleDependencySatisfied(ExtensionDependencyEntity &$dependency)
+    private function bundleDependencySatisfied(ExtensionDependencyEntity & $dependency)
     {
         if ($dependency->getModname() == "php") {
             // Do not use PHP_VERSION constant, because it might throw off the semver parser.

src/system/ThemeModule/Engine/Asset/Merger.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                 }
             }
         }
-        $cacheName = in_array($type, ['js', 'css']) ? "{$type}Cache" : null;
+        $cacheName = in_array($type, ['js', 'css']) ? "{$type}cache" : null;
         /** @var CacheProvider $cacheService */
         $cacheService = $this->$cacheName;
         $key = md5(serialize($assets)) . (int)$this->minify . (int)$this->compress . $this->lifetime . '.' . $type;

src/system/RoutesModule/Validator/Constraints/Base/AbstractListEntryValidator.php

Indentation +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 
         if ($constraint->propertyName == 'workflowState' && in_array($value, ['initial', 'deleted'])) {
             return;
-    	}
+        }
 
         $listEntries = $this->listEntriesHelper->getEntries($constraint->entityName, $constraint->propertyName);
         $allowedValues = [];

src/system/RoutesModule/Listener/Base/AbstractEntityLifecycleListener.php

Doc Comments +1 added lines, -1 removed lines

@@ -262,7 +262,7 @@
      *
      * @param EntityAccess $entity The given entity
      *
-     * @return Event The created event instance
+     * @return string The created event instance
      */
     protected function createFilterEvent($entity)
     {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Zikula\Core\Doctrine\EntityAccess;
 use Zikula\RoutesModule\RoutesEvents;
-use Zikula\RoutesModule\Event\FilterRouteEvent;
 
 /**
  * Event subscriber base class for entity lifecycle events.

src/system/UsersModule/Controller/AccessController.php

Braces +2 added lines, -1 removed lines

@@ -91,7 +91,8 @@
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
                 $loginFormEvent = new UserFormAwareEvent($form);
                 $dispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
+                if ($form->count() > 3) {
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
                     $form->handleRequest($request);
                     if ($form->isValid() && $form->isSubmitted()) {
                         $uid = $form->get('uid')->getData();

src/system/RoutesModule/Helper/Base/AbstractViewHelper.php

Indentation +4 added lines, -4 removed lines

@@ -243,10 +243,10 @@
         $siteName = $this->variableApi->getSystemVar('sitename');
         $pageTitle = iconv('UTF-8', 'ASCII//TRANSLIT', $this->pageVars->get('title', ''));
         $fileTitle = iconv('UTF-8', 'ASCII//TRANSLIT', $siteName)
-                   . '-'
-                   . ($pageTitle != '' ? $pageTitle . '-' : '')
-                   . date('Ymd') . '.pdf';
-       $fileTitle = str_replace(' ', '_', $fileTitle);
+                    . '-'
+                    . ($pageTitle != '' ? $pageTitle . '-' : '')
+                    . date('Ymd') . '.pdf';
+        $fileTitle = str_replace(' ', '_', $fileTitle);
     
         /*
         if (true === $this->request->query->getBoolean('dbg', false)) {

Unused Use Statements +1 added lines, -1 removed lines

@@ -20,8 +20,8 @@
 use Zikula\Core\Response\PlainResponse;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
 use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;
-use Zikula\ThemeModule\Engine\ParameterBag;
 use Zikula\RoutesModule\Helper\ControllerHelper;
+use Zikula\ThemeModule\Engine\ParameterBag;
 
 /**
  * Helper base class for view layer methods.

src/system/UsersModule/Twig/Extension/ProfileExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -66,7 +66,7 @@
     /**
      * Displays the avatar of a given user.
      *
-     * @param int|string $uid        The user's id or name
+     * @param integer $uid        The user's id or name
      * @param array      $parameters Any additional arguments (e.g. width, height, size, rating)
      *
      * @return string