zikula / core

src/system/ThemeModule/EventListener/CreateThemedResponseListener.php

Doc Comments +3 added lines

@@ -108,6 +108,9 @@
         $response->setContent($content);
     }
 
+    /**
+     * @param string $search
+     */
     private function readdUntrimmedBlocks($search, $replace, &$subject)
     {
         $len = strlen($search);

src/system/RoutesModule/Form/Type/Base/AbstractRouteType.php

Spacing +1 added lines, -1 removed lines

@@ -413,7 +413,7 @@
             ->setDefaults([
                 // define class for underlying data (required for embedding forms)
                 'data_class' => 'Zikula\RoutesModule\Entity\RouteEntity',
-                'empty_data' => function (FormInterface $form) {
+                'empty_data' => function(FormInterface $form) {
                     return $this->entityFactory->createRoute();
                 },
                 'error_mapping' => [

Unused Use Statements +1 added lines, -1 removed lines

@@ -28,8 +28,8 @@
 use Zikula\RoutesModule\Entity\Factory\EntityFactory;
 use Zikula\RoutesModule\Form\Type\Field\ArrayType;
 use Zikula\RoutesModule\Form\Type\Field\MultiListType;
-use Zikula\UsersModule\Form\Type\UserLiveSearchType;
 use Zikula\RoutesModule\Helper\ListEntriesHelper;
+use Zikula\UsersModule\Form\Type\UserLiveSearchType;
 
 /**
  * Route editing form type base class.

src/system/CategoriesModule/Tests/Form/Type/CategoriesTypeTest.php

Doc Comments +9 added lines

@@ -385,6 +385,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function createRegistryMock($name, $em)
     {
         $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
@@ -396,6 +399,9 @@ 
         return $registry;
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategoryRegistry($now)
     {
         $registry = new CategoryRegistryEntity();
@@ -411,6 +417,9 @@ 
         $this->em->flush();
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategories($now)
     {
         // root

src/system/RoutesModule/Helper/Base/AbstractWorkflowHelper.php

Indentation +24 added lines, -24 removed lines

@@ -93,31 +93,31 @@
     }
 
     /**
-      * This method returns a list of possible object states.
-      *
-      * @return array List of collected state information
-      */
-     public function getObjectStates()
-     {
-         $states = [];
-         $states[] = [
-             'value' => 'initial',
-             'text' => $this->translator->__('Initial'),
-             'ui' => 'danger'
-         ];
-         $states[] = [
-             'value' => 'approved',
-             'text' => $this->translator->__('Approved'),
-             'ui' => 'success'
-         ];
-         $states[] = [
-             'value' => 'deleted',
-             'text' => $this->translator->__('Deleted'),
-             'ui' => 'danger'
-         ];
+     * This method returns a list of possible object states.
+     *
+     * @return array List of collected state information
+     */
+        public function getObjectStates()
+        {
+            $states = [];
+            $states[] = [
+                'value' => 'initial',
+                'text' => $this->translator->__('Initial'),
+                'ui' => 'danger'
+            ];
+            $states[] = [
+                'value' => 'approved',
+                'text' => $this->translator->__('Approved'),
+                'ui' => 'success'
+            ];
+            $states[] = [
+                'value' => 'deleted',
+                'text' => $this->translator->__('Deleted'),
+                'ui' => 'danger'
+            ];
     
-         return $states;
-     }
+            return $states;
+        }
     
     /**
      * This method returns information about a certain state.

Unused Use Statements +1 added lines, -1 removed lines

@@ -17,9 +17,9 @@
 use Zikula\Common\Translator\TranslatorInterface;
 use Zikula\Core\Doctrine\EntityAccess;
 use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;
-use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\RoutesModule\Entity\Factory\EntityFactory;
 use Zikula\RoutesModule\Helper\ListEntriesHelper;
+use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 
 /**
  * Helper base class for workflow methods.

src/system/CategoriesModule/DependencyInjection/ZikulaCategoriesExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
 
         $loader->load('services.yml');
         $loader->load('helpers.yml');

src/system/CategoriesModule/Form/Type/CategoryType.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
                 'mapped' => false,
                 'required' => false
             ])
-            ->addEventListener(FormEvents::SUBMIT, function (FormEvent $event) use ($options) {
+            ->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) use ($options) {
                 // ensure all locales have a display name
                 /** @var CategoryEntity $category */
                 $category = $event->getData();
@@ -109,10 +109,10 @@ 
         $builder->get('name')
             ->addModelTransformer(new CallbackTransformer(
                 // remove slash from name before persistence to prevent issues with path
-                function ($string) {
+                function($string) {
                     return $string;
                 },
-                function ($string) {
+                function($string) {
                     return str_replace('/', '/', $string);
                 }
             ))

src/system/CategoriesModule/Form/Type/CategoriesType.php

Spacing +3 added lines, -3 removed lines

@@ -57,10 +57,10 @@ 
 
         /** @var CategoryRegistryEntity[] $registries */
         foreach ($registries as $registry) {
-            $queryBuilderClosure = function (CategoryRepositoryInterface $repo) use ($registry, $options) {
+            $queryBuilderClosure = function(CategoryRepositoryInterface $repo) use ($registry, $options) {
                 return $repo->getChildrenQueryBuilder($registry->getCategory(), $options['direct']);
             };
-            $choiceLabelClosure = function (CategoryEntity $category) use ($registry) {
+            $choiceLabelClosure = function(CategoryEntity $category) use ($registry) {
                 $indent = str_repeat('--', $category->getLvl() - $registry->getCategory()->getLvl() - 1);
 
                 return (!empty($indent) ? '|' : '') . $indent . $category->getName();
@@ -119,7 +119,7 @@ 
         $resolver->setAllowedTypes('entityCategoryClass', 'string');
         $resolver->setAllowedTypes('em', [ObjectManager::class, 'null']);
 
-        $resolver->addAllowedValues('entityCategoryClass', function ($value) {
+        $resolver->addAllowedValues('entityCategoryClass', function($value) {
             return is_subclass_of($value, AbstractCategoryAssignment::class);
         });
     }

src/system/CategoriesModule/Controller/NodeController.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
                 $newCategory->setName($category->getName() . 'copy');
                 $displayNames = [];
                 foreach ($newCategory->getDisplay_name() as $locale => $displayName) {
-                    $displayNames[$locale] = $displayName . ' ' .$this->__('copy');
+                    $displayNames[$locale] = $displayName . ' ' . $this->__('copy');
                 }
                 $newCategory->setDisplay_name($displayNames);
                 $action = 'edit';

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
                         $parent = $repo->find($parentId);
                         $category->setParent($parent);
                         $category->setRoot($parent->getRoot());
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
+                    } elseif (empty($parent) && $request->request->has('after')) {
+// sibling of top-level child
                         $sibling = $repo->find($request->request->get('after'));
                         $category->setParent($sibling->getParent());
                         $category->setRoot($sibling->getRoot());

src/system/CategoriesModule/Controller/CategoryController.php

Spacing +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
         return [
             'decorate' => true,
             'html' => true,
-            'childOpen' => function ($node) {
+            'childOpen' => function($node) {
                 $jsTreeData = [];
                 $jsTreeData['disabled'] = $node['status'] != 'A';
                 $jsTreeData['type'] = $node['is_leaf'] ? 'leaf' : 'default';
@@ -87,7 +87,7 @@ 
 
                 return '<li ' . $jsTreeData . 'class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
             },
-            'nodeDecorator' => function ($node) use ($locale) {
+            'nodeDecorator' => function($node) use ($locale) {
                 $displayName = isset($node['display_name'][$locale]) ? $node['display_name'][$locale] : $node['name'];
                 $title = ' title="' . $this->createTitleAttribute($node, $displayName, $locale) . '"';
                 $classes = [];