zikula / core

src/system/CategoriesModule/Tests/Form/Type/CategoriesTypeTest.php

Doc Comments +9 added lines

@@ -385,6 +385,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     protected function createRegistryMock($name, $em)
     {
         $registry = $this->getMockBuilder(ManagerRegistry::class)->getMock();
@@ -396,6 +399,9 @@ 
         return $registry;
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategoryRegistry($now)
     {
         $registry = new CategoryRegistryEntity();
@@ -411,6 +417,9 @@ 
         $this->em->flush();
     }
 
+    /**
+     * @param \DateTime $now
+     */
     protected function generateCategories($now)
     {
         // root

src/system/RoutesModule/Helper/Base/AbstractViewHelper.php

Indentation +3 added lines, -3 removed lines

@@ -256,9 +256,9 @@
         $siteName = $this->variableApi->getSystemVar('sitename');
         $pageTitle = $this->controllerHelper->formatPermalink($this->themePageVars->get('title', ''));
         $fileTitle = $this->controllerHelper->formatPermalink($siteName)
-                   . '-'
-                   . ($pageTitle != '' ? $pageTitle . '-' : '')
-                   . date('Ymd') . '.pdf';
+                    . '-'
+                    . ($pageTitle != '' ? $pageTitle . '-' : '')
+                    . date('Ymd') . '.pdf';
     
         /*
         if (true === $this->request->query->getBoolean('dbg', false)) {

src/system/RoutesModule/Helper/Base/AbstractWorkflowHelper.php

Indentation +24 added lines, -24 removed lines

@@ -93,31 +93,31 @@
     }
 
     /**
-      * This method returns a list of possible object states.
-      *
-      * @return array List of collected state information
-      */
-     public function getObjectStates()
-     {
-         $states = [];
-         $states[] = [
-             'value' => 'initial',
-             'text' => $this->translator->__('Initial'),
-             'ui' => 'danger'
-         ];
-         $states[] = [
-             'value' => 'approved',
-             'text' => $this->translator->__('Approved'),
-             'ui' => 'success'
-         ];
-         $states[] = [
-             'value' => 'deleted',
-             'text' => $this->translator->__('Deleted'),
-             'ui' => 'danger'
-         ];
+     * This method returns a list of possible object states.
+     *
+     * @return array List of collected state information
+     */
+        public function getObjectStates()
+        {
+            $states = [];
+            $states[] = [
+                'value' => 'initial',
+                'text' => $this->translator->__('Initial'),
+                'ui' => 'danger'
+            ];
+            $states[] = [
+                'value' => 'approved',
+                'text' => $this->translator->__('Approved'),
+                'ui' => 'success'
+            ];
+            $states[] = [
+                'value' => 'deleted',
+                'text' => $this->translator->__('Deleted'),
+                'ui' => 'danger'
+            ];
     
-         return $states;
-     }
+            return $states;
+        }
     
     /**
      * This method returns information about a certain state.

src/system/CategoriesModule/DependencyInjection/ZikulaCategoriesExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
 
         $loader->load('services.yml');
         $loader->load('helpers.yml');

src/system/CategoriesModule/Form/Type/CategoryTreeType.php

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
         $resolver->setAllowedTypes('includeLeaf', 'bool');
         $resolver->setAllowedTypes('all', 'bool');
 
-        $resolver->setNormalizer('label', function (Options $options, $label) {
+        $resolver->setNormalizer('label', function(Options $options, $label) {
             if (null === $label || empty($label)) {
                 $isMultiple = $options['multiple'];
                 $translator = $options['translator'];
@@ -98,7 +98,7 @@ 
 
             return $label;
         });
-        $resolver->setNormalizer('placeholder', function (Options $options, $placeholder) {
+        $resolver->setNormalizer('placeholder', function(Options $options, $placeholder) {
             if (!$options['required']) {
                 if (null == $placeholder || empty($placeholder)) {
                     $isMultiple = $options['multiple'];
@@ -110,7 +110,7 @@ 
 
             return $placeholder;
         });
-        $resolver->setNormalizer('choices', function (Options $options, $choices) {
+        $resolver->setNormalizer('choices', function(Options $options, $choices) {
             if (empty($choices)) {
                 $choices = $this->getCategoryChoices($options);
             }

src/system/CategoriesModule/Form/Type/CategoryType.php

Spacing +3 added lines, -3 removed lines

@@ -91,7 +91,7 @@ 
                 'mapped' => false,
                 'required' => false
             ])
-            ->addEventListener(FormEvents::SUBMIT, function (FormEvent $event) use ($options) {
+            ->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) use ($options) {
                 // ensure all locales have a display name
                 /** @var CategoryEntity $category */
                 $category = $event->getData();
@@ -109,10 +109,10 @@ 
         $builder->get('name')
             ->addModelTransformer(new CallbackTransformer(
                 // remove slash from name before persistence to prevent issues with path
-                function ($string) {
+                function($string) {
                     return $string;
                 },
-                function ($string) {
+                function($string) {
                     return str_replace('/', '/', $string);
                 }
             ))

src/system/CategoriesModule/Form/Type/CategoriesType.php

Spacing +3 added lines, -3 removed lines

@@ -57,10 +57,10 @@ 
 
         /** @var CategoryRegistryEntity[] $registries */
         foreach ($registries as $registry) {
-            $queryBuilderClosure = function (CategoryRepositoryInterface $repo) use ($registry, $options) {
+            $queryBuilderClosure = function(CategoryRepositoryInterface $repo) use ($registry, $options) {
                 return $repo->getChildrenQueryBuilder($registry->getCategory(), $options['direct']);
             };
-            $choiceLabelClosure = function (CategoryEntity $category) use ($registry) {
+            $choiceLabelClosure = function(CategoryEntity $category) use ($registry) {
                 $indent = str_repeat('--', $category->getLvl() - $registry->getCategory()->getLvl() - 1);
 
                 return (!empty($indent) ? '|' : '') . $indent . $category->getName();
@@ -119,7 +119,7 @@ 
         $resolver->setAllowedTypes('entityCategoryClass', 'string');
         $resolver->setAllowedTypes('em', [ObjectManager::class, 'null']);
 
-        $resolver->addAllowedValues('entityCategoryClass', function ($value) {
+        $resolver->addAllowedValues('entityCategoryClass', function($value) {
             return is_subclass_of($value, AbstractCategoryAssignment::class);
         });
     }

src/system/CategoriesModule/Form/Type/CategoryRegistryType.php

Spacing +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
             ])
         ;
 
-        $formModifier = function (FormInterface $form, $modName = null) use ($options) {
+        $formModifier = function(FormInterface $form, $modName = null) use ($options) {
             $entities = null === $modName ? [] : $this->entitySelectionBuilder->buildFor($modName);
             $form->add('entityname', 'Symfony\Component\Form\Extension\Core\Type\ChoiceType', [
                 'label' => $options['translator']->__('Entity'),
@@ -85,7 +85,7 @@ 
 
         $builder->addEventListener(
             FormEvents::PRE_SET_DATA,
-            function (FormEvent $event) use ($formModifier) {
+            function(FormEvent $event) use ($formModifier) {
                 /** @var CategoryRegistryEntity $data */
                 $data = $event->getData();
                 $formModifier($event->getForm(), $data->getModname());
@@ -94,7 +94,7 @@ 
 
         $builder->get('modname')->addEventListener(
             FormEvents::POST_SUBMIT,
-            function (FormEvent $event) use ($formModifier) {
+            function(FormEvent $event) use ($formModifier) {
                 $modName = $event->getForm()->getData();
                 $formModifier($event->getForm()->getParent(), $modName);
             }

src/system/CategoriesModule/Controller/NodeController.php

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
                 $newCategory->setName($category->getName() . 'copy');
                 $displayNames = [];
                 foreach ($newCategory->getDisplay_name() as $locale => $displayName) {
-                    $displayNames[$locale] = $displayName . ' ' .$this->__('copy');
+                    $displayNames[$locale] = $displayName . ' ' . $this->__('copy');
                 }
                 $newCategory->setDisplay_name($displayNames);
                 $action = 'edit';

Braces +2 added lines, -1 removed lines

@@ -70,7 +70,8 @@
                         $parent = $repo->find($parentId);
                         $category->setParent($parent);
                         $category->setRoot($parent->getRoot());
-                    } elseif (empty($parent) && $request->request->has('after')) { // sibling of top-level child
+                    } elseif (empty($parent) && $request->request->has('after')) {
+// sibling of top-level child
                         $sibling = $repo->find($request->request->get('after'));
                         $category->setParent($sibling->getParent());
                         $category->setRoot($sibling->getRoot());