ExtensionsInterfaceController::linksAction() - Code Metrics - Inspection of "removed forgotten Action suffixes" - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( caeb59...e7b0db )

by Axel

created 2020-09-19 12:49 UTC

ExtensionsInterfaceController::linksAction() B

↳ Parent: ExtensionsInterfaceController

Complexity

Conditions	9
Paths	144

Size

Total Lines	51
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	9
eloc	29
c	2
b	0
f	0
nc	144
nop	3
dl	0
loc	51
rs	7.6888

How to fix Long Method

<?php

declare(strict_types=1);

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula - https://ziku.la/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\ExtensionsModule\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Zikula\Bundle\CoreBundle\Controller\AbstractController;
use Zikula\ExtensionsModule\Entity\RepositoryInterface\ExtensionRepositoryInterface;
use Zikula\MenuModule\ExtensionMenu\ExtensionMenuCollector;
use Zikula\ThemeModule\Engine\Asset;

/**
 * @Route("/extensionsinterface")
 */
class ExtensionsInterfaceController extends AbstractController
{
    /**
     * @Route("/header")
     *
     * Module header
     */
    public function header(
        RequestStack $requestStack,
        ExtensionRepositoryInterface $extensionRepository,
        Asset $assetHelper
    ): Response {
        $currentRequest = $requestStack->getCurrentRequest();
        $caller = $requestStack->getMasterRequest()->attributes->all();
        $caller['info'] = !empty($caller['_zkModule']) ? $extensionRepository->get($caller['_zkModule']) : [];

        return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/header.html.twig', [
            'caller' => $caller,
            'title' => '' !== $currentRequest->attributes->get('title')
                ? $currentRequest->attributes->get('title')
                : ($caller['info']['displayname'] ?? ''),
            'titlelink' => '' !== $currentRequest->attributes->get('titlelink') ? $currentRequest->attributes->get('titlelink') : false,
            'setpagetitle' => true === $currentRequest->attributes->get('setpagetitle') ? $currentRequest->attributes->get('setpagetitle') : false,
            'insertflashes' => true === $currentRequest->attributes->get('insertflashes') ? $currentRequest->attributes->get('insertflashes') : false,
            'menufirst' => true === $currentRequest->attributes->get('menufirst') ? $currentRequest->attributes->get('menufirst') : false,
            'type' => 'admin' === $currentRequest->attributes->get('type') ? $currentRequest->attributes->get('type') : 'user',
        ]);
    }

    /**
     * @Route("/footer")
     *
     * Module footer
     */
    public function footer(RequestStack $requestStack): Response
    {
        return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/footer.html.twig', [
            'caller' => $requestStack->getMasterRequest()->attributes->all()
        ]);
    }

    /**
     * @Route("/breadcrumbs", methods = {"GET"})
     *
     * Admin breadcrumbs
     */
    public function breadcrumbs(
        RequestStack $requestStack,
        ExtensionRepositoryInterface $extensionRepository
    ): Response {
        $caller = $requestStack->getMasterRequest()->attributes->all();
        $caller['info'] = $extensionRepository->get($caller['_zkModule']);

        return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/breadcrumbs.html.twig', [
            'caller' => $caller
        ]);
    }

    /**
     * @Route("/links")
     *
     * Open the admin container
     */
    public function links(
        RequestStack $requestStack,
        ExtensionRepositoryInterface $extensionRepository,
        ExtensionMenuCollector $extensionMenuCollector
    ): Response {
        /** @var Request $masterRequest */
        $masterRequest = $requestStack->getMasterRequest();
        /** @var Request $currentRequest */
        $currentRequest = $requestStack->getCurrentRequest();
        $caller = $masterRequest->attributes->all();
        $caller['info'] = !empty($caller['_zkModule']) ? $extensionRepository->get($caller['_zkModule']) : [];
        // your own links array
        $links = '' !== $currentRequest->attributes->get('links') ? $currentRequest->attributes->get('links') : '';
        // you can pass module name you want to get links for
        $moduleName = '' !== $currentRequest->attributes->get('modname')
            ? $currentRequest->attributes->get('modname')
            : ($caller['_zkModule'] ?? '');

        // no own links array
        if (empty($links)) {
            // define type - default
            $linksType = 'user';
            // detect from masterRequest
            $linksType = '' !== $masterRequest->attributes->get('type') ? $masterRequest->attributes->get('type') : $linksType;
            // passed to currentRequest most important
            $linksType = '' !== $currentRequest->attributes->get('type') ? $currentRequest->attributes->get('type') : $linksType;
            // get the menu links
            $extensionMenu = $extensionMenuCollector->get($moduleName, $linksType);
            if (isset($extensionMenu)) {
                $extensionMenu->setChildrenAttribute('class', 'nav nav-modulelinks');
            }
        }

        // menu css
        $menu_css = [
            'menuId' => $currentRequest->attributes->get('menuid', ''),
            'menuClass' => $currentRequest->attributes->get('menuclass', ''),
            'menuItemClass' => $currentRequest->attributes->get('itemclass', ''),
            'menuFirstItemClass' => $currentRequest->attributes->get('first', ''),
            'menuLastItemClass' => $currentRequest->attributes->get('last', '')
        ];

        $template = '' !== $currentRequest->attributes->get('template')
            ? $currentRequest->attributes->get('template')
            : '@ZikulaExtensionsModule/ExtensionsInterface/links.html.twig';

        return $this->render($template, [
            'caller' => $caller,
            'menu_css' => $menu_css,
            'extensionMenu' => $extensionMenu,

            'current_path' => $masterRequest->getPathInfo()
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Zikula package.
7			*
8			* Copyright Zikula - https://ziku.la/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Zikula\ExtensionsModule\Controller;
15
16			use Symfony\Component\HttpFoundation\Request;
17			use Symfony\Component\HttpFoundation\RequestStack;
18			use Symfony\Component\HttpFoundation\Response;
19			use Symfony\Component\Routing\Annotation\Route;
20			use Zikula\Bundle\CoreBundle\Controller\AbstractController;
21			use Zikula\ExtensionsModule\Entity\RepositoryInterface\ExtensionRepositoryInterface;
22			use Zikula\MenuModule\ExtensionMenu\ExtensionMenuCollector;
23			use Zikula\ThemeModule\Engine\Asset;
24
25			/**
26			* @Route("/extensionsinterface")
27			*/
28			class ExtensionsInterfaceController extends AbstractController
29			{
30			/**
31			* @Route("/header")
32			*
33			* Module header
34			*/
35			public function header(
36			RequestStack $requestStack,
37			ExtensionRepositoryInterface $extensionRepository,
38			Asset $assetHelper
39			): Response {
40			$currentRequest = $requestStack->getCurrentRequest();
41			$caller = $requestStack->getMasterRequest()->attributes->all();
42			$caller['info'] = !empty($caller['_zkModule']) ? $extensionRepository->get($caller['_zkModule']) : [];
43
44			return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/header.html.twig', [
45			'caller' => $caller,
46			'title' => '' !== $currentRequest->attributes->get('title')
47			? $currentRequest->attributes->get('title')
48			: ($caller['info']['displayname'] ?? ''),
49			'titlelink' => '' !== $currentRequest->attributes->get('titlelink') ? $currentRequest->attributes->get('titlelink') : false,
50			'setpagetitle' => true === $currentRequest->attributes->get('setpagetitle') ? $currentRequest->attributes->get('setpagetitle') : false,
51			'insertflashes' => true === $currentRequest->attributes->get('insertflashes') ? $currentRequest->attributes->get('insertflashes') : false,
52			'menufirst' => true === $currentRequest->attributes->get('menufirst') ? $currentRequest->attributes->get('menufirst') : false,
53			'type' => 'admin' === $currentRequest->attributes->get('type') ? $currentRequest->attributes->get('type') : 'user',
54			]);
55			}
56
57			/**
58			* @Route("/footer")
59			*
60			* Module footer
61			*/
62			public function footer(RequestStack $requestStack): Response
63			{
64			return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/footer.html.twig', [
65			'caller' => $requestStack->getMasterRequest()->attributes->all()
66			]);
67			}
68
69			/**
70			* @Route("/breadcrumbs", methods = {"GET"})
71			*
72			* Admin breadcrumbs
73			*/
74			public function breadcrumbs(
75			RequestStack $requestStack,
76			ExtensionRepositoryInterface $extensionRepository
77			): Response {
78			$caller = $requestStack->getMasterRequest()->attributes->all();
79			$caller['info'] = $extensionRepository->get($caller['_zkModule']);
80
81			return $this->render('@ZikulaExtensionsModule/ExtensionsInterface/breadcrumbs.html.twig', [
82			'caller' => $caller
83			]);
84			}
85
86			/**
87			* @Route("/links")
88			*
89			* Open the admin container
90			*/
91			public function links(
92			RequestStack $requestStack,
93			ExtensionRepositoryInterface $extensionRepository,
94			ExtensionMenuCollector $extensionMenuCollector
95			): Response {
96			/** @var Request $masterRequest */
97			$masterRequest = $requestStack->getMasterRequest();
98			/** @var Request $currentRequest */
99			$currentRequest = $requestStack->getCurrentRequest();
100			$caller = $masterRequest->attributes->all();
101			$caller['info'] = !empty($caller['_zkModule']) ? $extensionRepository->get($caller['_zkModule']) : [];
102			// your own links array
103			$links = '' !== $currentRequest->attributes->get('links') ? $currentRequest->attributes->get('links') : '';
104			// you can pass module name you want to get links for
105			$moduleName = '' !== $currentRequest->attributes->get('modname')
106			? $currentRequest->attributes->get('modname')
107			: ($caller['_zkModule'] ?? '');
108
109			// no own links array
110			if (empty($links)) {
111			// define type - default
112			$linksType = 'user';
113			// detect from masterRequest
114			$linksType = '' !== $masterRequest->attributes->get('type') ? $masterRequest->attributes->get('type') : $linksType;
115			// passed to currentRequest most important
116			$linksType = '' !== $currentRequest->attributes->get('type') ? $currentRequest->attributes->get('type') : $linksType;
117			// get the menu links
118			$extensionMenu = $extensionMenuCollector->get($moduleName, $linksType);
119			if (isset($extensionMenu)) {
120			$extensionMenu->setChildrenAttribute('class', 'nav nav-modulelinks');
121			}
122			}
123
124			// menu css
125			$menu_css = [
126			'menuId' => $currentRequest->attributes->get('menuid', ''),
127			'menuClass' => $currentRequest->attributes->get('menuclass', ''),
128			'menuItemClass' => $currentRequest->attributes->get('itemclass', ''),
129			'menuFirstItemClass' => $currentRequest->attributes->get('first', ''),
130			'menuLastItemClass' => $currentRequest->attributes->get('last', '')
131			];
132
133			$template = '' !== $currentRequest->attributes->get('template')
134			? $currentRequest->attributes->get('template')
135			: '@ZikulaExtensionsModule/ExtensionsInterface/links.html.twig';
136
137			return $this->render($template, [
138			'caller' => $caller,
139			'menu_css' => $menu_css,
140			'extensionMenu' => $extensionMenu,
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-01-15 00:57 UTC by Report Bug Copy Issue Report The variable `$extensionMenu` does not seem to be defined for all execution paths leading up to this point. Loading history...
141			'current_path' => $masterRequest->getPathInfo()
142			]);
143			}
144			}
145

zikula / core

Push — master ( caeb59...e7b0db )

ExtensionsInterfaceController::linksAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like