HookController::toggleSubscribeAreaStatusAction() - Code Metrics - Inspection of "reducing complexity of some controllers; cs; clean..." - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 86e506...1e27b6 )

by Axel

created 2020-02-11 08:48 UTC

HookController::toggleSubscribeAreaStatusAction() C

↳ Parent: HookController

Complexity

Conditions	12
Paths	13

Size

Total Lines	69
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	37
nc	13
nop	6
dl	0
loc	69
rs	6.9666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - https://ziku.la/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\Bundle\HookBundle\Controller;

use InvalidArgumentException;
use RuntimeException;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Symfony\Contracts\Translation\TranslatorInterface;
use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaHttpKernelInterface;
use Zikula\Bundle\CoreBundle\Translation\TranslatorTrait;
use Zikula\Bundle\HookBundle\Collector\HookCollectorInterface;
use Zikula\Bundle\HookBundle\Dispatcher\HookDispatcherInterface;
use Zikula\Bundle\HookBundle\Helper\HookUiHelper;
use Zikula\ExtensionsModule\Entity\ExtensionEntity;
use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;
use Zikula\ThemeModule\Engine\Annotation\Theme;

/**
 * Class HookController
 * @Route("/hooks")
 */
class HookController extends AbstractController
{
    use TranslatorTrait;

    /**
     * @Route("/{moduleName}", methods = {"GET"}, options={"zkNoBundlePrefix" = 1})
     * @Theme("admin")
     * @Template("@ZikulaHook/Hook/edit.html.twig")
     *
     * Display hooks user interface
     *
     * @throws AccessDeniedException Thrown if the user doesn't have admin permissions over the module
     */
    public function editAction(
        RequestStack $requestStack,
        PermissionApiInterface $permissionApi,
        HookCollectorInterface $collector,
        HookDispatcherInterface $dispatcher,
        HookUiHelper $hookUiHelper,
        string $moduleName
    ): array {
        $templateParameters = [];
        // get module's name and assign it to template
        $templateParameters['currentmodule'] = $moduleName;

        // check if user has admin permission on this module
        if (!$permissionApi->hasPermission($moduleName . '::', '::', ACCESS_ADMIN)) {
            throw new AccessDeniedException();
        }

        // find out the capabilities of the module
        $isProvider = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_PROVIDER);
        $templateParameters['isProvider'] = $isProvider;

        $isSubscriber = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_SUBSCRIBER);
        $templateParameters['isSubscriber'] = $isSubscriber;

        $isSubscriberSelfCapable = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_SUBSCRIBE_OWN);
        $templateParameters['isSubscriberSelfCapable'] = $isSubscriberSelfCapable;
        $templateParameters['providerAreas'] = [];

        $providers = $collector->getProviders();
        $subscribers = $collector->getSubscribers();

        // get areas of module and bundle titles also
        if ($isProvider) {
            $providerAreas = $collector->getProviderAreasByOwner($moduleName);
            $templateParameters['providerAreas'] = $providerAreas;

            $providerAreasToTitles = [];
            foreach ($providerAreas as $providerArea) {
                if (isset($providers[$providerArea])) {
                    $providerAreasToTitles[$providerArea] = $providers[$providerArea]->getTitle();
                }
            }
            $templateParameters['providerAreasToTitles'] = $providerAreasToTitles;
        }
        $templateParameters['subscriberAreas'] = [];
        $templateParameters['hookSubscribers'] = [];

        if ($isSubscriber) {
            $subscriberAreas = $collector->getSubscriberAreasByOwner($moduleName);
            $templateParameters['subscriberAreas'] = $subscriberAreas;

            $areasInfo = $hookUiHelper->prepareSubscriberAreasForSubscriber($subscriberAreas, $subscribers);
            $templateParameters['subscriberAreasToTitles'] = $areasInfo['titles'];
            $templateParameters['subscriberAreasToCategories'] = $areasInfo['categories'];
            $templateParameters['subscriberAreasAndCategories'] = $areasInfo['categoryGroups'];
        }

        // get available subscribers that can attach to provider
        if ($isProvider && !empty($providerAreas)) {
            [$hookSubscribers, $amountOfAvailableSubscriberAreas] = $hookUiHelper->prepareAvailableSubscriberAreasForProvider($moduleName, $subscribers);
            $templateParameters['hookSubscribers'] = $hookSubscribers;
            $templateParameters['amountOfAvailableSubscriberAreas'] = $amountOfAvailableSubscriberAreas;
        } else {
            $templateParameters['amountOfAvailableSubscriberAreas'] = 0;
        }

        // get providers that are already attached to the subscriber
        // and providers that can attach to the subscriber
        if ($isSubscriber && !empty($subscriberAreas)) {
            // get current sorting
            [$currentSorting, $currentSortingTitles, $amountOfAttachedProviderAreas] = $hookUiHelper->prepareAttachedProvidersForSubscriber($subscriberAreas, $providers);
            $templateParameters['areasSorting'] = $currentSorting;
            $templateParameters['areasSortingTitles'] = $currentSortingTitles;
            $templateParameters['amountOfAttachedProviderAreas'] = $amountOfAttachedProviderAreas;

            [$hookProviders, $amountOfAvailableProviderAreas] = $hookUiHelper->prepareAvailableProviderAreasForSubscriber($moduleName, $providers, $isSubscriberSelfCapable);
            $templateParameters['hookProviders'] = $hookProviders;
            $templateParameters['amountOfAvailableProviderAreas'] = $amountOfAvailableProviderAreas;
        } else {
            $templateParameters['hookProviders'] = [];
        }
        $templateParameters['hookDispatcher'] = $dispatcher;
        $request = $requestStack->getCurrentRequest();
        $request->attributes->set('_zkModule', $moduleName);
        $request->attributes->set('_zkType', 'admin');
        $request->attributes->set('_zkFunc', 'Hooks');

        return $templateParameters;
    }

    /**
     * @Route("/togglestatus", methods = {"POST"}, options={"expose"=true})
     *
     * Attach/detach a subscriber area to a provider area
     *
     * @throws InvalidArgumentException Thrown if either the subscriber, provider or subscriberArea parameters are empty
     * @throws RuntimeException Thrown if either the subscriber or provider module isn't available
     * @throws AccessDeniedException Thrown if the user doesn't have admin access to either the subscriber or provider modules
     */
    public function toggleSubscribeAreaStatusAction(
        Request $request,
        ZikulaHttpKernelInterface $kernel,
        TranslatorInterface $translator,
        PermissionApiInterface $permissionApi,
        HookCollectorInterface $collector,
        HookDispatcherInterface $dispatcher
    ): JsonResponse {
        $this->setTranslator($translator);
        if (!$this->isCsrfTokenValid('hook-ui', $request->request->get('token'))) {
            throw new AccessDeniedException();
        }

        // get subscriberarea from POST
        $subscriberArea = $request->request->get('subscriberarea', '');
        if (empty($subscriberArea)) {
            throw new InvalidArgumentException($this->trans('No subscriber area passed.'));
        }

        // get subscriber module based on area and do some checks
        $subscriber = $collector->getSubscriber($subscriberArea);
        if (null === $subscriber) {
            throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid subscriber.', ['%name%' => $subscriber->getOwner()]));
        }
        if (!$kernel->isBundle($subscriber->getOwner())) {
            throw new RuntimeException($this->trans('Subscriber module "%name%" is not available.', ['%name%' => $subscriber->getOwner()]));
        }
        if (!$permissionApi->hasPermission($subscriber->getOwner() . '::', '::', ACCESS_ADMIN)) {
            throw new AccessDeniedException();
        }

        // get providerarea from POST
        $providerArea = $request->request->get('providerarea', '');
        if (empty($providerArea)) {
            throw new InvalidArgumentException($this->trans('No provider area passed.'));
        }

        // get provider module based on area and do some checks
        $provider = $collector->getProvider($providerArea);
        if (null === $provider) {
            throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid provider.', ['%name%' => $provider->getOwner()]));
        }
        if (!$kernel->isBundle($provider->getOwner())) {
            throw new RuntimeException($this->trans('Provider module "%name%" is not available.', ['%name%' => $provider->getOwner()]));
        }
        if (!$permissionApi->hasPermission($provider->getOwner() . '::', '::', ACCESS_ADMIN)) {
            throw new AccessDeniedException();
        }

        // check if binding between areas exists
        $binding = $dispatcher->getBindingBetweenAreas($subscriberArea, $providerArea);
        if (!$binding) {

            $dispatcher->bindSubscriber($subscriberArea, $providerArea);
        } else {
            $dispatcher->unbindSubscriber($subscriberArea, $providerArea);
        }

        // ajax response
        $response = [
            'result' => true,
            'action' => $binding ? 'unbind' : 'bind',
            'subscriberarea' => $subscriberArea,
            'subscriberarea_id' => md5($subscriberArea),
            'providerarea' => $providerArea,
            'providerarea_id' => md5($providerArea),
            'isSubscriberSelfCapable' => $collector->isCapable($subscriber->getOwner(), HookCollectorInterface::HOOK_SUBSCRIBE_OWN)
        ];

        return $this->json($response);
    }

    /**
     * @Route("/changeorder", methods = {"POST"}, options={"expose"=true})
     *
     * Changes the order of the providers' areas that are attached to a subscriber.
     *
     * @throws InvalidArgumentException Thrown if the subscriber or subscriberarea parameters aren't valid
     * @throws RuntimeException Thrown if the subscriber module isn't available
     * @throws AccessDeniedException Thrown if the user doesn't have admin access to the subscriber module
     */
    public function changeProviderAreaOrderAction(
        Request $request,
        ZikulaHttpKernelInterface $kernel,
        TranslatorInterface $translator,
        PermissionApiInterface $permissionApi,
        HookCollectorInterface $collector,
        HookDispatcherInterface $hookDispatcher
    ): JsonResponse {
        $this->setTranslator($translator);
        if (!$this->isCsrfTokenValid('hook-ui', $request->request->get('token'))) {
            throw new AccessDeniedException();
        }

        // get subscriberarea from POST
        $subscriberarea = $request->request->get('subscriberarea', '');
        if (empty($subscriberarea)) {
            throw new InvalidArgumentException($this->trans('No subscriber area passed.'));
        }

        // get subscriber module based on area and do some checks
        $subscriber = $collector->getSubscriber($subscriberarea);
        if (null === $subscriber) {
            throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid subscriber.', ['%name%' => $subscriber->getOwner()]));
        }
        if (!$kernel->isBundle($subscriber->getOwner())) {
            throw new RuntimeException($this->trans('Subscriber module "%name%" is not available.', ['%name%' => $subscriber->getOwner()]));
        }
        if (!$permissionApi->hasPermission($subscriber->getOwner() . '::', '::', ACCESS_ADMIN)) {
            throw new AccessDeniedException();
        }

        // get providers' areas from POST
        $providerarea = $request->request->get('providerarea', '');
        if (!is_array($providerarea) || count($providerarea) < 1) {
            throw new InvalidArgumentException($this->trans('Providers\' areas order is not an array.'));
        }

        // set sorting
        $hookDispatcher->setBindOrder($subscriberarea, $providerarea);

        return $this->json(['result' => true]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of the Zikula package.
7			*
8			* Copyright Zikula Foundation - https://ziku.la/
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Zikula\Bundle\HookBundle\Controller;
15
16			use InvalidArgumentException;
17			use RuntimeException;
18			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
19			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
20			use Symfony\Component\HttpFoundation\JsonResponse;
21			use Symfony\Component\HttpFoundation\Request;
22			use Symfony\Component\HttpFoundation\RequestStack;
23			use Symfony\Component\Routing\Annotation\Route;
24			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
25			use Symfony\Contracts\Translation\TranslatorInterface;
26			use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaHttpKernelInterface;
27			use Zikula\Bundle\CoreBundle\Translation\TranslatorTrait;
28			use Zikula\Bundle\HookBundle\Collector\HookCollectorInterface;
29			use Zikula\Bundle\HookBundle\Dispatcher\HookDispatcherInterface;
30			use Zikula\Bundle\HookBundle\Helper\HookUiHelper;
31			use Zikula\ExtensionsModule\Entity\ExtensionEntity;
32			use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;
33			use Zikula\ThemeModule\Engine\Annotation\Theme;
34
35			/**
36			* Class HookController
37			* @Route("/hooks")
38			*/
39			class HookController extends AbstractController
40			{
41			use TranslatorTrait;
42
43			/**
44			* @Route("/{moduleName}", methods = {"GET"}, options={"zkNoBundlePrefix" = 1})
45			* @Theme("admin")
46			* @Template("@ZikulaHook/Hook/edit.html.twig")
47			*
48			* Display hooks user interface
49			*
50			* @throws AccessDeniedException Thrown if the user doesn't have admin permissions over the module
51			*/
52			public function editAction(
53			RequestStack $requestStack,
54			PermissionApiInterface $permissionApi,
55			HookCollectorInterface $collector,
56			HookDispatcherInterface $dispatcher,
57			HookUiHelper $hookUiHelper,
58			string $moduleName
59			): array {
60			$templateParameters = [];
61			// get module's name and assign it to template
62			$templateParameters['currentmodule'] = $moduleName;
63
64			// check if user has admin permission on this module
65			if (!$permissionApi->hasPermission($moduleName . '::', '::', ACCESS_ADMIN)) {
66			throw new AccessDeniedException();
67			}
68
69			// find out the capabilities of the module
70			$isProvider = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_PROVIDER);
71			$templateParameters['isProvider'] = $isProvider;
72
73			$isSubscriber = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_SUBSCRIBER);
74			$templateParameters['isSubscriber'] = $isSubscriber;
75
76			$isSubscriberSelfCapable = $collector->isCapable($moduleName, HookCollectorInterface::HOOK_SUBSCRIBE_OWN);
77			$templateParameters['isSubscriberSelfCapable'] = $isSubscriberSelfCapable;
78			$templateParameters['providerAreas'] = [];
79
80			$providers = $collector->getProviders();
81			$subscribers = $collector->getSubscribers();
82
83			// get areas of module and bundle titles also
84			if ($isProvider) {
85			$providerAreas = $collector->getProviderAreasByOwner($moduleName);
86			$templateParameters['providerAreas'] = $providerAreas;
87
88			$providerAreasToTitles = [];
89			foreach ($providerAreas as $providerArea) {
90			if (isset($providers[$providerArea])) {
91			$providerAreasToTitles[$providerArea] = $providers[$providerArea]->getTitle();
92			}
93			}
94			$templateParameters['providerAreasToTitles'] = $providerAreasToTitles;
95			}
96			$templateParameters['subscriberAreas'] = [];
97			$templateParameters['hookSubscribers'] = [];
98
99			if ($isSubscriber) {
100			$subscriberAreas = $collector->getSubscriberAreasByOwner($moduleName);
101			$templateParameters['subscriberAreas'] = $subscriberAreas;
102
103			$areasInfo = $hookUiHelper->prepareSubscriberAreasForSubscriber($subscriberAreas, $subscribers);
104			$templateParameters['subscriberAreasToTitles'] = $areasInfo['titles'];
105			$templateParameters['subscriberAreasToCategories'] = $areasInfo['categories'];
106			$templateParameters['subscriberAreasAndCategories'] = $areasInfo['categoryGroups'];
107			}
108
109			// get available subscribers that can attach to provider
110			if ($isProvider && !empty($providerAreas)) {
111			[$hookSubscribers, $amountOfAvailableSubscriberAreas] = $hookUiHelper->prepareAvailableSubscriberAreasForProvider($moduleName, $subscribers);
112			$templateParameters['hookSubscribers'] = $hookSubscribers;
113			$templateParameters['amountOfAvailableSubscriberAreas'] = $amountOfAvailableSubscriberAreas;
114			} else {
115			$templateParameters['amountOfAvailableSubscriberAreas'] = 0;
116			}
117
118			// get providers that are already attached to the subscriber
119			// and providers that can attach to the subscriber
120			if ($isSubscriber && !empty($subscriberAreas)) {
121			// get current sorting
122			[$currentSorting, $currentSortingTitles, $amountOfAttachedProviderAreas] = $hookUiHelper->prepareAttachedProvidersForSubscriber($subscriberAreas, $providers);
123			$templateParameters['areasSorting'] = $currentSorting;
124			$templateParameters['areasSortingTitles'] = $currentSortingTitles;
125			$templateParameters['amountOfAttachedProviderAreas'] = $amountOfAttachedProviderAreas;
126
127			[$hookProviders, $amountOfAvailableProviderAreas] = $hookUiHelper->prepareAvailableProviderAreasForSubscriber($moduleName, $providers, $isSubscriberSelfCapable);
128			$templateParameters['hookProviders'] = $hookProviders;
129			$templateParameters['amountOfAvailableProviderAreas'] = $amountOfAvailableProviderAreas;
130			} else {
131			$templateParameters['hookProviders'] = [];
132			}
133			$templateParameters['hookDispatcher'] = $dispatcher;
134			$request = $requestStack->getCurrentRequest();
135			$request->attributes->set('_zkModule', $moduleName);
136			$request->attributes->set('_zkType', 'admin');
137			$request->attributes->set('_zkFunc', 'Hooks');
138
139			return $templateParameters;
140			}
141
142			/**
143			* @Route("/togglestatus", methods = {"POST"}, options={"expose"=true})
144			*
145			* Attach/detach a subscriber area to a provider area
146			*
147			* @throws InvalidArgumentException Thrown if either the subscriber, provider or subscriberArea parameters are empty
148			* @throws RuntimeException Thrown if either the subscriber or provider module isn't available
149			* @throws AccessDeniedException Thrown if the user doesn't have admin access to either the subscriber or provider modules
150			*/
151			public function toggleSubscribeAreaStatusAction(
152			Request $request,
153			ZikulaHttpKernelInterface $kernel,
154			TranslatorInterface $translator,
155			PermissionApiInterface $permissionApi,
156			HookCollectorInterface $collector,
157			HookDispatcherInterface $dispatcher
158			): JsonResponse {
159			$this->setTranslator($translator);
160			if (!$this->isCsrfTokenValid('hook-ui', $request->request->get('token'))) {
161			throw new AccessDeniedException();
162			}
163
164			// get subscriberarea from POST
165			$subscriberArea = $request->request->get('subscriberarea', '');
166			if (empty($subscriberArea)) {
167			throw new InvalidArgumentException($this->trans('No subscriber area passed.'));
168			}
169
170			// get subscriber module based on area and do some checks
171			$subscriber = $collector->getSubscriber($subscriberArea);
172			if (null === $subscriber) {
173			throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid subscriber.', ['%name%' => $subscriber->getOwner()]));
174			}
175			if (!$kernel->isBundle($subscriber->getOwner())) {
176			throw new RuntimeException($this->trans('Subscriber module "%name%" is not available.', ['%name%' => $subscriber->getOwner()]));
177			}
178			if (!$permissionApi->hasPermission($subscriber->getOwner() . '::', '::', ACCESS_ADMIN)) {
179			throw new AccessDeniedException();
180			}
181
182			// get providerarea from POST
183			$providerArea = $request->request->get('providerarea', '');
184			if (empty($providerArea)) {
185			throw new InvalidArgumentException($this->trans('No provider area passed.'));
186			}
187
188			// get provider module based on area and do some checks
189			$provider = $collector->getProvider($providerArea);
190			if (null === $provider) {
191			throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid provider.', ['%name%' => $provider->getOwner()]));
192			}
193			if (!$kernel->isBundle($provider->getOwner())) {
194			throw new RuntimeException($this->trans('Provider module "%name%" is not available.', ['%name%' => $provider->getOwner()]));
195			}
196			if (!$permissionApi->hasPermission($provider->getOwner() . '::', '::', ACCESS_ADMIN)) {
197			throw new AccessDeniedException();
198			}
199
200			// check if binding between areas exists
201			$binding = $dispatcher->getBindingBetweenAreas($subscriberArea, $providerArea);
202			if (!$binding) {
			0 ignored issues – show Bug Best Practice introduced 2019-03-17 07:27 UTC by Report Bug Copy Issue Report The expression `$binding` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
203			$dispatcher->bindSubscriber($subscriberArea, $providerArea);
204			} else {
205			$dispatcher->unbindSubscriber($subscriberArea, $providerArea);
206			}
207
208			// ajax response
209			$response = [
210			'result' => true,
211			'action' => $binding ? 'unbind' : 'bind',
212			'subscriberarea' => $subscriberArea,
213			'subscriberarea_id' => md5($subscriberArea),
214			'providerarea' => $providerArea,
215			'providerarea_id' => md5($providerArea),
216			'isSubscriberSelfCapable' => $collector->isCapable($subscriber->getOwner(), HookCollectorInterface::HOOK_SUBSCRIBE_OWN)
217			];
218
219			return $this->json($response);
220			}
221
222			/**
223			* @Route("/changeorder", methods = {"POST"}, options={"expose"=true})
224			*
225			* Changes the order of the providers' areas that are attached to a subscriber.
226			*
227			* @throws InvalidArgumentException Thrown if the subscriber or subscriberarea parameters aren't valid
228			* @throws RuntimeException Thrown if the subscriber module isn't available
229			* @throws AccessDeniedException Thrown if the user doesn't have admin access to the subscriber module
230			*/
231			public function changeProviderAreaOrderAction(
232			Request $request,
233			ZikulaHttpKernelInterface $kernel,
234			TranslatorInterface $translator,
235			PermissionApiInterface $permissionApi,
236			HookCollectorInterface $collector,
237			HookDispatcherInterface $hookDispatcher
238			): JsonResponse {
239			$this->setTranslator($translator);
240			if (!$this->isCsrfTokenValid('hook-ui', $request->request->get('token'))) {
241			throw new AccessDeniedException();
242			}
243
244			// get subscriberarea from POST
245			$subscriberarea = $request->request->get('subscriberarea', '');
246			if (empty($subscriberarea)) {
247			throw new InvalidArgumentException($this->trans('No subscriber area passed.'));
248			}
249
250			// get subscriber module based on area and do some checks
251			$subscriber = $collector->getSubscriber($subscriberarea);
252			if (null === $subscriber) {
253			throw new InvalidArgumentException($this->trans('Module "%name%" is not a valid subscriber.', ['%name%' => $subscriber->getOwner()]));
254			}
255			if (!$kernel->isBundle($subscriber->getOwner())) {
256			throw new RuntimeException($this->trans('Subscriber module "%name%" is not available.', ['%name%' => $subscriber->getOwner()]));
257			}
258			if (!$permissionApi->hasPermission($subscriber->getOwner() . '::', '::', ACCESS_ADMIN)) {
259			throw new AccessDeniedException();
260			}
261
262			// get providers' areas from POST
263			$providerarea = $request->request->get('providerarea', '');
264			if (!is_array($providerarea) \|\| count($providerarea) < 1) {
265			throw new InvalidArgumentException($this->trans('Providers\' areas order is not an array.'));
266			}
267
268			// set sorting
269			$hookDispatcher->setBindOrder($subscriberarea, $providerarea);
270
271			return $this->json(['result' => true]);
272			}
273			}
274

zikula / core

Push — master ( 86e506...1e27b6 )

HookController::toggleSubscribeAreaStatusAction() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like