Zikula\UsersBundle\Helper\RoleHelper::getRoleOptions()

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getRoleOptions(): array
    {
        $systemRoles = [
            'User' => 'ROLE_USER',
            'Editor' => 'ROLE_EDITOR',
            'Administrator' => 'ROLE_ADMIN',
            'Super administrator' => 'ROLE_SUPER_ADMIN',
        ];

        $definedRoles = [];
        array_walk_recursive($this->roleHierarchy, function($role) use (&$roles) {
            $definedRoles[$role] = $role;

$definedRoles was never initialized. Although not strictly required by PHP, it is generally a good practice to add $definedRoles = array(); before regardless.

        });

        $roles = $systemRoles;
        foreach ($definedRoles as $role) {
            if (!in_array($role, $roles, true)) {
                $roles[$role] = $role;
            }
        }

        return $roles;
    }