View GitHub Repository core

Schedule Inspection
Subscribe
Completed
Pull Request — master (#3991)
by Craig
05:34
created
Status
Category
Toggle Patches
src/lib/Zikula/Bundle/FormExtensionBundle/Form/Type/DynamicFieldType.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
             'placeholder' => $this->__('Select')
103 103 
         ]);
104 104
105 
-        $formModifier = function (FormInterface $form, $formType = null) use ($builder) {
105 
+        $formModifier = function(FormInterface $form, $formType = null) use ($builder) {
106 106 
             switch ($formType) {
107 107 
                 case ChoiceType::class:
108 108 
                     $optionsType = ChoiceFormOptionsArrayType::class;
 
@@ -138,12 +138,12 @@  discard block
 
 block discarded – undo
138 138 
             }
139 139 
             $form->add($formOptions->getForm());
140 140 
         };
141 
-        $builder->addEventListener(FormEvents::PRE_SET_DATA, static function (FormEvent $event) use ($formModifier) {
141 
+        $builder->addEventListener(FormEvents::PRE_SET_DATA, static function(FormEvent $event) use ($formModifier) {
142 142 
             $data = $event->getData();
143 143 
             $formType = $data['formType'];
144 144 
             $formModifier($event->getForm(), $formType);
145 145 
         });
146 
-        $builder->get('formType')->addEventListener(FormEvents::POST_SUBMIT, static function (FormEvent $event) use ($formModifier) {
146 
+        $builder->get('formType')->addEventListener(FormEvents::POST_SUBMIT, static function(FormEvent $event) use ($formModifier) {
147 147 
             $formType = $event->getForm()->getData();
148 148 
             $formModifier($event->getForm()->getParent(), $formType);
149 149 
         });
Please login to merge, or discard this patch.
lib/Zikula/Bundle/CoreInstallerBundle/Controller/AjaxInstallController.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -260,7 +260,7 @@
 
 block discarded – undo
260 260 
     {
261 261 
         // protect config.php and parameters.yml files
262 262 
         foreach ([
263 
-             dirname($this->container->get('kernel')->getRootDir()) . '/app/config/parameters.yml'
263 
+                dirname($this->container->get('kernel')->getRootDir()) . '/app/config/parameters.yml'
264 264 
         ] as $file) {
265 265 
             @chmod($file, 0400);
266 266 
             if (!is_readable($file)) {
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreInstallerBundle/Stage/Install/CompleteStage.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -97,11 +97,11 @@
 
 block discarded – undo
97 97 
     <title>${subject}</title>
98 98 
 </head>
99 99 
 <body>
100 
-<h1>Hi ${uName}!</h1>
100 
+<h1>Hi ${uname}!</h1>
101 101 
 <p>Zikula has been successfully installed at <a href="${url}">${url}</a>. If you have further questions,
102 102 
 visit <a href="https://ziku.la">ziku.la</a></p>
103 103 
 </body>
104 
-EOF;
104 
+eof;
105 105 
         $message = new Swift_Message($subject, $body, 'text/html');
106 106 
         $message->setFrom($adminUser->getEmail());
107 107 
         $message->setTo($adminUser->getEmail());
Please login to merge, or discard this patch.
src/lib/Zikula/Core/Doctrine/EntityAccess.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -140,6 +140,6 @@
 
 block discarded – undo
140 140 
         }
141 141
142 142 
         $class = get_class($this);
143 
-        throw new RuntimeException("Entity \"${class}\" does not have a setter for property \"${name}\". Please add ${setMethod}().");
143 
+        throw new RuntimeException("Entity \"${class}\" does not have a setter for property \"${name}\". Please add ${setmethod}().");
144 144 
     }
145 145 
 }
Please login to merge, or discard this patch.
src/lib/Zikula/Component/SortableColumns/Tests/SortableColumnsTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -35,7 +35,7 @@
 
 block discarded – undo
35 35
36 36 
         $router
37 37 
             ->method('generate')
38 
-            ->willReturnCallback(static function ($id, $params) {
38 
+            ->willReturnCallback(static function($id, $params) {
39 39 
                 return '/foo?' . http_build_query($params);
40 40 
             });
41 41
Please login to merge, or discard this patch.
src/system/RoutesModule/Twig/TwigExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -74,7 +74,7 @@
 
 block discarded – undo
74 74 
         if ($route->getTranslatable()) {
75 75 
             $languages = $container->get(LocaleApi::class)->getSupportedLocales();
76 76 
             // TODO migrate this legacy call
77 
-            $isRequiredLangParam = true;//ZLanguage::isRequiredLangParam();
77 
+            $isRequiredLangParam = true; //ZLanguage::isRequiredLangParam();
78 78 
             if (!$isRequiredLangParam) {
79 79 
                 $defaultLanguage = $this->variableApi->getSystemVar('language_i18n');
80 80 
                 unset($languages[array_search($defaultLanguage, $languages, true)]);
Please login to merge, or discard this patch.
src/system/RoutesModule/Controller/Base/AbstractAjaxController.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@
 
 block discarded – undo
36 36 
         Request $request,
37 37 
         EntityFactory $entityFactory
38 38 
     ): JsonResponse
39 
-     {
39 
+        {
40 40 
         if (!$request->isXmlHttpRequest()) {
41 41 
             return $this->json($this->__('Only ajax access is allowed!'), Response::HTTP_BAD_REQUEST);
42 42 
         }
Please login to merge, or discard this patch.
src/system/RoutesModule/Controller/AjaxController.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@
 
 block discarded – undo
36 36 
         Request $request,
37 37 
         EntityFactory $entityFactory
38 38 
     ): JsonResponse
39 
-     {
39 
+        {
40 40 
         return parent::updateSortPositionsAction($request, $entityFactory);
41 41 
     }
42 42
Please login to merge, or discard this patch.
src/system/RoutesModule/Entity/Repository/Base/AbstractRouteRepository.php 1 patch
Indentation   +18 added lines, -18 removed lines patch added patch discarded remove patch 
@@ -120,9 +120,9 @@  discard block
 
 block discarded – undo
120 120
121 121 
         $qb = $this->getEntityManager()->createQueryBuilder();
122 122 
         $qb->update($this->mainEntityClass, 'tbl')
123 
-           ->set('tbl.createdBy', $newUserId)
124 
-           ->where('tbl.createdBy = :creator')
125 
-           ->setParameter('creator', $userId);
123 
+            ->set('tbl.createdBy', $newUserId)
124 
+            ->where('tbl.createdBy = :creator')
125 
+            ->setParameter('creator', $userId);
126 126 
         $query = $qb->getQuery();
127 127 
         $query->execute();
128 128 
     
@@ -148,9 +148,9 @@  discard block
 
 block discarded – undo
148 148
149 149 
         $qb = $this->getEntityManager()->createQueryBuilder();
150 150 
         $qb->update($this->mainEntityClass, 'tbl')
151 
-           ->set('tbl.updatedBy', $newUserId)
152 
-           ->where('tbl.updatedBy = :editor')
153 
-           ->setParameter('editor', $userId);
151 
+            ->set('tbl.updatedBy', $newUserId)
152 
+            ->where('tbl.updatedBy = :editor')
153 
+            ->setParameter('editor', $userId);
154 154 
         $query = $qb->getQuery();
155 155 
         $query->execute();
156 156 
     
@@ -175,8 +175,8 @@  discard block
 
 block discarded – undo
175 175
176 176 
         $qb = $this->getEntityManager()->createQueryBuilder();
177 177 
         $qb->delete($this->mainEntityClass, 'tbl')
178 
-           ->where('tbl.createdBy = :creator')
179 
-           ->setParameter('creator', $userId);
178 
+            ->where('tbl.createdBy = :creator')
179 
+            ->setParameter('creator', $userId);
180 180 
         $query = $qb->getQuery();
181 181 
         $query->execute();
182 182 
     
@@ -201,8 +201,8 @@  discard block
 
 block discarded – undo
201 201
202 202 
         $qb = $this->getEntityManager()->createQueryBuilder();
203 203 
         $qb->delete($this->mainEntityClass, 'tbl')
204 
-           ->where('tbl.updatedBy = :editor')
205 
-           ->setParameter('editor', $userId);
204 
+            ->where('tbl.updatedBy = :editor')
205 
+            ->setParameter('editor', $userId);
206 206 
         $query = $qb->getQuery();
207 207 
         $query->execute();
208 208 
     
@@ -280,7 +280,7 @@  discard block
 
 block discarded – undo
280 280 
     {
281 281 
         if (0 < count($exclusions)) {
282 282 
             $qb->andWhere('tbl.id NOT IN (:excludedIdentifiers)')
283 
-               ->setParameter('excludedIdentifiers', $exclusions);
283 
+                ->setParameter('excludedIdentifiers', $exclusions);
284 284 
         }
285 285
286 286 
         return $qb;
 
@@ -332,7 +332,7 @@  discard block
 
 block discarded – undo
332 332 
         $offset = ($currentPage - 1) * $resultsPerPage;
333 333
334 334 
         $query->setFirstResult($offset)
335 
-              ->setMaxResults($resultsPerPage);
335 
+                ->setMaxResults($resultsPerPage);
336 336
337 337 
         return $query;
338 338 
     }
 
@@ -404,7 +404,7 @@  discard block
 
 block discarded – undo
404 404
405 405 
         $qb = $this->getEntityManager()->createQueryBuilder();
406 406 
         $qb->select($selection)
407 
-           ->from($this->mainEntityClass, 'tbl');
407 
+            ->from($this->mainEntityClass, 'tbl');
408 408
409 409 
         if (true === $useJoins) {
410 410 
             $this->addJoinsToFrom($qb);
 
@@ -441,7 +441,7 @@  discard block
 
 block discarded – undo
441 441 
     {
442 442 
         $qb = $this->getCountQuery();
443 443 
         $qb->andWhere('tbl.' . $fieldName . ' = :' . $fieldName)
444 
-           ->setParameter($fieldName, $fieldValue);
444 
+            ->setParameter($fieldName, $fieldValue);
445 445
446 446 
         if ($excludeId > 0) {
447 447 
             $qb = $this->addExclusion($qb, [$excludeId]);
 
@@ -477,7 +477,7 @@  discard block
 
 block discarded – undo
477 477
478 478 
         $qb = $this->getEntityManager()->createQueryBuilder();
479 479 
         $qb->select($selection)
480 
-           ->from($this->mainEntityClass, 'tbl');
480 
+            ->from($this->mainEntityClass, 'tbl');
481 481
482 482 
         if (true === $useJoins) {
483 483 
             $this->addJoinsToFrom($qb);
 
@@ -500,7 +500,7 @@  discard block
 
 block discarded – undo
500 500 
         if ('RAND()' === $orderBy) {
501 501 
             // random selection
502 502 
             $qb->addSelect('MOD(tbl.id, ' . random_int(2, 15) . ') AS HIDDEN randomIdentifiers')
503 
-               ->orderBy('randomIdentifiers');
503 
+                ->orderBy('randomIdentifiers');
504 504
505 505 
             return $qb;
506 506 
         }
 
@@ -519,12 +519,12 @@  discard block
 
 block discarded – undo
519 519 
         }
520 520 
         if (false !== strpos($orderBy, 'tbl.createdBy')) {
521 521 
             $qb->addSelect('tblCreator')
522 
-               ->leftJoin('tbl.createdBy', 'tblCreator');
522 
+                ->leftJoin('tbl.createdBy', 'tblCreator');
523 523 
             $orderBy = str_replace('tbl.createdBy', 'tblCreator.uname', $orderBy);
524 524 
         }
525 525 
         if (false !== strpos($orderBy, 'tbl.updatedBy')) {
526 526 
             $qb->addSelect('tblUpdater')
527 
-               ->leftJoin('tbl.updatedBy', 'tblUpdater');
527 
+                ->leftJoin('tbl.updatedBy', 'tblUpdater');
528 528 
             $orderBy = str_replace('tbl.updatedBy', 'tblUpdater.uname', $orderBy);
529 529 
         }
530 530 
         $qb->add('orderBy', $orderBy);
Please login to merge, or discard this patch.