Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 23 | View Code Duplication | class UserFieldTransformer implements DataTransformerInterface |
|
|
|
|||
| 24 | { |
||
| 25 | /** |
||
| 26 | * @var UserRepositoryInterface |
||
| 27 | */ |
||
| 28 | protected $userRepository; |
||
| 29 | |||
| 30 | /** |
||
| 31 | * UserFieldTransformer constructor. |
||
| 32 | * |
||
| 33 | * @param UserRepositoryInterface $userRepository UserRepository service instance |
||
| 34 | */ |
||
| 35 | public function __construct(UserRepositoryInterface $userRepository) |
||
| 39 | |||
| 40 | /** |
||
| 41 | * Transforms the object values to the normalised value. |
||
| 42 | * |
||
| 43 | * @param UserEntity|null $value |
||
| 44 | * |
||
| 45 | * @return int|null |
||
| 46 | */ |
||
| 47 | public function transform($value) |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Transforms the form value back to the user entity. |
||
| 62 | * |
||
| 63 | * @param int $value |
||
| 64 | * |
||
| 65 | * @return UserEntity|null |
||
| 66 | */ |
||
| 67 | public function reverseTransform($value) |
||
| 75 | } |
||
| 76 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.