HookCollectorTest - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/1.5'" - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 28dda4...aabe55 )

by Craig

created 2017-07-04 19:52 UTC

HookCollectorTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	170
Duplicated Lines	54.71 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	93
loc	170
rs	10
c	1
b	0
f	0
wmc	11
lcom	1
cbo	3

11 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	3	1
A	testAddProvider()	0	9	1
A	testExceptionOnAddDuplicateProviderAreaName()	12	12	1
A	testGetProvider()	10	10	1
A	testAddSubscriber()	9	9	1
A	testExceptionOnAddDuplicateSubscriberAreaName()	12	12	1
A	testGetSubscriber()	10	10	1
A	testGetProviders()	20	20	1
A	testGetSubscribers()	20	20	1
B	testIsCapable()	0	27	1
B	testGetOwnersCapableOf()	0	25	1

How to fix Duplicated Code

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\Bundle\HookBundle\Tests\Api;

use Zikula\Bundle\HookBundle\Collector\HookCollector;
use Zikula\Bundle\HookBundle\Collector\HookCollectorInterface;
use Zikula\Bundle\HookBundle\HookProviderInterface;
use Zikula\Bundle\HookBundle\HookSelfAllowedProviderInterface;
use Zikula\Bundle\HookBundle\HookSubscriberInterface;

class HookCollectorTest extends \PHPUnit_Framework_TestCase
{
    public function setUp()
    {
    }

    public function testAddProvider()
    {
        $collector = new HookCollector();
        $mockProvider = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider->method('getProviderTypes')->willReturn([]);
        $collector->addProvider('foo.areaName', 'foo.serviceName', $mockProvider);
        $this->assertTrue($collector->hasProvider('foo.areaName'));
    }

    public function testExceptionOnAddDuplicateProviderAreaName()

    {
        $collector = new HookCollector();
        $mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider1->method('getProviderTypes')->willReturn([]);
        $mockProvider2 = clone $mockProvider1;
        $collector->addProvider('foo1.areaName', 'foo1.serviceName', $mockProvider1);

        $this->setExpectedException(\InvalidArgumentException::class);
        $collector->addProvider('foo1.areaName', 'foo2.serviceName', $mockProvider2);
    }

    public function testGetProvider()

    {
        $collector = new HookCollector();
        $mockProvider = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider->method('getProviderTypes')->willReturn([]);
        $collector->addProvider('foo.areaName', 'foo.serviceName', $mockProvider);
        $provider = $collector->getProvider('foo.areaName');
        $this->assertInstanceOf(HookProviderInterface::class, $provider);
    }

    public function testAddSubscriber()

    {
        $collector = new HookCollector();
        $mockSubscriber = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber->method('getEvents')->willReturn([]);
        $collector->addSubscriber('foo.areaName', $mockSubscriber);
        $this->assertTrue($collector->hasSubscriber('foo.areaName'));
    }

    public function testExceptionOnAddDuplicateSubscriberAreaName()

    {
        $collector = new HookCollector();
        $mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber1->method('getEvents')->willReturn([]);
        $mockSubscriber2 = clone $mockSubscriber1;
        $collector->addSubscriber('foo1.areaName', $mockSubscriber1);

        $this->setExpectedException(\InvalidArgumentException::class);
        $collector->addSubscriber('foo1.areaName', $mockSubscriber2);
    }

    public function testGetSubscriber()

    {
        $collector = new HookCollector();
        $mockSubscriber = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber->method('getEvents')->willReturn([]);
        $collector->addSubscriber('foo.areaName', $mockSubscriber);
        $subsriber = $collector->getSubscriber('foo.areaName');
        $this->assertInstanceOf(HookSubscriberInterface::class, $subsriber);
    }

    public function testGetProviders()

    {
        $collector = new HookCollector();
        $mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider1->method('getProviderTypes')->willReturn([]);
        $mockProvider2 = clone $mockProvider1;
        $mockProvider3 = clone $mockProvider1;
        $mockProvider1->method('getOwner')->willReturn('foo');
        $mockProvider2->method('getOwner')->willReturn('bar');
        $mockProvider3->method('getOwner')->willReturn('foo');
        $collector->addProvider('foo1.areaName', 'foo1.serviceName', $mockProvider1);
        $collector->addProvider('foo2.areaName', 'foo2.serviceName', $mockProvider2);
        $collector->addProvider('foo3.areaName', 'foo3.serviceName', $mockProvider3);
        $providers = $collector->getProviders();
        $this->assertCount(3, $providers);
        $this->assertEquals(['foo1.areaName', 'foo2.areaName', 'foo3.areaName'], $collector->getProviderAreas());
        $this->assertEquals(['foo1.areaName', 'foo3.areaName'], $collector->getProviderAreasByOwner('foo'));
        $this->assertEquals(['foo2.areaName'], $collector->getProviderAreasByOwner('bar'));
    }

    public function testGetSubscribers()

    {
        $collector = new HookCollector();
        $mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber1->method('getEvents')->willReturn([]);
        $mockSubscriber2 = clone $mockSubscriber1;
        $mockSubscriber3 = clone $mockSubscriber1;
        $mockSubscriber1->method('getOwner')->willReturn('foo');
        $mockSubscriber2->method('getOwner')->willReturn('bar');
        $mockSubscriber3->method('getOwner')->willReturn('foo');
        $collector->addSubscriber('foo1.areaName', $mockSubscriber1);
        $collector->addSubscriber('foo2.areaName', $mockSubscriber2);
        $collector->addSubscriber('foo3.areaName', $mockSubscriber3);
        $subscribers = $collector->getSubscribers();
        $this->assertCount(3, $subscribers);
        $this->assertEquals(['foo1.areaName', 'foo2.areaName', 'foo3.areaName'], $collector->getSubscriberAreas());
        $this->assertEquals(['foo1.areaName', 'foo3.areaName'], $collector->getSubscriberAreasByOwner('foo'));
        $this->assertEquals(['foo2.areaName'], $collector->getSubscriberAreasByOwner('bar'));
    }

    public function testIsCapable()
    {
        $collector = new HookCollector();
        $mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber1->method('getEvents')->willReturn([]);
        $mockSubscriber1->method('getOwner')->willReturn('foo');
        $collector->addSubscriber('foo.subscriber.areaName', $mockSubscriber1);
        $mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider1->method('getProviderTypes')->willReturn([]);
        $mockProvider1->method('getOwner')->willReturn('foo');
        $collector->addProvider('foo.provider.areaName', 'foo.provider.serviceName', $mockProvider1);
        $mockProvider2 = $this->getMockBuilder(HookSelfAllowedProviderInterface::class)
            ->getMock();
        $mockProvider2->method('getProviderTypes')->willReturn([]);
        $mockProvider2->method('getOwner')->willReturn('bar');
        $collector->addProvider('foo.self.allowed.provider.areaName', 'foo.self.allowed.provider.serviceName', $mockProvider2);
        $this->assertTrue($collector->isCapable('foo', HookCollectorInterface::HOOK_SUBSCRIBER));
        $this->assertTrue($collector->isCapable('foo', HookCollectorInterface::HOOK_PROVIDER));
        $this->assertFalse($collector->isCapable('bar', HookCollectorInterface::HOOK_SUBSCRIBER));
        $this->assertTrue($collector->isCapable('bar', HookCollectorInterface::HOOK_PROVIDER));
        $this->assertTrue($collector->isCapable('bar', HookCollectorInterface::HOOK_SUBSCRIBE_OWN));

        $this->setExpectedException(\InvalidArgumentException::class);
        $collector->isCapable('foo', 'foo');
    }

    public function testGetOwnersCapableOf()
    {
        $collector = new HookCollector();
        $mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
            ->getMock();
        $mockSubscriber1->method('getEvents')->willReturn([]);
        $mockSubscriber1->method('getOwner')->willReturn('foo');
        $collector->addSubscriber('foo.subscriber.areaName', $mockSubscriber1);
        $mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
            ->getMock();
        $mockProvider1->method('getProviderTypes')->willReturn([]);
        $mockProvider1->method('getOwner')->willReturn('foo');
        $collector->addProvider('foo.provider.areaName', 'foo.provider.serviceName', $mockProvider1);
        $mockProvider2 = $this->getMockBuilder(HookSelfAllowedProviderInterface::class)
            ->getMock();
        $mockProvider2->method('getProviderTypes')->willReturn([]);
        $mockProvider2->method('getOwner')->willReturn('bar');
        $collector->addProvider('foo.self.allowed.provider.areaName', 'foo.self.allowed.provider.serviceName', $mockProvider2);
        $this->assertEquals(['foo'], $collector->getOwnersCapableOf(HookCollectorInterface::HOOK_SUBSCRIBER));
        $this->assertEquals(['foo', 'bar'], $collector->getOwnersCapableOf(HookCollectorInterface::HOOK_PROVIDER));

        $this->setExpectedException(\InvalidArgumentException::class);
        $collector->getOwnersCapableOf(HookCollectorInterface::HOOK_SUBSCRIBE_OWN);
        $collector->getOwnersCapableOf('foo');
    }
}


1		<?php
2
3		/*
4		* This file is part of the Zikula package.
5		*
6		* Copyright Zikula Foundation - http://zikula.org/
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Zikula\Bundle\HookBundle\Tests\Api;
13
14		use Zikula\Bundle\HookBundle\Collector\HookCollector;
15		use Zikula\Bundle\HookBundle\Collector\HookCollectorInterface;
16		use Zikula\Bundle\HookBundle\HookProviderInterface;
17		use Zikula\Bundle\HookBundle\HookSelfAllowedProviderInterface;
18		use Zikula\Bundle\HookBundle\HookSubscriberInterface;
19
20		class HookCollectorTest extends \PHPUnit_Framework_TestCase
21		{
22		public function setUp()
23		{
24		}
25
26		public function testAddProvider()
27		{
28		$collector = new HookCollector();
29		$mockProvider = $this->getMockBuilder(HookProviderInterface::class)
30		->getMock();
31		$mockProvider->method('getProviderTypes')->willReturn([]);
32		$collector->addProvider('foo.areaName', 'foo.serviceName', $mockProvider);
33		$this->assertTrue($collector->hasProvider('foo.areaName'));
34		}
35
36	View Code Duplication	public function testExceptionOnAddDuplicateProviderAreaName()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$collector = new HookCollector();
39		$mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
40		->getMock();
41		$mockProvider1->method('getProviderTypes')->willReturn([]);
42		$mockProvider2 = clone $mockProvider1;
43		$collector->addProvider('foo1.areaName', 'foo1.serviceName', $mockProvider1);
44
45		$this->setExpectedException(\InvalidArgumentException::class);
46		$collector->addProvider('foo1.areaName', 'foo2.serviceName', $mockProvider2);
47		}
48
49	View Code Duplication	public function testGetProvider()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		$collector = new HookCollector();
52		$mockProvider = $this->getMockBuilder(HookProviderInterface::class)
53		->getMock();
54		$mockProvider->method('getProviderTypes')->willReturn([]);
55		$collector->addProvider('foo.areaName', 'foo.serviceName', $mockProvider);
56		$provider = $collector->getProvider('foo.areaName');
57		$this->assertInstanceOf(HookProviderInterface::class, $provider);
58		}
59
60	View Code Duplication	public function testAddSubscriber()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		$collector = new HookCollector();
63		$mockSubscriber = $this->getMockBuilder(HookSubscriberInterface::class)
64		->getMock();
65		$mockSubscriber->method('getEvents')->willReturn([]);
66		$collector->addSubscriber('foo.areaName', $mockSubscriber);
67		$this->assertTrue($collector->hasSubscriber('foo.areaName'));
68		}
69
70	View Code Duplication	public function testExceptionOnAddDuplicateSubscriberAreaName()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		$collector = new HookCollector();
73		$mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
74		->getMock();
75		$mockSubscriber1->method('getEvents')->willReturn([]);
76		$mockSubscriber2 = clone $mockSubscriber1;
77		$collector->addSubscriber('foo1.areaName', $mockSubscriber1);
78
79		$this->setExpectedException(\InvalidArgumentException::class);
80		$collector->addSubscriber('foo1.areaName', $mockSubscriber2);
81		}
82
83	View Code Duplication	public function testGetSubscriber()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
84		{
85		$collector = new HookCollector();
86		$mockSubscriber = $this->getMockBuilder(HookSubscriberInterface::class)
87		->getMock();
88		$mockSubscriber->method('getEvents')->willReturn([]);
89		$collector->addSubscriber('foo.areaName', $mockSubscriber);
90		$subsriber = $collector->getSubscriber('foo.areaName');
91		$this->assertInstanceOf(HookSubscriberInterface::class, $subsriber);
92		}
93
94	View Code Duplication	public function testGetProviders()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		{
96		$collector = new HookCollector();
97		$mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
98		->getMock();
99		$mockProvider1->method('getProviderTypes')->willReturn([]);
100		$mockProvider2 = clone $mockProvider1;
101		$mockProvider3 = clone $mockProvider1;
102		$mockProvider1->method('getOwner')->willReturn('foo');
103		$mockProvider2->method('getOwner')->willReturn('bar');
104		$mockProvider3->method('getOwner')->willReturn('foo');
105		$collector->addProvider('foo1.areaName', 'foo1.serviceName', $mockProvider1);
106		$collector->addProvider('foo2.areaName', 'foo2.serviceName', $mockProvider2);
107		$collector->addProvider('foo3.areaName', 'foo3.serviceName', $mockProvider3);
108		$providers = $collector->getProviders();
109		$this->assertCount(3, $providers);
110		$this->assertEquals(['foo1.areaName', 'foo2.areaName', 'foo3.areaName'], $collector->getProviderAreas());
111		$this->assertEquals(['foo1.areaName', 'foo3.areaName'], $collector->getProviderAreasByOwner('foo'));
112		$this->assertEquals(['foo2.areaName'], $collector->getProviderAreasByOwner('bar'));
113		}
114
115	View Code Duplication	public function testGetSubscribers()
		0 ignored issues – show Duplication introduced 2017-07-04 19:57 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		{
117		$collector = new HookCollector();
118		$mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
119		->getMock();
120		$mockSubscriber1->method('getEvents')->willReturn([]);
121		$mockSubscriber2 = clone $mockSubscriber1;
122		$mockSubscriber3 = clone $mockSubscriber1;
123		$mockSubscriber1->method('getOwner')->willReturn('foo');
124		$mockSubscriber2->method('getOwner')->willReturn('bar');
125		$mockSubscriber3->method('getOwner')->willReturn('foo');
126		$collector->addSubscriber('foo1.areaName', $mockSubscriber1);
127		$collector->addSubscriber('foo2.areaName', $mockSubscriber2);
128		$collector->addSubscriber('foo3.areaName', $mockSubscriber3);
129		$subscribers = $collector->getSubscribers();
130		$this->assertCount(3, $subscribers);
131		$this->assertEquals(['foo1.areaName', 'foo2.areaName', 'foo3.areaName'], $collector->getSubscriberAreas());
132		$this->assertEquals(['foo1.areaName', 'foo3.areaName'], $collector->getSubscriberAreasByOwner('foo'));
133		$this->assertEquals(['foo2.areaName'], $collector->getSubscriberAreasByOwner('bar'));
134		}
135
136		public function testIsCapable()
137		{
138		$collector = new HookCollector();
139		$mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
140		->getMock();
141		$mockSubscriber1->method('getEvents')->willReturn([]);
142		$mockSubscriber1->method('getOwner')->willReturn('foo');
143		$collector->addSubscriber('foo.subscriber.areaName', $mockSubscriber1);
144		$mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
145		->getMock();
146		$mockProvider1->method('getProviderTypes')->willReturn([]);
147		$mockProvider1->method('getOwner')->willReturn('foo');
148		$collector->addProvider('foo.provider.areaName', 'foo.provider.serviceName', $mockProvider1);
149		$mockProvider2 = $this->getMockBuilder(HookSelfAllowedProviderInterface::class)
150		->getMock();
151		$mockProvider2->method('getProviderTypes')->willReturn([]);
152		$mockProvider2->method('getOwner')->willReturn('bar');
153		$collector->addProvider('foo.self.allowed.provider.areaName', 'foo.self.allowed.provider.serviceName', $mockProvider2);
154		$this->assertTrue($collector->isCapable('foo', HookCollectorInterface::HOOK_SUBSCRIBER));
155		$this->assertTrue($collector->isCapable('foo', HookCollectorInterface::HOOK_PROVIDER));
156		$this->assertFalse($collector->isCapable('bar', HookCollectorInterface::HOOK_SUBSCRIBER));
157		$this->assertTrue($collector->isCapable('bar', HookCollectorInterface::HOOK_PROVIDER));
158		$this->assertTrue($collector->isCapable('bar', HookCollectorInterface::HOOK_SUBSCRIBE_OWN));
159
160		$this->setExpectedException(\InvalidArgumentException::class);
161		$collector->isCapable('foo', 'foo');
162		}
163
164		public function testGetOwnersCapableOf()
165		{
166		$collector = new HookCollector();
167		$mockSubscriber1 = $this->getMockBuilder(HookSubscriberInterface::class)
168		->getMock();
169		$mockSubscriber1->method('getEvents')->willReturn([]);
170		$mockSubscriber1->method('getOwner')->willReturn('foo');
171		$collector->addSubscriber('foo.subscriber.areaName', $mockSubscriber1);
172		$mockProvider1 = $this->getMockBuilder(HookProviderInterface::class)
173		->getMock();
174		$mockProvider1->method('getProviderTypes')->willReturn([]);
175		$mockProvider1->method('getOwner')->willReturn('foo');
176		$collector->addProvider('foo.provider.areaName', 'foo.provider.serviceName', $mockProvider1);
177		$mockProvider2 = $this->getMockBuilder(HookSelfAllowedProviderInterface::class)
178		->getMock();
179		$mockProvider2->method('getProviderTypes')->willReturn([]);
180		$mockProvider2->method('getOwner')->willReturn('bar');
181		$collector->addProvider('foo.self.allowed.provider.areaName', 'foo.self.allowed.provider.serviceName', $mockProvider2);
182		$this->assertEquals(['foo'], $collector->getOwnersCapableOf(HookCollectorInterface::HOOK_SUBSCRIBER));
183		$this->assertEquals(['foo', 'bar'], $collector->getOwnersCapableOf(HookCollectorInterface::HOOK_PROVIDER));
184
185		$this->setExpectedException(\InvalidArgumentException::class);
186		$collector->getOwnersCapableOf(HookCollectorInterface::HOOK_SUBSCRIBE_OWN);
187		$collector->getOwnersCapableOf('foo');
188		}
189		}
190

zikula / core

Push — master ( 28dda4...aabe55 )

HookCollectorTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like