Zikula\BlocksModule\Tests\Api\BlockFactoryApiTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	80
Duplicated Lines	30 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	8	1
A	testGetBlockDefinedAsService()	0	4	1
A	testDoesNotExistException()	0	4	1
A	testWrongInterfaceException()	0	4	1
A	testGetInstanceOfAbstractExtensionBlock()	12	12	1
A	testGetInstanceOfInterfaceExtensionBlock()	12	12	1

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\BlocksModule\Tests\Api;

use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Zikula\BlocksModule\AbstractBlockHandler;
use Zikula\BlocksModule\Api\ApiInterface\BlockFactoryApiInterface;
use Zikula\BlocksModule\Api\BlockFactoryApi;
use Zikula\BlocksModule\BlockHandlerInterface;
use Zikula\BlocksModule\Helper\ServiceNameHelper;
use Zikula\BlocksModule\Tests\Api\Fixture\AcmeFooModule;
use Zikula\BlocksModule\Tests\Api\Fixture\BarBlock;
use Zikula\BlocksModule\Tests\Api\Fixture\FooBlock;
use Zikula\BlocksModule\Tests\Api\Fixture\WrongInterfaceBlock;
use Zikula\Common\Translator\IdentityTranslator;

class BlockFactoryApiTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var BlockFactoryApiInterface
     */
    private $api;

    /**
     * @var ContainerInterface
     */
    private $container;

    /**
     * BlockApiTest setup.
     */
    public function setUp()
    {
        $this->container = new Container();

It seems like new \Symfony\Component\DependencyInjection\Container() of type object<Symfony\Component\DependencyInjection\Container> is incompatible with the declared type object<Symfony\Component\DependencyInjection\ContainerInterface> of property $container.

        $this->container->set('translator.default', new IdentityTranslator());
        $this->container->set('foo.block', new FooBlock());
        $this->container->set('zikula_extensions_module.api.variable', new \stdClass());
        $this->api = new BlockFactoryApi($this->container);
    }

    /**
     * @covers BlockFactoryApiInterface::getInstance()
     */
    public function testGetBlockDefinedAsService()
    {
        $this->assertEquals($this->container->get('foo.block'), $this->api->getInstance('foo.block', new AcmeFooModule()));
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testDoesNotExistException()
    {
        $this->api->getInstance('BarModule\ZedBlock', new AcmeFooModule());
    }

    /**
     * @expectedException \RuntimeException
     */
    public function testWrongInterfaceException()
    {
        $this->api->getInstance(WrongInterfaceBlock::class, new AcmeFooModule());
    }

    /**
     * @covers BlockFactoryApiInterface::getInstance()
     */
    public function testGetInstanceOfAbstractExtensionBlock()

This method seems to be duplicated in your project.

    {
        $blockInstance = $this->api->getInstance(BarBlock::class, new AcmeFooModule());
        $this->assertNotEmpty($blockInstance);
        $this->assertInstanceOf(AbstractBlockHandler::class, $blockInstance);
        $this->assertEquals('Bar', $blockInstance->getType());
        $serviceNameHelper = new ServiceNameHelper();
        $blockServiceName = $serviceNameHelper->generateServiceNameFromClassName(BarBlock::class);
        $this->assertTrue($this->container->has($blockServiceName));
        $retrievedBlockService = $this->container->get($blockServiceName);
        $this->assertInstanceOf(BlockHandlerInterface::class, $retrievedBlockService);
    }

    /**
     * @covers BlockFactoryApiInterface::getInstance()
     */
    public function testGetInstanceOfInterfaceExtensionBlock()

This method seems to be duplicated in your project.

    {
        $blockInstance = $this->api->getInstance(FooBlock::class, new AcmeFooModule());
        $this->assertNotEmpty($blockInstance);
        $this->assertInstanceOf(BlockHandlerInterface::class, $blockInstance);
        $this->assertEquals('FooType', $blockInstance->getType());
        $serviceNameHelper = new ServiceNameHelper();
        $blockServiceName = $serviceNameHelper->generateServiceNameFromClassName(FooBlock::class);
        $this->assertTrue($this->container->has($blockServiceName));
        $retrievedBlockService = $this->container->get($blockServiceName);
        $this->assertInstanceOf(BlockHandlerInterface::class, $retrievedBlockService);
    }
}