Completed
Pull Request — master (#3525)
by Craig
08:24
created
src/lib/Zikula/Bundle/CoreBundle/Bundle/Scanner.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -92,6 +92,9 @@  discard block
 block discarded – undo
92 92
         return false;
93 93
     }
94 94
 
95
+    /**
96
+     * @param string $file
97
+     */
95 98
     public function getFileContents($file)
96 99
     {
97 100
         return file_get_contents($file);
@@ -142,6 +145,10 @@  discard block
 block discarded – undo
142 145
         return true;
143 146
     }
144 147
 
148
+    /**
149
+     * @param string $type
150
+     * @param boolean $indexByShortName
151
+     */
145 152
     private function getMetaData($type, $indexByShortName)
146 153
     {
147 154
         $array = [];
Please login to merge, or discard this patch.
src/lib/Zikula/Component/FilterUtil/FilterUtil.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -167,7 +167,7 @@
 block discarded – undo
167 167
     /**
168 168
      * Set filterstring.
169 169
      *
170
-     * @param mixed $filter Filter string or array
170
+     * @param string $filter Filter string or array
171 171
      *
172 172
      * @return void
173 173
      */
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 
126 126
         // Get filter1 ... filterN
127 127
         while (true) {
128
-            $filterURLName = $this->filterKey."$i";
128
+            $filterURLName = $this->filterKey . "$i";
129 129
             $filterStr = $this->request->query->filter(
130 130
                 $filterURLName,
131 131
                 '',
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
         if (!isset($this->filter) || empty($this->filter)) {
154 154
             $filter = $this->getFiltersFromInput();
155 155
             if (is_array($filter) && count($filter) > 0) {
156
-                $this->filter = "(".implode(')*(', $filter).")";
156
+                $this->filter = "(" . implode(')*(', $filter) . ")";
157 157
             }
158 158
         }
159 159
 
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
     public function setFilter($filter)
175 175
     {
176 176
         if (is_array($filter)) {
177
-            $this->filter = "(".implode(')*(', $filter).")";
177
+            $this->filter = "(" . implode(')*(', $filter) . ")";
178 178
         } else {
179 179
             $this->filter = $filter;
180 180
         }
@@ -221,9 +221,9 @@  discard block
 block discarded – undo
221 221
         } elseif (substr($filter, 0, 1) == ',') {
222 222
             $this->filter .= $filter;
223 223
         } elseif (substr($filter, 0, 1) == '*') {
224
-            $this->filter .= ','.(substr($filter, 1));
224
+            $this->filter .= ',' . (substr($filter, 1));
225 225
         } else {
226
-            $this->filter .= ','.($filter);
226
+            $this->filter .= ',' . ($filter);
227 227
         }
228 228
     }
229 229
 
@@ -243,9 +243,9 @@  discard block
 block discarded – undo
243 243
         } elseif (substr($filter, 0, 1) == '*') {
244 244
             $this->filter .= $filter;
245 245
         } elseif (substr($filter, 0, 1) == ',') {
246
-            $this->filter .= '*'.(substr($filter, 1));
246
+            $this->filter .= '*' . (substr($filter, 1));
247 247
         } else {
248
-            $this->filter .= '*'.($filter);
248
+            $this->filter .= '*' . ($filter);
249 249
         }
250 250
     }
251 251
 
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -349,9 +349,11 @@
 block discarded – undo
349 349
                             break;
350 350
                         }
351 351
                     }
352
-                    if ($or === null) { // make new or Object
352
+                    if ($or === null) {
353
+// make new or Object
353 354
                         $or = new Orx();
354
-                        if ($and !== null) { // add existing and
355
+                        if ($and !== null) {
356
+// add existing and
355 357
                             $this->addBtoA($or, $and);
356 358
                         }
357 359
                     }
Please login to merge, or discard this patch.
src/lib/Zikula/Component/FilterUtil/Plugin/DatePlugin.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
     /**
23 23
      * Returns the operators the plugin can handle.
24 24
      *
25
-     * @return array Operators
25
+     * @return string[] Operators
26 26
      */
27 27
     public function availableOperators()
28 28
     {
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
      * @param string $date Date string
99 99
      * @param string $type Period type
100 100
      *
101
-     * @return array Start and end of the period
101
+     * @return integer[] Start and end of the period
102 102
      */
103 103
     private function makePeriod($date, $type)
104 104
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
         if (preg_match('~^(year|month|week|day|hour|min):\s*(.*)$~i', $value, $res)) {
177 177
             $type = strtolower($res[1]);
178 178
             if (strlen($res[2]) == 4) {
179
-                $res[2] = "01.01.".$res[2];
179
+                $res[2] = "01.01." . $res[2];
180 180
             }
181 181
             $time = strtotime($res[2]);
182 182
         } elseif (preg_match('~(year|month|week|day|hour|min|tomorrow)~', $value, $res)) {
Please login to merge, or discard this patch.
src/lib/Zikula/Core/Response/Ajax/AbstractBaseResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
     /**
100 100
      * Generates payload.
101 101
      *
102
-     * @return array
102
+     * @return string
103 103
      */
104 104
     protected function generatePayload()
105 105
     {
Please login to merge, or discard this patch.
src/system/BlocksModule/Api/BlockApi.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@
 block discarded – undo
82 82
 
83 83
     /**
84 84
      * Get an unfiltered array of block entities that have been assigned to a block position.
85
-     * @param $positionName
85
+     * @param string $positionName
86 86
      * @return array
87 87
      */
88 88
     public function getBlocksByPosition($positionName)
Please login to merge, or discard this patch.
src/system/BlocksModule/Entity/BlockEntity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@
 block discarded – undo
277 277
     /**
278 278
      * set the filters for the block
279 279
      *
280
-     * @param array $filter the blocks's filters
280
+     * @param array $filters the blocks's filters
281 281
      */
282 282
     public function setFilters($filters)
283 283
     {
Please login to merge, or discard this patch.
src/system/UsersModule/Entity/UserAttributeEntity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
     /**
76 76
      * set the user item
77 77
      *
78
-     * @param User $user the user item
78
+     * @param integer $user the user item
79 79
      */
80 80
     public function setUser($user)
81 81
     {
Please login to merge, or discard this patch.
src/system/AdminModule/Helper/UpdateCheckHelper.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -208,7 +208,7 @@
 block discarded – undo
208 208
             if (!$fp) {
209 209
                 return false;
210 210
             } else {
211
-                $out = "GET $path_query? HTTP/1.1\r\n";
211
+                $out = "get $path_query? HTTP/1.1\r\n";
212 212
                 $out .= "User-Agent: $userAgent\r\n";
213 213
                 $out .= "Referer: $ref\r\n";
214 214
                 $out .= "Host: $urlArray[host]\r\n";
Please login to merge, or discard this patch.
src/system/BlocksModule/Tests/Helper/InstallerHelperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             ->getMock();
55 55
         $kernel
56 56
             ->method('getModule')
57
-            ->will($this->returnCallback(function ($moduleName) {
57
+            ->will($this->returnCallback(function($moduleName) {
58 58
                 if ($moduleName == 'ExceptionModule') {
59 59
                     // mocks situation where module is not namespaced.
60 60
                     throw new \Exception();
Please login to merge, or discard this patch.