Completed
Pull Request — master (#3525)
by Craig
08:24
created
src/lib/Zikula/Bundle/CoreInstallerBundle/Stage/Install/DbCredsStage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
     public function __construct(ContainerInterface $container)
27 27
     {
28 28
         $this->container = $container;
29
-        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
29
+        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
30 30
     }
31 31
 
32 32
     public function getName()
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreInstallerBundle/Stage/LocaleStage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     public function __construct(ContainerInterface $container)
46 46
     {
47 47
         $this->container = $container;
48
-        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml', 'parameters.yml');
48
+        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml', 'parameters.yml');
49 49
         $this->installedLocales = $container->get('zikula_settings_module.locale_api')->getSupportedLocales();
50 50
         $this->matchedLocale = $container->get('zikula_settings_module.locale_api')->getBrowserLocale();
51 51
     }
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreInstallerBundle/Command/UpgradeCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -118,7 +118,7 @@
 block discarded – undo
118 118
         $io->newLine();
119 119
 
120 120
         // write the parameters to custom_parameters.yml
121
-        $yamlManager = new YamlDumper($this->getContainer()->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
121
+        $yamlManager = new YamlDumper($this->getContainer()->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
122 122
         $params = array_merge($yamlManager->getParameters(), $settings);
123 123
         $yamlManager->setParameters($params);
124 124
 
Please login to merge, or discard this patch.
src/lib/Zikula/Common/ClassProperties.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
         }
55 55
 
56 56
         foreach ($properties as $k => $v) {
57
-            $lookup = 'set'.strtolower($k);
57
+            $lookup = 'set' . strtolower($k);
58 58
             if (isset($methodMap[$lookup])) {
59 59
                 $reflectionMethod = new \ReflectionMethod($className, $methodMap[$lookup]);
60 60
                 $reflectionMethod->invoke($object, $v);
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/AbstractController.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
     }
75 75
 
76 76
     /**
77
-     * @param $moduleName
77
+     * @param string $moduleName
78 78
      * @return bool
79 79
      */
80 80
     protected function installModule($moduleName)
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     /**
119 119
      * Set an admin category for a module or set to default
120 120
      * @param $moduleName
121
-     * @param $translatedCategoryName
121
+     * @param string $translatedCategoryName
122 122
      */
123 123
     protected function setModuleCategory($moduleName, $translatedCategoryName)
124 124
     {
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Base/AbstractAppSettingsType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
                 'attr' => [
107 107
                     'maxlength' => 255,
108 108
                     'title' => $this->__('Enter the route entries per page.') . ' ' . $this->__('Only digits are allowed.')
109
-                ],'scale' => 0
109
+                ], 'scale' => 0
110 110
             ])
111 111
         ;
112 112
     }
Please login to merge, or discard this patch.
src/lib/Zikula/Bundle/CoreBundle/Translation/ZikulaJsFileExtractor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
         preg_match_all($argumentsRegex, file_get_contents($file), $singularMatches);
46 46
         foreach ($singularMatches[2] as $string) {
47 47
             $message = new Message($string, self::JAVASCRIPT_DOMAIN);
48
-            $message->addSource(new FileSource((string) $file));
48
+            $message->addSource(new FileSource((string)$file));
49 49
             $catalogue->add($message);
50 50
         }
51 51
         // plural type
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
         foreach ($pluralMatches[2] as $key => $singularString) {
55 55
             $fullString = $singularString . '|' . $pluralMatches[4][$key];
56 56
             $message = new Message($fullString, self::JAVASCRIPT_DOMAIN);
57
-            $message->addSource(new FileSource((string) $file));
57
+            $message->addSource(new FileSource((string)$file));
58 58
             $catalogue->add($message);
59 59
         }
60 60
     }
Please login to merge, or discard this patch.
src/system/MenuModule/Controller/MenuController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,10 +75,10 @@
 block discarded – undo
75 75
             [
76 76
                 'decorate' => true,
77 77
                 'html' => true,
78
-                'childOpen' => function ($node) {
78
+                'childOpen' => function($node) {
79 79
                     return '<li class="jstree-open" id="' . $this->domTreeNodePrefix . $node['id'] . '">';
80 80
                 },
81
-                'nodeDecorator' => function ($node) {
81
+                'nodeDecorator' => function($node) {
82 82
                     return '<a href="#">' . $node['title'] . ' (' . $node['id'] . ')</a>';
83 83
                 }
84 84
             ]
Please login to merge, or discard this patch.
src/system/RoutesModule/Controller/Base/AbstractRouteController.php 2 patches
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -122,6 +122,10 @@
 block discarded – undo
122 122
 
123 123
     /**
124 124
      * This method includes the common implementation code for adminView() and view().
125
+     * @param string $sort
126
+     * @param string $sortdir
127
+     * @param integer $pos
128
+     * @param integer $num
125 129
      */
126 130
     protected function viewInternal(Request $request, $sort, $sortdir, $pos, $num, $isAdmin = false)
127 131
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -506,7 +506,7 @@
 block discarded – undo
506 506
             try {
507 507
                 // execute the workflow action
508 508
                 $success = $workflowHelper->executeAction($entity, $action);
509
-            } catch(\Exception $e) {
509
+            } catch (\Exception $e) {
510 510
                 $this->addFlash('error', $this->__f('Sorry, but an error occured during the %action% action.', ['%action%' => $action]) . '  ' . $e->getMessage());
511 511
                 $logger->error('{app}: User {user} tried to execute the {action} workflow action for the {entity} with id {id}, but failed. Error details: {errorMessage}.', ['app' => 'ZikulaRoutesModule', 'user' => $userName, 'action' => $action, 'entity' => 'route', 'id' => $itemId, 'errorMessage' => $e->getMessage()]);
512 512
             }
Please login to merge, or discard this patch.