Completed
Push — master ( 8e6dfe...ada09b )
by Craig
07:23
created
src/system/RoutesModule/Helper/Base/AbstractControllerHelper.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      * @param string $context Usage context (allowed values: controllerAction, api, helper, actionHandler, block, contentType, util)
89 89
      * @param array  $args    Additional arguments
90 90
      *
91
-     * @return array List of allowed object types
91
+     * @return string[] List of allowed object types
92 92
      */
93 93
     public function getObjectTypes($context = '', array $args = [])
94 94
     {
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
      * @param string $context    Usage context (allowed values: controllerAction, api, actionHandler, block, contentType)
382 382
      * @param array  $args       Additional arguments
383 383
      *
384
-     * @return array List of template variables to be assigned
384
+     * @return string List of template variables to be assigned
385 385
      */
386 386
     public function addTemplateParameters($objectType = '', array $parameters = [], $context = '', array $args = [])
387 387
     {
Please login to merge, or discard this patch.
src/system/RoutesModule/Listener/Base/AbstractEntityLifecycleListener.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@
 block discarded – undo
262 262
      *
263 263
      * @param EntityAccess $entity The given entity
264 264
      *
265
-     * @return Event The created event instance
265
+     * @return string The created event instance
266 266
      */
267 267
     protected function createFilterEvent($entity)
268 268
     {
Please login to merge, or discard this patch.
src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -171,14 +171,14 @@  discard block
 block discarded – undo
171 171
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
172 172
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
173 173
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
174
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
174
+                            ->setParameter($k, substr($v, 1, strlen($v)-1));
175 175
                     } elseif (substr($v, 0, 1) == '%') {
176 176
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
177
-                           ->setParameter($k, '%' . $v . '%');
177
+                            ->setParameter($k, '%' . $v . '%');
178 178
                     } else {
179 179
                         $qb->andWhere('tbl.' . $k . ' = :' . $k)
180
-                           ->setParameter($k, $v);
181
-                   }
180
+                            ->setParameter($k, $v);
181
+                    }
182 182
                 }
183 183
             }
184 184
         }
@@ -282,10 +282,10 @@  discard block
 block discarded – undo
282 282
     
283 283
         if (is_array($userId)) {
284 284
             $qb->andWhere('tbl.createdBy IN (:userIds)')
285
-               ->setParameter('userIds', $userId);
285
+                ->setParameter('userIds', $userId);
286 286
         } else {
287 287
             $qb->andWhere('tbl.createdBy = :userId')
288
-               ->setParameter('userId', $userId);
288
+                ->setParameter('userId', $userId);
289 289
         }
290 290
     
291 291
         return $qb;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
172 172
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
173 173
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
174
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
174
+                           ->setParameter($k, substr($v, 1, strlen($v) - 1));
175 175
                     } elseif (substr($v, 0, 1) == '%') {
176 176
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
177 177
                            ->setParameter($k, '%' . $v . '%');
Please login to merge, or discard this patch.
src/system/PermissionsModule/Api/PermissionApi.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
      * @param PermissionRepositoryInterface $permRepository Permission repository
81 81
      * @param UserRepositoryInterface $userRepository User repository
82 82
      * @param CurrentUserApiInterface $currentUserApi
83
-     * @param TranslatorInterface $translator Translator service instance
83
+     * @param \Zikula\Common\Translator\IdentityTranslator $translator Translator service instance
84 84
      */
85 85
     public function __construct(
86 86
         PermissionRepositoryInterface $permRepository,
Please login to merge, or discard this patch.
src/system/PermissionsModule/Tests/Api/PermissionApiTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
         $this->userRepo
56 56
             ->method('findByUids')
57 57
             ->with($this->anything())
58
-            ->will($this->returnCallback(function (array $uids) {
58
+            ->will($this->returnCallback(function(array $uids) {
59 59
                 $groups = [];
60 60
                 // getGroups returns [gid => $group, gid => $group, ...]
61 61
                 if (in_array(self::RANDOM_USER_ID, $uids)) {
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
         $this->currentUserApi
126 126
             ->method('get')
127 127
             ->with($this->equalTo('uid'))
128
-            ->will($this->returnCallback(function () use ($uid) {
128
+            ->will($this->returnCallback(function() use ($uid) {
129 129
                 return isset($uid) ? $uid : Constant::USER_ID_ANONYMOUS;
130 130
             }));
131 131
         $api = new PermissionApi($this->permRepo, $this->userRepo, $this->currentUserApi, $this->translator);
Please login to merge, or discard this patch.
src/system/GroupsModule/GroupsModuleInstaller.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,8 +70,8 @@
 block discarded – undo
70 70
         switch ($oldVersion) {
71 71
             case '2.3.2':
72 72
             case '2.4.0':
73
-                $this->setVar('mailwarning', (bool) $this->getVar('mailwarning'));
74
-                $this->setVar('hideclosed', (bool) $this->getVar('hideclosed'));
73
+                $this->setVar('mailwarning', (bool)$this->getVar('mailwarning'));
74
+                $this->setVar('hideclosed', (bool)$this->getVar('hideclosed'));
75 75
                 $this->setVar('hidePrivate', false);
76 76
             case '2.4.1':
77 77
                 /** @var UserEntity $anonymousUser */
Please login to merge, or discard this patch.
src/system/CategoriesModule/Entity/CategoryEntity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -383,7 +383,7 @@
 block discarded – undo
383 383
 
384 384
     /**
385 385
      * get the category display name
386
-     * @param $lang
386
+     * @param string $lang
387 387
      *
388 388
      * @return array|string the category display name(s)
389 389
      */
Please login to merge, or discard this patch.
src/system/UsersModule/Twig/Extension/OnlineExtension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,6 +69,6 @@
 block discarded – undo
69 69
             ->andWhere(Criteria::expr()->gt('lastused', $since));
70 70
         $online = $this->sessionRepository->matching($c)->count();
71 71
 
72
-        return (bool) $online;
72
+        return (bool)$online;
73 73
     }
74 74
 }
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Handler/Common/Base/AbstractEditHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -292,7 +292,7 @@
 block discarded – undo
292 292
         $routeParams = $this->request->get('_route_params', []);
293 293
         if (empty($this->idValue)) {
294 294
             if (array_key_exists($this->idField, $routeParams)) {
295
-                $this->idValue = (int) !empty($routeParams[$this->idField]) ? $routeParams[$this->idField] : 0;
295
+                $this->idValue = (int)!empty($routeParams[$this->idField]) ? $routeParams[$this->idField] : 0;
296 296
             }
297 297
             if (0 === $this->idValue) {
298 298
                 $this->idValue = $this->request->query->getInt($this->idField, 0);
Please login to merge, or discard this patch.