zikula / core

src/system/RoutesModule/Entity/Repository/Base/AbstractRouteRepository.php

Unused Use Statements +2 added lines, -3 removed lines

@@ -13,17 +13,16 @@
 namespace Zikula\RoutesModule\Entity\Repository\Base;
 
 use Doctrine\Common\Collections\ArrayCollection;
-use Gedmo\Sortable\Entity\Repository\SortableRepository;
-
 use Doctrine\ORM\Query;
 use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Tools\Pagination\Paginator;
+use Gedmo\Sortable\Entity\Repository\SortableRepository;
 use InvalidArgumentException;
 use Psr\Log\LoggerInterface;
 use Zikula\Common\Translator\TranslatorInterface;
-use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\RoutesModule\Entity\RouteEntity;
 use Zikula\RoutesModule\Helper\CollectionFilterHelper;
+use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 
 /**
  * Repository class used to implement own convenience methods for performing certain DQL queries.

Indentation +18 added lines, -18 removed lines

@@ -150,9 +150,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.createdBy', $newUserId)
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->set('tbl.createdBy', $newUserId)
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -183,9 +183,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.updatedBy', $newUserId)
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->set('tbl.updatedBy', $newUserId)
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -214,8 +214,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -244,8 +244,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -330,7 +330,7 @@ 
     {
         if (count($exclusions) > 0) {
             $qb->andWhere('tbl.id NOT IN (:excludedIdentifiers)')
-               ->setParameter('excludedIdentifiers', $exclusions);
+                ->setParameter('excludedIdentifiers', $exclusions);
         }
     
         return $qb;
@@ -390,7 +390,7 @@ 
         $offset = ($currentPage - 1) * $resultsPerPage;
     
         $query->setFirstResult($offset)
-              ->setMaxResults($resultsPerPage);
+                ->setMaxResults($resultsPerPage);
     
         return $query;
     }
@@ -487,7 +487,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (!empty($where)) {
             $qb->andWhere($where);
@@ -536,7 +536,7 @@ 
     {
         $qb = $this->getCountQuery('', false);
         $qb->andWhere('tbl.' . $fieldName . ' = :' . $fieldName)
-           ->setParameter($fieldName, $fieldValue);
+            ->setParameter($fieldName, $fieldValue);
     
         if ($excludeId > 0) {
             $qb = $this->addExclusion($qb, [$excludeId]);
@@ -579,7 +579,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (true === $useJoins) {
             $this->addJoinsToFrom($qb);
@@ -607,7 +607,7 @@ 
         if ($orderBy == 'RAND()') {
             // random selection
             $qb->addSelect('MOD(tbl.id, ' . mt_rand(2, 15) . ') AS HIDDEN randomIdentifiers')
-               ->add('orderBy', 'randomIdentifiers');
+                ->add('orderBy', 'randomIdentifiers');
     
             return $qb;
         }
@@ -626,12 +626,12 @@ 
         }
         if (false !== strpos($orderBy, 'tbl.createdBy')) {
             $qb->addSelect('tblCreator')
-               ->leftJoin('tbl.createdBy', 'tblCreator');
+                ->leftJoin('tbl.createdBy', 'tblCreator');
             $orderBy = str_replace('tbl.createdBy', 'tblCreator.uname', $orderBy);
         }
         if (false !== strpos($orderBy, 'tbl.updatedBy')) {
             $qb->addSelect('tblUpdater')
-               ->leftJoin('tbl.updatedBy', 'tblUpdater');
+                ->leftJoin('tbl.updatedBy', 'tblUpdater');
             $orderBy = str_replace('tbl.updatedBy', 'tblUpdater.uname', $orderBy);
         }
         $qb->add('orderBy', $orderBy);

Doc Comments +1 added lines, -1 removed lines

@@ -281,7 +281,7 @@
     /**
      * Selects an object from the database.
      *
-     * @param mixed   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
+     * @param integer   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
      * @param boolean $useJoins Whether to include joining related objects (optional) (default=true)
      * @param boolean $slimMode If activated only some basic fields are selected without using any joins (optional) (default=false)
      *

src/system/RoutesModule/Form/Handler/Route/Base/AbstractEditHandler.php

Unused Use Statements +2 added lines, -4 removed lines

@@ -12,13 +12,11 @@
 
 namespace Zikula\RoutesModule\Form\Handler\Route\Base;
 
+use RuntimeException;
+use Symfony\Component\HttpFoundation\RedirectResponse;
 use Zikula\RoutesModule\Form\Handler\Common\EditHandler;
 use Zikula\RoutesModule\Form\Type\RouteType;
 
-use Symfony\Component\HttpFoundation\RedirectResponse;
-use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-use RuntimeException;
-
 /**
  * This handler class handles the page events of editing forms.
  * It aims on the route object type.

src/system/RoutesModule/Listener/Base/AbstractUserListener.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,10 +16,10 @@
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Zikula\Common\Translator\TranslatorInterface;
 use Zikula\Core\Event\GenericEvent;
+use Zikula\RoutesModule\Entity\Factory\EntityFactory;
 use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\UsersModule\Constant as UsersConstant;
 use Zikula\UsersModule\UserEvents;
-use Zikula\RoutesModule\Entity\Factory\EntityFactory;
 
 /**
  * Event handler base class for user-related events.

src/system/RoutesModule/Menu/Base/AbstractItemActionsMenu.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -17,8 +17,8 @@
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
 use Symfony\Component\DependencyInjection\ContainerAwareTrait;
 use Zikula\Common\Translator\TranslatorTrait;
-use Zikula\UsersModule\Constant as UsersConstant;
 use Zikula\RoutesModule\Entity\RouteEntity;
+use Zikula\UsersModule\Constant as UsersConstant;
 
 /**
  * This is the item actions menu implementation class.

src/system/AdminModule/Helper/UpdateCheckHelper.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -211,7 +211,7 @@
                 return false;
             }
 
-            $out = "GET $path_query? HTTP/1.1\r\n";
+            $out = "get $path_query? HTTP/1.1\r\n";
             $out .= "User-Agent: $userAgent\r\n";
             $out .= "Referer: $ref\r\n";
             $out .= "Host: $urlArray[host]\r\n";

src/lib/Zikula/Core/Token/Validator.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             return false;
         }
 
-        list($id, , $timestamp) = $this->tokenGenerator->decode($token);
+        list($id,, $timestamp) = $this->tokenGenerator->decode($token);
         $decoded = [
             'id' => $id,
             'time' => $timestamp

src/system/MenuModule/Controller/NodeController.php

Braces +2 added lines, -1 removed lines

@@ -56,7 +56,8 @@
                         $parent = $repo->find($request->request->get('parent'));
                         $menuItemEntity->setParent($parent);
                         $menuItemEntity->setRoot($parent->getRoot());
-                    } elseif (empty($parentId) && $request->request->has('after')) { // sibling of top-level child
+                    } elseif (empty($parentId) && $request->request->has('after')) {
+// sibling of top-level child
                         $sibling = $repo->find($request->request->get('after'));
                         $menuItemEntity->setParent($sibling->getParent());
                         $menuItemEntity->setRoot($sibling->getRoot());

src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php

Indentation +6 added lines, -6 removed lines

@@ -173,14 +173,14 @@ 
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
-                           ->setParameter($k, substr($v, 1, strlen($v) - 1));
+                            ->setParameter($k, substr($v, 1, strlen($v) - 1));
                     } elseif (substr($v, 0, 1) == '%') {
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
-                           ->setParameter($k, '%' . $v . '%');
+                            ->setParameter($k, '%' . $v . '%');
                     } else {
                         $qb->andWhere('tbl.' . $k . ' = :' . $k)
-                           ->setParameter($k, $v);
-                   }
+                            ->setParameter($k, $v);
+                    }
                 }
             }
         }
@@ -289,10 +289,10 @@ 
     
         if (is_array($userId)) {
             $qb->andWhere('tbl.createdBy IN (:userIds)')
-               ->setParameter('userIds', $userId);
+                ->setParameter('userIds', $userId);
         } else {
             $qb->andWhere('tbl.createdBy = :userId')
-               ->setParameter('userId', $userId);
+                ->setParameter('userId', $userId);
         }
     
         return $qb;

Unused Use Statements -1 removed lines

@@ -17,7 +17,6 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\UsersModule\Constant as UsersConstant;
-use Zikula\RoutesModule\Entity\RouteEntity;
 
 /**
  * Entity collection filter helper base class.

src/lib/Zikula/Core/LinkContainer/LinkContainerCollector.php

Doc Comments +3 added lines

@@ -67,6 +67,9 @@
         return $links;
     }
 
+    /**
+     * @param string $containerName
+     */
     public function hasContainer($containerName)
     {
         return isset($this->linkContainers[$containerName]);