zikula / core

src/lib/Zikula/Bundle/HookBundle/Controller/HookController.php

Spacing +1 added lines, -1 removed lines

@@ -202,7 +202,7 @@
                 }
 
                 // does the user have admin permissions on the provider module?
-                if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($hookproviders[$i]['name']."::", '::', ACCESS_ADMIN)) {
+                if (!$this->get('zikula_permissions_module.api.permission')->hasPermission($hookproviders[$i]['name'] . "::", '::', ACCESS_ADMIN)) {
                     unset($hookproviders[$i]);
                     continue;
                 }

src/system/ExtensionsModule/Controller/ModuleController.php

Braces +2 added lines, -1 removed lines

@@ -278,7 +278,8 @@
             throw new AccessDeniedException();
         }
         $extensionHelper = $this->get('zikula_extensions_module.extension_helper');
-        if (!$this->get('kernel')->isBundle($extension->getName()) && !$extensionHelper->isLegacyModuleType($extension)) { // @deprecated method call
+        if (!$this->get('kernel')->isBundle($extension->getName()) && !$extensionHelper->isLegacyModuleType($extension)) {
+// @deprecated method call
             $this->get('zikula_extensions_module.extension_state_helper')->updateState($extension->getId(), Constant::STATE_TRANSITIONAL);
             $this->get('zikula.cache_clearer')->clear('symfony');
 

src/lib/Zikula/Bundle/CoreInstallerBundle/Helper/MigrationHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
 
     /**
      * @param $uid
-     * @param $limit
+     * @param integer $limit
      * @return array
      */
     private function getUnMigratedUsers($uid, $limit)

src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/UpgraderController.php

Spacing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
             $request->getSession()->getFlashBag()->add('warning', implode('<hr>', $ini_warnings));
         }
 
-        $yamlDumper = new YamlDumper($this->container->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
+        $yamlDumper = new YamlDumper($this->container->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
         $yamlDumper->setParameter('upgrading', true);
         $request->setLocale($this->container->getParameter('locale'));
 

Unused Use Statements +2 added lines, -2 removed lines

@@ -11,14 +11,14 @@
 
 namespace Zikula\Bundle\CoreInstallerBundle\Controller;
 
-use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaKernel;
 use Zikula\Bundle\CoreBundle\YamlDumper;
 use Zikula\Component\Wizard\FormHandlerInterface;
 use Zikula\Component\Wizard\Wizard;
 use Zikula\Component\Wizard\WizardCompleteInterface;
-use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaKernel;
 
 /**
  * Class UpgraderController

src/lib/Zikula/Bundle/CoreInstallerBundle/Controller/AjaxUpgradeController.php

Spacing +3 added lines, -3 removed lines

@@ -44,8 +44,8 @@ 
     public function __construct(ContainerInterface $container)
     {
         parent::__construct($container);
-        $originalParameters = Yaml::parse(file_get_contents($this->container->get('kernel')->getRootDir() .'/config/parameters.yml'));
-        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
+        $originalParameters = Yaml::parse(file_get_contents($this->container->get('kernel')->getRootDir() . '/config/parameters.yml'));
+        $this->yamlManager = new YamlDumper($this->container->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
         // load and set new default values from the original parameters.yml file into the custom_parameters.yml file.
         $this->yamlManager->setParameters(array_merge($originalParameters['parameters'], $this->yamlManager->getParameters()));
         $this->currentVersion = $this->container->getParameter(ZikulaKernel::CORE_INSTALLED_VERSION_PARAM);
@@ -56,7 +56,7 @@ 
         $stage = $request->request->get('stage');
         $this->yamlManager->setParameter('upgrading', true);
         $status = $this->executeStage($stage);
-        $response = ['status' => (bool) $status];
+        $response = ['status' => (bool)$status];
         if (is_array($status)) {
             $response['results'] = $status;
         }

src/lib/Zikula/Bundle/CoreInstallerBundle/Util/ZikulaRequirements.php

Spacing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
     public function runSymfonyChecks($parameters = [])
     {
         try {
-            $path = realpath(__DIR__.'/../../../../../var/SymfonyRequirements.php');
+            $path = realpath(__DIR__ . '/../../../../../var/SymfonyRequirements.php');
             require $path;
             $symfonyRequirements = new \SymfonyRequirements();
             $this->addZikulaPathRequirements($symfonyRequirements, $parameters);
@@ -44,8 +44,8 @@ 
         if ($requirement->isFulfilled()) {
             return;
         }
-        $errorMessage = wordwrap($requirement->getTestMessage(), $lineSize - 3, PHP_EOL.'   ').PHP_EOL;
-        $errorMessage .= '   > '.wordwrap($requirement->getHelpText(), $lineSize - 5, PHP_EOL.'   > ').PHP_EOL;
+        $errorMessage = wordwrap($requirement->getTestMessage(), $lineSize - 3, PHP_EOL . '   ') . PHP_EOL;
+        $errorMessage .= '   > ' . wordwrap($requirement->getHelpText(), $lineSize - 5, PHP_EOL . '   > ') . PHP_EOL;
 
         return $errorMessage;
     }
@@ -66,7 +66,7 @@ 
         $symfonyRequirements->addRequirement(
             is_writable($src . '/' . $parameters['datadir']),
             $parameters['datadir'] . '/ directory must be writable',
-            'Change the permissions of "<strong>' . $parameters['datadir']. '</strong>" directory so that the web server can write into it.'
+            'Change the permissions of "<strong>' . $parameters['datadir'] . '</strong>" directory so that the web server can write into it.'
         );
         $customParametersPath = $src . '/app/config/custom_parameters.yml';
         if (file_exists($customParametersPath)) {

src/lib/Zikula/Bundle/CoreInstallerBundle/Command/UpgradeCommand.php

Spacing +2 added lines, -2 removed lines

@@ -97,7 +97,7 @@ 
         $count = $migrationHelper->countUnMigratedUsers();
         if ($count > 0) {
             $io->text($this->translator->__('Beginning user migration...'));
-            $userMigrationMaxuid = (int) $migrationHelper->getMaxUnMigratedUid();
+            $userMigrationMaxuid = (int)$migrationHelper->getMaxUnMigratedUid();
             $progressBar = new ProgressBar($output, ceil($count / MigrationHelper::BATCH_LIMIT));
             $progressBar->start();
             $lastUid = 0;
@@ -133,7 +133,7 @@ 
         $io->newLine();
 
         // write the parameters to custom_parameters.yml
-        $yamlManager = new YamlDumper($this->getContainer()->get('kernel')->getRootDir() .'/config', 'custom_parameters.yml');
+        $yamlManager = new YamlDumper($this->getContainer()->get('kernel')->getRootDir() . '/config', 'custom_parameters.yml');
         $params = array_merge($yamlManager->getParameters(), $settings);
         unset($params['upgrading']);
         $yamlManager->setParameters($params);

src/lib/Zikula/Bundle/CoreBundle/Bundle/Bootstrap.php

Doc Comments +1 added lines, -1 removed lines

@@ -89,7 +89,7 @@
      * @param string $class
      * @param string $type
      *
-     * @return bool
+     * @return boolean|null
      */
     private function extensionIsActive(Connection $conn, $class, $type)
     {

src/system/UsersModule/Form/Type/ConfigType/ConfigType.php

Spacing +2 added lines, -2 removed lines

@@ -139,7 +139,7 @@ 
                 'constraints' => [
                     new Type('string'),
                     new Regex([
-                        'pattern' => '/^(?:'. UsersConstant::UNAME_VALIDATION_PATTERN .'(?:\s*,\s*'. UsersConstant::UNAME_VALIDATION_PATTERN .')*)?$/uD',
+                        'pattern' => '/^(?:' . UsersConstant::UNAME_VALIDATION_PATTERN . '(?:\s*,\s*' . UsersConstant::UNAME_VALIDATION_PATTERN . ')*)?$/uD',
                         'message' => $options['translator']->__('The value provided does not appear to be a valid list of user names. The list should consist of one or more user names made up of lowercase letters, numbers, underscores, periods, or dashes. Separate each user name with a comma. For example: \'root, administrator, superuser\' (the quotes should not appear in the list). Spaces surrounding commas are ignored, however extra spaces before or after the list are not and will result in an error. Empty values (two commas together, or separated only by spaces) are not allowed. The list is optional, and if no values are to be defined then the list should be completely empty (no extra spaces, commas, or any other characters).')
                     ])
                 ]
@@ -166,7 +166,7 @@ 
                 'constraints' => [
                     new Type('string'),
                     new Regex([
-                        'pattern' => '/^(?:'. UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN .'(?:\s*,\s*'. UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN .')*)?$/Ui',
+                        'pattern' => '/^(?:' . UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN . '(?:\s*,\s*' . UsersConstant::EMAIL_DOMAIN_VALIDATION_PATTERN . ')*)?$/Ui',
                         'message' => $options['translator']->__('The contents of this field does not appear to be a valid list of e-mail address domains. The list should consist of one or more e-mail address domains (the part after the \'@\'), separated by commas. For example: \'gmail.com, example.org, acme.co.uk\' (the quotes should not appear in the list). Do not include the \'@\' itself. Spaces surrounding commas are ignored, however extra spaces before or after the list are not and will result in an error. Empty values (two commas together, or separated only by spaces) are not allowed. The list is optional, and if no values are to be defined then the list should be completely empty (no extra spaces, commas, or any other characters).')
                     ])
                 ]