zikula / core

src/lib/Zikula/Core/AbstractExtensionInstaller.php

Doc Comments +2 added lines, -2 removed lines

@@ -112,8 +112,8 @@
 
     /**
      * Convenience shortcut to add a session flash message.
-     * @param $type
-     * @param $message
+     * @param string $type
+     * @param string $message
      */
     public function addFlash($type, $message)
     {

src/lib/Zikula/Core/FilterUtil/CategoryPlugin.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
     /**
      * Returns the operators the plugin can handle.
      *
-     * @return array Operators
+     * @return string[] Operators
      */
     public function availableOperators()
     {

Spacing +7 added lines, -7 removed lines

@@ -69,9 +69,9 @@ 
         $config = $this->config;
         $alias = $config->getAlias();
         $qb = $config->getQueryBuilder();
-        $qb->join($alias.'.categories', $alias.'_cat_plugin')->join(
-            $alias.'_cat_plugin.category',
-            $alias.'_cat_plugin_category'
+        $qb->join($alias . '.categories', $alias . '_cat_plugin')->join(
+            $alias . '_cat_plugin.category',
+            $alias . '_cat_plugin_category'
         );
     }
 
@@ -85,7 +85,7 @@ 
         if (empty($property)) {
             $this->property = null;
         } else {
-            $this->property = (array) $property;
+            $this->property = (array)$property;
         }
     }
 
@@ -131,10 +131,10 @@ 
         $alias = $config->getAlias();
         $expr = $config->getQueryBuilder()->expr();
         if ($op == 'sub' || is_numeric($value)) {
-            $column = $alias.'_cat_plugin_category.id';
+            $column = $alias . '_cat_plugin_category.id';
             $prop = 'id';
         } else {
-            $column = $alias.'_cat_plugin_category.name';
+            $column = $alias . '_cat_plugin_category.name';
             $prop = 'name';
         }
         $con = null;
@@ -158,7 +158,7 @@ 
         }
         if (null !== $this->modname && null !== $this->property) {
             $propertyCon = $expr->in(
-                $alias.'_cat_plugin.categoryRegistryId',
+                $alias . '_cat_plugin.categoryRegistryId',
                 $config->toParam($this->getRegistryIds(), 'category', $field)
             );
             if (null !== $con) {

src/lib/Zikula/Core/LinkContainer/LinkContainerCollector.php

Doc Comments +4 added lines

@@ -31,6 +31,10 @@
         $this->linkContainers[$linkContainer->getBundleName()] = $linkContainer;
     }
 
+    /**
+     * @param string $containerName
+     * @param string $type
+     */
     public function getLinks($containerName, $type = LinkContainerInterface::TYPE_ADMIN)
     {
         $links = [];

src/system/ExtensionsModule/ExtensionsModuleInstaller.php

Doc Comments +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      * This function must consider all the released versions of the module!
      * If the upgrade fails at some point, it returns the last upgraded version.
      *
-     * @param string $oldversion Version number string to upgrade from
+     * @param string $oldVersion Version number string to upgrade from
      *
      * @return  boolean|string True on success, last valid version string or false if fails
      */

src/system/RoutesModule/Twig/TwigExtension.php

Doc Comments -1 removed lines

@@ -49,7 +49,6 @@
      * Example:
      *    {{ route.defaults|zikularoutesmodule_arrayToString }}
      *
-     * @param array $array The input array.
      *
      * @return string Output string for display.
      */

Spacing +2 added lines, -2 removed lines

@@ -106,13 +106,13 @@
         $path = htmlspecialchars($route->getPathWithBundlePrefix());
         $container = $this->container;
 
-        $path = preg_replace_callback('#%(.*?)%#', function ($matches) use ($container) {
+        $path = preg_replace_callback('#%(.*?)%#', function($matches) use ($container) {
             return '<abbr title="' . htmlspecialchars($matches[0]) . '">' . htmlspecialchars($container->getParameter($matches[1])) . '</abbr>';
         }, $path);
 
         $defaults = $route->getDefaults();
         $requirements = $route->getRequirements();
-        $path = preg_replace_callback('#{(.*?)}#', function ($matches) use ($defaults, $requirements) {
+        $path = preg_replace_callback('#{(.*?)}#', function($matches) use ($defaults, $requirements) {
             $title = '';
             if (isset($defaults[$matches[1]])) {
                 $title .= $this->__f('Default: %s', ['%s' => htmlspecialchars($defaults[$matches[1]])]);

src/system/SecurityCenterModule/SecurityCenterModuleInstaller.php

Doc Comments +3 added lines

@@ -251,6 +251,9 @@
         return false;
     }
 
+    /**
+     * @param string $name
+     */
     private function setSystemVar($name, $value = '')
     {
         return $this->container->get('zikula_extensions_module.api.variable')->set(VariableApi::CONFIG, $name, $value);

Spacing +8 added lines, -8 removed lines

@@ -55,7 +55,7 @@ 
         $this->setSystemVar('sessionstoretofile', Constant::SESSION_STORAGE_FILE);
         $this->setSystemVar('sessionsavepath', '');
         $this->setSystemVar('gc_probability', 100);
-        $this->setSystemVar('sessioncsrftokenonetime', 1);  // 1 means use same token for entire session
+        $this->setSystemVar('sessioncsrftokenonetime', 1); // 1 means use same token for entire session
         $this->setSystemVar('sessionrandregenerate', 1);
         $this->setSystemVar('sessionregenerate', 1);
         $this->setSystemVar('sessionregeneratefreq', 10);
@@ -77,13 +77,13 @@ 
         $this->setSystemVar('useids', 0);
         $this->setSystemVar('idsmail', 0);
         $this->setSystemVar('idsrulepath', 'system/SecurityCenterModule/Resources/config/phpids_zikula_default.xml');
-        $this->setSystemVar('idssoftblock', 1);                // do not block requests, but warn for debugging
-        $this->setSystemVar('idsfilter', 'xml');               // filter type
-        $this->setSystemVar('idsimpactthresholdone', 1);       // db logging
-        $this->setSystemVar('idsimpactthresholdtwo', 10);      // mail admin
-        $this->setSystemVar('idsimpactthresholdthree', 25);    // block request
-        $this->setSystemVar('idsimpactthresholdfour', 75);     // kick user, destroy session
-        $this->setSystemVar('idsimpactmode', 1);               // per request per default
+        $this->setSystemVar('idssoftblock', 1); // do not block requests, but warn for debugging
+        $this->setSystemVar('idsfilter', 'xml'); // filter type
+        $this->setSystemVar('idsimpactthresholdone', 1); // db logging
+        $this->setSystemVar('idsimpactthresholdtwo', 10); // mail admin
+        $this->setSystemVar('idsimpactthresholdthree', 25); // block request
+        $this->setSystemVar('idsimpactthresholdfour', 75); // kick user, destroy session
+        $this->setSystemVar('idsimpactmode', 1); // per request per default
         $this->setSystemVar('idshtmlfields', ['POST.__wysiwyg']);
         $this->setSystemVar('idsjsonfields', ['POST.__jsondata']);
         $this->setSystemVar('idsexceptions', [

src/system/ThemeModule/Engine/Asset/Merger.php

Doc Comments +1 added lines, -1 removed lines

@@ -284,7 +284,7 @@
 
     /**
      * Remove comments, whitespace and spaces from css files
-     * @param $contents
+     * @param string $contents
      * @return string
      */
     private function minify($contents)

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
                 }
             }
         }
-        $cacheName = in_array($type, ['js', 'css']) ? "{$type}Cache" : null;
+        $cacheName = in_array($type, ['js', 'css']) ? "{$type}cache" : null;
         /** @var CacheProvider $cacheService */
         $cacheService = $this->$cacheName;
         $key = md5(serialize($assets)) . (int)$this->minify . (int)$this->compress . $this->lifetime . '.' . $type;

src/system/UsersModule/Collector/AuthenticationMethodCollector.php

Doc Comments +2 added lines, -2 removed lines

@@ -91,7 +91,7 @@ 
     }
 
     /**
-     * @return array of service aliases
+     * @return integer[] of service aliases
      */
     public function getKeys()
     {
@@ -99,7 +99,7 @@ 
     }
 
     /**
-     * @return array of active service aliases
+     * @return integer[] of active service aliases
      */
     public function getActiveKeys()
     {

src/system/UsersModule/Helper/MailHelper.php

Doc Comments +3 added lines

@@ -262,6 +262,9 @@
         return $this->mailerApi->sendMessage($message, null, null, $textBody, $html);
     }
 
+    /**
+     * @param string $notificationType
+     */
     private function generateEmailSubject($notificationType, array $templateArgs = [])
     {
         $siteName = $this->variableApi->getSystemVar('sitename');