SearchApi::search() - Code Metrics - Inspection of "Merge remote-tracking branch 'origin/1.4'" - zikula/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd3b2e...50c111 )

by Craig

created 2017-02-19 13:28 UTC

SearchApi::search() C

↳ Parent: SearchApi

Complexity

Conditions	12
Paths	48

Size

Total Lines	43
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	26
nc	48
nop	7
dl	0
loc	43
rs	5.1612
c	0
b	0
f	0

How to fix Complexity

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\SearchModule\Api;

use Symfony\Component\HttpFoundation\Session\SessionInterface;
use Zikula\ExtensionsModule\Api\VariableApi;
use Zikula\SearchModule\Api\ApiInterface\SearchApiInterface;
use Zikula\SearchModule\Collector\SearchableModuleCollector;
use Zikula\SearchModule\Entity\RepositoryInterface\SearchResultRepositoryInterface;
use Zikula\SearchModule\Entity\RepositoryInterface\SearchStatRepositoryInterface;
use Zikula\SearchModule\Entity\SearchStatEntity;

class SearchApi implements SearchApiInterface
{
    /**
     * @var VariableApi
     */
    protected $variableApi;

    /**
     * @var SearchResultRepositoryInterface
     */
    protected $searchResultRepository;

    /**
     * @var SearchStatRepositoryInterface
     */
    protected $searchStatRepository;

    /**
     * @var SessionInterface
     */
    protected $session;

    /**
     * @var SearchableModuleCollector
     */
    protected $searchableModuleCollector;

    /**
     * SearchApi constructor.
     * @param VariableApi $variableApi
     * @param SearchResultRepositoryInterface $searchResultRepository
     * @param SearchStatRepositoryInterface $searchStatRepository
     * @param SessionInterface $session
     * @param SearchableModuleCollector $searchableModuleCollector
     */
    public function __construct(
        VariableApi $variableApi,
        SearchResultRepositoryInterface $searchResultRepository,
        SearchStatRepositoryInterface $searchStatRepository,
        SessionInterface $session,
        SearchableModuleCollector $searchableModuleCollector
    ) {
        $this->variableApi = $variableApi;
        $this->searchResultRepository = $searchResultRepository;
        $this->searchStatRepository = $searchStatRepository;
        $this->session = $session;
        $this->searchableModuleCollector = $searchableModuleCollector;
    }

    /**
     * {@inheritdoc}
     */
    public function search($q, $firstPage = false, $searchType = 'AND', $searchOrder = 'newest', $limit = -1, $page = 1, array $moduleData = [])
    {
        $limit = isset($limit) && !empty($limit) ? $limit : $this->variableApi->get('ZikulaSearchModule', 'itemsperpage', 25);
        $offset = $limit > 0 ? (($page - 1) * $limit) : 0;

        // obtain and persist search results from searchableModules
        if ($firstPage) {
            // Clear current search result for current user - before showing the first page
            // Clear also older searches from other users.
            $this->searchResultRepository->clearOldResults($this->session->getId());
            // convert query string to an *array* of words
            $words = ($searchType == 'EXACT') ? [trim($q)] : preg_split('/ /', $q, -1, PREG_SPLIT_NO_EMPTY);
            $searchableModules = $this->searchableModuleCollector->getAll();
            foreach ($searchableModules as $moduleName => $searchableInstance) {
                if (isset($moduleData['active']) && !$moduleData['active']) {
                    continue;
                }
                $moduleFormData = isset($moduleData[$moduleName]) ? $moduleData[$moduleName] : null;
                $results = $searchableInstance->getResults($words, $searchType, $moduleFormData);
                foreach ($results as $searchResult) {
                    $this->searchResultRepository->persist($searchResult);
                }
            }
            $this->searchResultRepository->flush();

            $resultCount = $this->searchResultRepository->countResults($this->session->getId());
            $this->session->set('searchResultCount', $resultCount);
        } else {
            $resultCount = $this->session->get('searchResultCount');
        }

        $results = $this->searchResultRepository->getResults(['sesid' => $this->session->getId()], $this->computeSort($searchOrder), $limit, $offset);

        $result = [
            'count' => $resultCount,
            'results' => $results,
        ];
        if (isset($searchableInstance)) {
            $result['errors'] = $searchableInstance->getErrors();
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    public function log($q = null)
    {
        if (!isset($q)) {
            return;
        }

        $obj = $this->searchStatRepository->findOneBy(['search' => $q]);
        if (!$obj) {
            $obj = new SearchStatEntity();
        }
        $obj->incrementCount();
        $obj->setSearch($q);
        $obj->setDate(new \DateTime('now', new \DateTimeZone('UTC')));
        $this->searchStatRepository->persistAndFlush($obj);
    }

    private function computeSort($searchOrder)
    {
        switch ($searchOrder) {
            case 'oldest':
                return ['created' => 'ASC'];
            case 'newest':
                return ['created' => 'DESC'];
            case 'alphabetical':
            default:
                return ['title' => 'ASC'];
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Zikula package.
5			*
6			* Copyright Zikula Foundation - http://zikula.org/
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Zikula\SearchModule\Api;
13
14			use Symfony\Component\HttpFoundation\Session\SessionInterface;
15			use Zikula\ExtensionsModule\Api\VariableApi;
16			use Zikula\SearchModule\Api\ApiInterface\SearchApiInterface;
17			use Zikula\SearchModule\Collector\SearchableModuleCollector;
18			use Zikula\SearchModule\Entity\RepositoryInterface\SearchResultRepositoryInterface;
19			use Zikula\SearchModule\Entity\RepositoryInterface\SearchStatRepositoryInterface;
20			use Zikula\SearchModule\Entity\SearchStatEntity;
21
22			class SearchApi implements SearchApiInterface
23			{
24			/**
25			* @var VariableApi
26			*/
27			protected $variableApi;
28
29			/**
30			* @var SearchResultRepositoryInterface
31			*/
32			protected $searchResultRepository;
33
34			/**
35			* @var SearchStatRepositoryInterface
36			*/
37			protected $searchStatRepository;
38
39			/**
40			* @var SessionInterface
41			*/
42			protected $session;
43
44			/**
45			* @var SearchableModuleCollector
46			*/
47			protected $searchableModuleCollector;
48
49			/**
50			* SearchApi constructor.
51			* @param VariableApi $variableApi
52			* @param SearchResultRepositoryInterface $searchResultRepository
53			* @param SearchStatRepositoryInterface $searchStatRepository
54			* @param SessionInterface $session
55			* @param SearchableModuleCollector $searchableModuleCollector
56			*/
57			public function __construct(
58			VariableApi $variableApi,
59			SearchResultRepositoryInterface $searchResultRepository,
60			SearchStatRepositoryInterface $searchStatRepository,
61			SessionInterface $session,
62			SearchableModuleCollector $searchableModuleCollector
63			) {
64			$this->variableApi = $variableApi;
65			$this->searchResultRepository = $searchResultRepository;
66			$this->searchStatRepository = $searchStatRepository;
67			$this->session = $session;
68			$this->searchableModuleCollector = $searchableModuleCollector;
69			}
70
71			/**
72			* {@inheritdoc}
73			*/
74			public function search($q, $firstPage = false, $searchType = 'AND', $searchOrder = 'newest', $limit = -1, $page = 1, array $moduleData = [])
75			{
76			$limit = isset($limit) && !empty($limit) ? $limit : $this->variableApi->get('ZikulaSearchModule', 'itemsperpage', 25);
77			$offset = $limit > 0 ? (($page - 1) * $limit) : 0;
78
79			// obtain and persist search results from searchableModules
80			if ($firstPage) {
81			// Clear current search result for current user - before showing the first page
82			// Clear also older searches from other users.
83			$this->searchResultRepository->clearOldResults($this->session->getId());
84			// convert query string to an array of words
85			$words = ($searchType == 'EXACT') ? [trim($q)] : preg_split('/ /', $q, -1, PREG_SPLIT_NO_EMPTY);
86			$searchableModules = $this->searchableModuleCollector->getAll();
87			foreach ($searchableModules as $moduleName => $searchableInstance) {
88			if (isset($moduleData['active']) && !$moduleData['active']) {
89			continue;
90			}
91			$moduleFormData = isset($moduleData[$moduleName]) ? $moduleData[$moduleName] : null;
92			$results = $searchableInstance->getResults($words, $searchType, $moduleFormData);
93			foreach ($results as $searchResult) {
94			$this->searchResultRepository->persist($searchResult);
95			}
96			}
97			$this->searchResultRepository->flush();
98
99			$resultCount = $this->searchResultRepository->countResults($this->session->getId());
100			$this->session->set('searchResultCount', $resultCount);
101			} else {
102			$resultCount = $this->session->get('searchResultCount');
103			}
104
105			$results = $this->searchResultRepository->getResults(['sesid' => $this->session->getId()], $this->computeSort($searchOrder), $limit, $offset);
106
107			$result = [
108			'count' => $resultCount,
109			'results' => $results,
110			];
111			if (isset($searchableInstance)) {
112			$result['errors'] = $searchableInstance->getErrors();
113			}
114
115			return $result;
116			}
117
118			/**
119			* {@inheritdoc}
120			*/
121			public function log($q = null)
122			{
123			if (!isset($q)) {
124			return;
125			}
126
127			$obj = $this->searchStatRepository->findOneBy(['search' => $q]);
128			if (!$obj) {
129			$obj = new SearchStatEntity();
130			}
131			$obj->incrementCount();
132			$obj->setSearch($q);
133			$obj->setDate(new \DateTime('now', new \DateTimeZone('UTC')));
134			$this->searchStatRepository->persistAndFlush($obj);
135			}
136
137			private function computeSort($searchOrder)
138			{
139			switch ($searchOrder) {
140			case 'oldest':
141			return ['created' => 'ASC'];
142			case 'newest':
143			return ['created' => 'DESC'];
144			case 'alphabetical':
145			default:
146			return ['title' => 'ASC'];
147			}
148			}
149			}
150

zikula / core

Push — master ( cd3b2e...50c111 )

SearchApi::search() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like