Zikula\RoutesModule\Controller\UpdateController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	105
Duplicated Lines	8.57 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	reloadAction()	3	17	2
A	renewAction()	3	14	2
A	dumpJsRoutesAction()	3	11	2
A	dumpJsRoutes()	0	11	2

<?php
/**
 * Routes.
 *
 * @copyright Zikula contributors (Zikula)
 * @license http://www.gnu.org/licenses/lgpl.html GNU Lesser General Public License
 * @author Zikula contributors <support@zikula.org>.
 * @link http://www.zikula.org
 * @link http://zikula.org
 * @version Generated by ModuleStudio 0.7.1 (http://modulestudio.de).
 */

namespace Zikula\RoutesModule\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Zikula\Core\Controller\AbstractController;
use Zikula\ThemeModule\Engine\Annotation\Theme;

/**
 * Update controller for renewing route information on demand.
 */
class UpdateController extends AbstractController
{
    /**
     * Reloads the routes and dumps exposed JS routes.
     *
     * @Route("/update/reload",
     *        methods = {"GET", "POST"}
     * )
     * @Theme("admin")
     *
     * @param Request $request Current request instance
     *
     * @return Response Output
     *
     * @throws AccessDeniedException Thrown if the user doesn't have required permissions
     */
    public function reloadAction(Request $request)

The parameter $request is not used and could be removed.

    {
        $objectType = 'route';
        if (!$this->hasPermission('ZikulaRoutesModule:' . ucfirst($objectType) . ':', '::', ACCESS_ADMIN)) {

This code seems to be duplicated across your project.

            throw new AccessDeniedException();
        }

        $cacheClearer = $this->get('zikula.cache_clearer');
        $cacheClearer->clear('symfony.routing');

        $this->addFlash('status', $this->__('Done! Routes reloaded.'));

        // reload **all** JS routes
        $this->dumpJsRoutes($lang);

The variable $lang does not exist. Did you forget to declare it?

        return $this->redirectToRoute('zikularoutesmodule_route_adminview');
    }

    /**
     * Renews multilingual routing settings.
     *
     * @Route("/update/renew",
     *        methods = {"GET", "POST"}
     * )
     * @Theme("admin")
     *
     * @param Request $request Current request instance
     *
     * @return Response Output
     *
     * @throws AccessDeniedException Thrown if the user doesn't have required permissions
     */
    public function renewAction(Request $request)

The parameter $request is not used and could be removed.

    {
        $objectType = 'route';
        if (!$this->hasPermission('ZikulaRoutesModule:' . ucfirst($objectType) . ':', '::', ACCESS_ADMIN)) {

This code seems to be duplicated across your project.

            throw new AccessDeniedException();
        }

        // Renew the routing settings.
        $this->get('zikula_routes_module.multilingual_routing_helper')->reloadMultilingualRoutingSettings();

        $this->addFlash('status', $this->__('Done! Routing settings renewed.'));

        return $this->redirectToRoute('zikularoutesmodule_route_adminview');
    }

    /**
     * Dumps the routes exposed to javascript.
     *
     * @Route("/update/dump/{lang}",
     *        name = "zikularoutesmodule_update_dumpjsroutes",
     *        methods = {"GET"}
     * )
     * @Theme("admin")
     *
     * @param Request $request Current request instance
     *
     * @return Response Output
     *
     * @throws AccessDeniedException Thrown if the user doesn't have required permissions
     */
    public function dumpJsRoutesAction(Request $request, $lang = null)

The parameter $request is not used and could be removed.

    {
        $objectType = 'route';
        if (!$this->hasPermission('ZikulaRoutesModule:' . ucfirst($objectType) . ':', '::', ACCESS_ADMIN)) {

This code seems to be duplicated across your project.

            throw new AccessDeniedException();
        }

        $this->dumpJsRoutes($lang);

        return $this->redirectToRoute('zikularoutesmodule_route_adminview');
    }

    /**
     * Dumps exposed JS routes to '/web/js/fos_js_routes.js'.
     */
    private function dumpJsRoutes($lang = null)
    {
        $routeDumperHelper = $this->get('zikula_routes_module.route_dumper_helper');
        $result = $routeDumperHelper->dumpJsRoutes($lang);

        if ($result == '') {
            $this->addFlash('status', $this->__f('Done! Exposed JS Routes dumped to %s.', ['%s' => 'web/js/fos_js_routes.js']));
        } else {
            $this->addFlash('error', $this->__f('Error! There was an error dumping exposed JS Routes: %s', ['%s' => $result]));
        }
    }
}