Zikula\PermissionsModule\Api\PermissionAlwaysApi

Complexity

Total Complexity

7

Size/Duplication

Total Lines	45
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	hasPermission()	0	4	1
B	accessLevelNames()	5	23	5
A	resetPermissionsForUser()	0	4	1

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\PermissionsModule\Api;

use Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface;

/**
 * Class PermissionAlwaysApi
 *
 * This class exists for testing and to ensure a functional Api is provided in a default situation.
 * ALL hasPermission tests return TRUE regardless of settings.
 * Access level names are returned untranslated.
 * Permissions cannot be reset for a user.
 */
class PermissionAlwaysApi implements PermissionApiInterface
{
    /**
     * {@inheritdoc}
     */
    public function hasPermission($component = null, $instance = null, $level = ACCESS_NONE, $user = null)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function accessLevelNames($level = null)
    {
        if (isset($level) && !is_numeric($level)) {

This code seems to be duplicated across your project.

            throw new \InvalidArgumentException();
        } elseif (isset($level)) {
            $level = intval($level);
        }

        $accessNames = [
            ACCESS_INVALID => 'Invalid',
            ACCESS_NONE => 'No access',
            ACCESS_OVERVIEW => 'Overview access',
            ACCESS_READ => 'Read access',
            ACCESS_COMMENT => 'Comment access',
            ACCESS_MODERATE => 'Moderate access',
            ACCESS_EDIT => 'Edit access',
            ACCESS_ADD => 'Add access',
            ACCESS_DELETE => 'Delete access',
            ACCESS_ADMIN => 'Admin access',
        ];

        return isset($level) ? $accessNames[$level] : $accessNames;

The expression isset($level) ? $accessNames[$level] : $accessNames; of type string|string[] adds the type string[] to the return on line 58 which is incompatible with the return type declared by the interface Zikula\PermissionsModule\Api\ApiInterface\PermissionApiInterface::accessLevelNames of type string.

    }

    /**
     * {@inheritdoc}
     */
    public function resetPermissionsForUser($uid)
    {
        // nothing to do
    }
}