Zikula\ExtensionsModule\Api\CapabilityApi

Complexity

Total Complexity

12

Size/Duplication

Total Lines	80
Duplicated Lines	7.5 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	0	11	3
A	getExtensionsCapableOf()	0	8	3
A	isCapable()	3	11	3
A	getCapabilitiesOf()	3	8	2

<?php

/*
 * This file is part of the Zikula package.
 *
 * Copyright Zikula Foundation - http://zikula.org/
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Zikula\ExtensionsModule\Api;

use Zikula\ExtensionsModule\Api\ApiInterface\CapabilityApiInterface;
use Zikula\ExtensionsModule\Constant;
use Zikula\ExtensionsModule\Entity\ExtensionEntity;
use Zikula\ExtensionsModule\Entity\Repository\ExtensionRepository;
use Zikula\ExtensionsModule\Entity\RepositoryInterface\ExtensionRepositoryInterface;

/**
 * Class CapabilityApi
 */
class CapabilityApi implements CapabilityApiInterface
{
    /**
     * @var ExtensionRepository
     */
    private $extensionRepository;

    /**
     * @var ExtensionEntity[]
     */
    private $extensionsByCapability = [];

    /**
     * @var ExtensionEntity[]
     */
    private $extensionsByName = [];

    /**
     * Capability constructor.
     * @param ExtensionRepositoryInterface $extensionRepository
     */
    public function __construct(ExtensionRepositoryInterface $extensionRepository)
    {
        $this->extensionRepository = $extensionRepository;
    }

    /**
     * Load extensions into private property cache.
     */
    private function load()
    {
        $extensions = $this->extensionRepository->findBy(['state' => Constant::STATE_ACTIVE]);
        /** @var ExtensionEntity $extension */
        foreach ($extensions as $extension) {
            foreach ($extension->getCapabilities() as $capability => $definition) {
                $this->extensionsByCapability[$capability][] = $extension;
            }
            $this->extensionsByName[$extension->getName()] = $extension;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getExtensionsCapableOf($capability)
    {
        if (empty($this->extensionsByCapability[$capability])) {
            $this->load();
        }

        return !empty($this->extensionsByCapability[$capability]) ? $this->extensionsByCapability[$capability] : [];

The expression !empty($this->extensionsByCapability[$capability]) ? $this->extensionsByCapability[$capability] : array(); of type Zikula\ExtensionsModule\Entity\ExtensionEntity|array adds the type Zikula\ExtensionsModule\Entity\ExtensionEntity to the return on line 73 which is incompatible with the return type declared by the interface Zikula\ExtensionsModule\Api\ApiInterface\CapabilityApiInterface::getExtensionsCapableOf of type Zikula\ExtensionsModule\Entity\ExtensionEntity[].

    }

    /**
     * {@inheritdoc}
     */
    public function isCapable($extensionName, $requestedCapability)
    {
        if (empty($this->extensionsByName[$extensionName])) {

This code seems to be duplicated across your project.

            $this->extensionsByName[$extensionName] = $this->extensionRepository->findOneBy(['name' => $extensionName]);
        }
        $capabilities = $this->extensionsByName[$extensionName]->getCapabilities();

        return array_key_exists($requestedCapability, $capabilities)
            ? $capabilities[$requestedCapability]
            : false;
    }

    /**
     * {@inheritdoc}
     */
    public function getCapabilitiesOf($extensionName)
    {
        if (empty($this->extensionsByName[$extensionName])) {

This code seems to be duplicated across your project.

            $this->extensionsByName[$extensionName] = $this->extensionRepository->findOneBy(['name' => $extensionName]);
        }

        return $this->extensionsByName[$extensionName]->getCapabilities();
    }
}