View GitHub Repository core

Schedule Inspection
Subscribe
Completed
Push — master ( 4f7975...d986ec )
by Craig
09:18 queued 04:21
created
Status
Category
Toggle Patches
src/Zikula/CoreInstallerBundle/Stage/Install/CompleteStage.php 1 patch
Upper-Lower-Casing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -94,11 +94,11 @@
 
 block discarded – undo
94 94 
     <title>${subject}</title>
95 95 
 </head>
96 96 
 <body>
97 
-<h1>Hi ${uName}!</h1>
97 
+<h1>Hi ${uname}!</h1>
98 98 
 <p>Zikula has been successfully installed at <a href="${url}">${url}</a>. If you have further questions,
99 99 
 visit <a href="https://ziku.la">ziku.la</a></p>
100 100 
 </body>
101 
-EOF;
101 
+eof;
102 102 
         $email = (new Email())
103 103 
             ->from($adminUser->getEmail())
104 104 
             ->to($adminUser->getEmail())
Please login to merge, or discard this patch.
src/system/ZAuthModule/Listener/DeletePendingRegistrationsListener.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -100,7 +100,7 @@
 
 block discarded – undo
100 100 
 Your registration at %site% associated with this email (%email%) has been deleted from the site.
101 101 
 This could have happened because you have delayed too long in confirming your email address, or because the administrator manually deleted your registration.
102 102 
 If you have any questions, please contact the site administrator or re-register.
103 
-EOT
103 
+eot
104 104 
         , ['%site' => $siteName, '%email%' => $event->getUser()->getEmail()]));
105 105 
         try {
106 106 
             $this->mailer->send($email);
Please login to merge, or discard this patch.
src/system/ZAuthModule/Command/ZikulaZauthEditCommand.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -90,7 +90,7 @@
 
 block discarded – undo
90 90
91 91 
 <info>php %command.full_name% fabien</info>
92 92
93 
-EOT
93 
+eot
94 94 
             );
95 95 
     }
96 96
Please login to merge, or discard this patch.
src/system/SearchModule/Entity/Repository/SearchResultRepository.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -41,7 +41,7 @@  discard block
 
 block discarded – undo
41 41 
             $i = 1;
42 42 
             foreach ($filters as $w_key => $w_value) {
43 43 
                 $qb->andWhere($qb->expr()->eq('tbl.' . $w_key, '?' . $i))
44 
-                   ->setParameter($i, $w_value);
44 
+                    ->setParameter($i, $w_value);
45 45 
                 $i++;
46 46 
             }
47 47 
         }
 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64
65 65 
         if ('' !== $sessionId) {
66 66 
             $qb->orWhere('tbl.sesid = :sid')
67 
-               ->setParameter('sid', $sessionId);
67 
+                ->setParameter('sid', $sessionId);
68 68 
         }
69 69
70 70 
         $query = $qb->getQuery();
Please login to merge, or discard this patch.
src/system/SecurityCenterModule/Entity/Repository/IntrusionRepository.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
                 $qb->from('ZikulaUsersModule:UserEntity', 'u');
76 76 
                 $qb->andWhere($qb->expr()->eq('tbl.user', 'u.uid'));
77 77 
                 $qb->andWhere($qb->expr()->eq('tbl.user', ':uid'))
78 
-                   ->setParameter('uid', $uid);
78 
+                    ->setParameter('uid', $uid);
79 79 
             }
80 80 
         }
81 81 
 
@@ -84,7 +84,7 @@  discard block
 
 block discarded – undo
84 84 
             $i = 1;
85 85 
             foreach ($filters as $w_key => $w_value) {
86 86 
                 $qb->andWhere($qb->expr()->eq('tbl.' . $w_key, '?' . $i))
87 
-                   ->setParameter($i, $w_value);
87 
+                    ->setParameter($i, $w_value);
88 88 
                 $i++;
89 89 
             }
90 90 
         }
 
@@ -107,12 +107,12 @@  discard block
 
 block discarded – undo
107 107
108 108 
         if ('uid' === $fieldName) {
109 109 
             $qb->select('DISTINCT(u.uname)')
110 
-               ->from('ZikulaUsersModule:UserEntity', 'u')
111 
-               ->where($qb->expr()->eq('tbl.user', 'u.uid'))
112 
-               ->addOrderBy('u.uname', 'ASC');
110 
+                ->from('ZikulaUsersModule:UserEntity', 'u')
111 
+                ->where($qb->expr()->eq('tbl.user', 'u.uid'))
112 
+                ->addOrderBy('u.uname', 'ASC');
113 113 
         } else {
114 114 
             $qb->select('DISTINCT(tbl.' . $fieldName . ')')
115 
-               ->addOrderBy('tbl.' . $fieldName, 'ASC');
115 
+                ->addOrderBy('tbl.' . $fieldName, 'ASC');
116 116 
         }
117 117
118 118 
         return $qb->getQuery()->getResult();
Please login to merge, or discard this patch.
src/system/SecurityCenterModule/Controller/IdsLogController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -87,7 +87,7 @@
 
 block discarded – undo
87 87 
         $hasFilters = 0 < count($where);
88 88
89 89 
         // number of items to show
90 
-        $pageSize = (int)$this->getVar('pagesize', 25);
90 
+        $pageSize = (int) $this->getVar('pagesize', 25);
91 91
92 92 
         // get data
93 93 
         $paginator = $repository->getIntrusions($where, $sorting, $page, $pageSize);
Please login to merge, or discard this patch.
src/system/RoutesModule/Entity/Repository/Base/AbstractRouteRepository.php 2 patches
Indentation   +17 added lines, -17 removed lines patch added patch discarded remove patch 
@@ -118,9 +118,9 @@  discard block
 
 block discarded – undo
118 118
119 119 
         $qb = $this->getEntityManager()->createQueryBuilder();
120 120 
         $qb->update($this->mainEntityClass, 'tbl')
121 
-           ->set('tbl.createdBy', $newUserId)
122 
-           ->where('tbl.createdBy = :creator')
123 
-           ->setParameter('creator', $userId);
121 
+            ->set('tbl.createdBy', $newUserId)
122 
+            ->where('tbl.createdBy = :creator')
123 
+            ->setParameter('creator', $userId);
124 124 
         $query = $qb->getQuery();
125 125 
         $query->execute();
126 126 
     
@@ -151,9 +151,9 @@  discard block
 
 block discarded – undo
151 151
152 152 
         $qb = $this->getEntityManager()->createQueryBuilder();
153 153 
         $qb->update($this->mainEntityClass, 'tbl')
154 
-           ->set('tbl.updatedBy', $newUserId)
155 
-           ->where('tbl.updatedBy = :editor')
156 
-           ->setParameter('editor', $userId);
154 
+            ->set('tbl.updatedBy', $newUserId)
155 
+            ->where('tbl.updatedBy = :editor')
156 
+            ->setParameter('editor', $userId);
157 157 
         $query = $qb->getQuery();
158 158 
         $query->execute();
159 159 
     
@@ -183,8 +183,8 @@  discard block
 
 block discarded – undo
183 183
184 184 
         $qb = $this->getEntityManager()->createQueryBuilder();
185 185 
         $qb->delete($this->mainEntityClass, 'tbl')
186 
-           ->where('tbl.createdBy = :creator')
187 
-           ->setParameter('creator', $userId);
186 
+            ->where('tbl.createdBy = :creator')
187 
+            ->setParameter('creator', $userId);
188 188 
         $query = $qb->getQuery();
189 189 
         $query->execute();
190 190 
     
@@ -214,8 +214,8 @@  discard block
 
 block discarded – undo
214 214
215 215 
         $qb = $this->getEntityManager()->createQueryBuilder();
216 216 
         $qb->delete($this->mainEntityClass, 'tbl')
217 
-           ->where('tbl.updatedBy = :editor')
218 
-           ->setParameter('editor', $userId);
217 
+            ->where('tbl.updatedBy = :editor')
218 
+            ->setParameter('editor', $userId);
219 219 
         $query = $qb->getQuery();
220 220 
         $query->execute();
221 221 
     
@@ -307,7 +307,7 @@  discard block
 
 block discarded – undo
307 307 
     {
308 308 
         if (0 < count($exclusions)) {
309 309 
             $qb->andWhere('tbl.id NOT IN (:excludedIdentifiers)')
310 
-               ->setParameter('excludedIdentifiers', $exclusions);
310 
+                ->setParameter('excludedIdentifiers', $exclusions);
311 311 
         }
312 312
313 313 
         return $qb;
 
@@ -416,7 +416,7 @@  discard block
 
 block discarded – undo
416 416
417 417 
         $qb = $this->getEntityManager()->createQueryBuilder();
418 418 
         $qb->select($selection)
419 
-           ->from($this->mainEntityClass, 'tbl');
419 
+            ->from($this->mainEntityClass, 'tbl');
420 420
421 421 
         if (true === $useJoins) {
422 422 
             $this->addJoinsToFrom($qb);
 
@@ -452,7 +452,7 @@  discard block
 
 block discarded – undo
452 452 
     {
453 453 
         $qb = $this->getCountQuery();
454 454 
         $qb->andWhere('tbl.' . $fieldName . ' = :' . $fieldName)
455 
-           ->setParameter($fieldName, $fieldValue);
455 
+            ->setParameter($fieldName, $fieldValue);
456 456
457 457 
         if ($excludeId > 0) {
458 458 
             $qb = $this->addExclusion($qb, [$excludeId]);
 
@@ -492,7 +492,7 @@  discard block
 
 block discarded – undo
492 492
493 493 
         $qb = $this->getEntityManager()->createQueryBuilder();
494 494 
         $qb->select($selection)
495 
-           ->from($this->mainEntityClass, 'tbl');
495 
+            ->from($this->mainEntityClass, 'tbl');
496 496
497 497 
         if (true === $useJoins) {
498 498 
             $this->addJoinsToFrom($qb);
 
@@ -515,7 +515,7 @@  discard block
 
 block discarded – undo
515 515 
         if ('RAND()' === $orderBy) {
516 516 
             // random selection
517 517 
             $qb->addSelect('MOD(tbl.id, ' . random_int(2, 15) . ') AS HIDDEN randomIdentifiers')
518 
-               ->orderBy('randomIdentifiers');
518 
+                ->orderBy('randomIdentifiers');
519 519
520 520 
             return $qb;
521 521 
         }
 
@@ -534,12 +534,12 @@  discard block
 
 block discarded – undo
534 534 
         }
535 535 
         if (false !== strpos($orderBy, 'tbl.createdBy')) {
536 536 
             $qb->addSelect('tblCreator')
537 
-               ->leftJoin('tbl.createdBy', 'tblCreator');
537 
+                ->leftJoin('tbl.createdBy', 'tblCreator');
538 538 
             $orderBy = str_replace('tbl.createdBy', 'tblCreator.uname', $orderBy);
539 539 
         }
540 540 
         if (false !== strpos($orderBy, 'tbl.updatedBy')) {
541 541 
             $qb->addSelect('tblUpdater')
542 
-               ->leftJoin('tbl.updatedBy', 'tblUpdater');
542 
+                ->leftJoin('tbl.updatedBy', 'tblUpdater');
543 543 
             $orderBy = str_replace('tbl.updatedBy', 'tblUpdater.uname', $orderBy);
544 544 
         }
545 545 
         $qb->add('orderBy', $orderBy);
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -442,7 +442,7 @@  discard block
 
 block discarded – undo
442 442
443 443 
         $query = $qb->getQuery();
444 444
445 
-        return (int)$query->getSingleScalarResult();
445 
+        return (int) $query->getSingleScalarResult();
446 446 
     }
447 447
448 448 
     /**
 
@@ -460,7 +460,7 @@  discard block
 
 block discarded – undo
460 460
461 461 
         $query = $qb->getQuery();
462 462
463 
-        $count = (int)$query->getSingleScalarResult();
463 
+        $count = (int) $query->getSingleScalarResult();
464 464
465 465 
         return 1 > $count;
466 466 
     }
Please login to merge, or discard this patch.
src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php 2 patches
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch 
@@ -164,17 +164,17 @@  discard block
 
 block discarded – undo
164 164 
                 $v = (string)$v;
165 165 
                 if ('workflowState' === $k && 0 === strpos($v, '!')) {
166 166 
                     $qb->andWhere('tbl.' . $k . ' != :' . $k)
167 
-                       ->setParameter($k, substr($v, 1));
167 
+                        ->setParameter($k, substr($v, 1));
168 168 
                 } elseif (0 === strpos($v, '%')) {
169 169 
                     $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
170 
-                       ->setParameter($k, '%' . substr($v, 1) . '%');
170 
+                        ->setParameter($k, '%' . substr($v, 1) . '%');
171 171 
                 } elseif (in_array($k, ['schemes', 'methods'], true)) {
172 172 
                     // multi list filter
173 173 
                     $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
174 
-                       ->setParameter($k, '%' . $v . '%');
174 
+                        ->setParameter($k, '%' . $v . '%');
175 175 
                 } else {
176 176 
                     $qb->andWhere('tbl.' . $k . ' = :' . $k)
177 
-                       ->setParameter($k, $v);
177 
+                        ->setParameter($k, $v);
178 178 
                 }
179 179 
             }
180 180 
         }
 
@@ -207,7 +207,7 @@  discard block
 
 block discarded – undo
207 207 
             // per default we show approved routes only
208 208 
             $onlineStates = ['approved'];
209 209 
             $qb->andWhere('tbl.workflowState IN (:onlineStates)')
210 
-               ->setParameter('onlineStates', $onlineStates);
210 
+                ->setParameter('onlineStates', $onlineStates);
211 211 
         }
212 212
213 213 
         return $qb;
 
@@ -274,7 +274,7 @@  discard block
 
 block discarded – undo
274 274 
         }
275 275
276 276 
         $qb->andWhere('tbl.createdBy = :userId')
277 
-           ->setParameter('userId', $userId);
277 
+            ->setParameter('userId', $userId);
278 278
279 279 
         return $qb;
280 280 
     }
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
         $this->requestStack = $requestStack;
56 56 
         $this->permissionHelper = $permissionHelper;
57 57 
         $this->currentUserApi = $currentUserApi;
58 
-        $this->showOnlyOwnEntries = (bool)$variableApi->get('ZikulaRoutesModule', 'showOnlyOwnEntries');
58 
+        $this->showOnlyOwnEntries = (bool) $variableApi->get('ZikulaRoutesModule', 'showOnlyOwnEntries');
59 59 
     }
60 60
61 61 
     /**
 
@@ -161,7 +161,7 @@  discard block
 
 block discarded – undo
161 161
162 162 
             // field filter
163 163 
             if ((!is_numeric($v) && '' !== $v) || (is_numeric($v) && 0 < $v)) {
164 
-                $v = (string)$v;
164 
+                $v = (string) $v;
165 165 
                 if ('workflowState' === $k && 0 === strpos($v, '!')) {
166 166 
                     $qb->andWhere('tbl.' . $k . ' != :' . $k)
167 167 
                        ->setParameter($k, substr($v, 1));
 
@@ -192,7 +192,7 @@  discard block
 
 block discarded – undo
192 192 
             return $qb;
193 193 
         }
194 194
195 
-        $showOnlyOwnEntries = (bool)$request->query->getInt('own', (int) $this->showOnlyOwnEntries);
195 
+        $showOnlyOwnEntries = (bool) $request->query->getInt('own', (int) $this->showOnlyOwnEntries);
196 196 
         if ($showOnlyOwnEntries) {
197 197 
             $qb = $this->addCreatorFilter($qb);
198 198 
         }
 
@@ -268,7 +268,7 @@  discard block
 
 block discarded – undo
268 268 
     {
269 269 
         if (null === $userId) {
270 270 
             $userId = $this->currentUserApi->isLoggedIn()
271 
-                ? (int)$this->currentUserApi->get('uid')
271 
+                ? (int) $this->currentUserApi->get('uid')
272 272 
                 : UsersConstant::USER_ID_ANONYMOUS
273 273 
             ;
274 274 
         }
Please login to merge, or discard this patch.
src/system/UsersModule/Controller/AccessController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -122,7 +122,8 @@
 
 block discarded – undo
122 122 
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
123 123 
                 $loginFormEvent = new LoginFormPostCreatedEvent($form);
124 124 
                 $eventDispatcher->dispatch($loginFormEvent);
125 
-                if ($form->count() > 3) { // count > 3 means that the LoginFormPostCreatedEvent event added some form children
125 
+                if ($form->count() > 3) {
126 
+// count > 3 means that the LoginFormPostCreatedEvent event added some form children
126 127 
                     $form->handleRequest($request);
127 128 
                     if ($form->isSubmitted() && $form->isValid()) {
128 129 
                         $uid = $form->get('uid')->getData();
Please login to merge, or discard this patch.