zikula / core

src/lib/Zikula/Bundle/CoreBundle/Twig/Extension/CoreExtension.php

Spacing +2 added lines, -2 removed lines

@@ -131,8 +131,8 @@
     {
         $string = preg_replace_callback(
             '/(.)@(.)/s',
-            function ($m) {
-                return "&#" . sprintf("%03d", ord($m[1])) . ";@&#" .sprintf("%03d", ord($m[2])) . ";";
+            function($m) {
+                return "&#" . sprintf("%03d", ord($m[1])) . ";@&#" . sprintf("%03d", ord($m[2])) . ";";
             },
             $string
         );

src/system/SecurityCenterModule/Tests/Api/HtmlFilterApiTest.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
     {
         $variableApi = $this->getMockBuilder(VariableApiInterface::class)->getMock();
         $variableApi->method('getSystemVar')->willReturnCallback(
-            function ($string, $default) use ($htmlEntities, $outputFilter) {
+            function($string, $default) use ($htmlEntities, $outputFilter) {
                 switch ($string) {
                     case 'outputfilter':
                         return $outputFilter;

src/system/UsersModule/DependencyInjection/ZikulaUsersExtension.php

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
      */
     public function load(array $configs, ContainerBuilder $container)
     {
-        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__.'/../Resources/config')));
+        $loader = new YamlFileLoader($container, new FileLocator(realpath(__DIR__ . '/../Resources/config')));
 
         $loader->load('services.yml');
         $loader->load('doctrine.yml');

src/system/ThemeModule/Api/PageAssetApi.php

Spacing +3 added lines, -3 removed lines

@@ -104,9 +104,9 @@
         }
 
         // ensure proper variable types
-        $value = (string) $value;
-        $type = (string) $type;
-        $weight = (int) $weight;
+        $value = (string)$value;
+        $type = (string)$type;
+        $weight = (int)$weight;
 
         if ('stylesheet' == $type) {
             $this->styleSheets->add([$value => $weight]);

src/system/RoutesModule/Form/Type/Base/AbstractConfigType.php

Spacing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
                 'attr' => [
                     'maxlength' => 255,
                     'title' => $this->__('Enter the route entries per page.') . ' ' . $this->__('Only digits are allowed.')
-                ],'scale' => 0
+                ], 'scale' => 0
             ])
         ;
     }

src/system/RoutesModule/Entity/Repository/Base/AbstractRouteRepository.php

Doc Comments +3 added lines, -3 removed lines

@@ -45,7 +45,7 @@ 
     /**
      * Retrieves an array with all fields which can be used for sorting instances.
      *
-     * @return array Sorting fields array
+     * @return string[] Sorting fields array
      */
     public function getAllowedSortingFields()
     {
@@ -304,7 +304,7 @@ 
     /**
      * Selects an object from the database.
      *
-     * @param mixed   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
+     * @param integer   $id       The id (or array of ids) to use to retrieve the object (optional) (default=0)
      * @param boolean $useJoins Whether to include joining related objects (optional) (default=true)
      * @param boolean $slimMode If activated only some basic fields are selected without using any joins (optional) (default=false)
      *
@@ -342,7 +342,7 @@ 
      * Adds where clauses excluding desired identifiers from selection.
      *
      * @param QueryBuilder $qb           Query builder to be enhanced
-     * @param array        $excludesions Array of ids to be excluded from selection
+     * @param array        $exclusions Array of ids to be excluded from selection
      *
      * @return QueryBuilder Enriched query builder instance
      */

Spacing +1 added lines, -1 removed lines

@@ -407,7 +407,7 @@
     public function getSelectWherePaginatedQuery(QueryBuilder $qb, $currentPage = 1, $resultsPerPage = 25)
     {
         $query = $this->getQueryFromBuilder($qb);
-        $offset = ($currentPage-1) * $resultsPerPage;
+        $offset = ($currentPage - 1) * $resultsPerPage;
     
         $query->setFirstResult($offset)
               ->setMaxResults($resultsPerPage);

Indentation +18 added lines, -18 removed lines

@@ -150,9 +150,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.createdBy', $newUserId)
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->set('tbl.createdBy', $newUserId)
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -183,9 +183,9 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->update($this->mainEntityClass, 'tbl')
-           ->set('tbl.updatedBy', $newUserId)
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->set('tbl.updatedBy', $newUserId)
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -214,8 +214,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.createdBy = :creator')
-           ->setParameter('creator', $userId);
+            ->where('tbl.createdBy = :creator')
+            ->setParameter('creator', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -244,8 +244,8 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->delete($this->mainEntityClass, 'tbl')
-           ->where('tbl.updatedBy = :editor')
-           ->setParameter('editor', $userId);
+            ->where('tbl.updatedBy = :editor')
+            ->setParameter('editor', $userId);
         $query = $qb->getQuery();
         $query->execute();
     
@@ -330,7 +330,7 @@ 
     {
         if (count($exclusions) > 0) {
             $qb->andWhere('tbl.id NOT IN (:excludedIdentifiers)')
-               ->setParameter('excludedIdentifiers', $exclusions);
+                ->setParameter('excludedIdentifiers', $exclusions);
         }
     
         return $qb;
@@ -390,7 +390,7 @@ 
         $offset = ($currentPage-1) * $resultsPerPage;
     
         $query->setFirstResult($offset)
-              ->setMaxResults($resultsPerPage);
+                ->setMaxResults($resultsPerPage);
     
         return $query;
     }
@@ -487,7 +487,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (!empty($where)) {
             $qb->andWhere($where);
@@ -536,7 +536,7 @@ 
     {
         $qb = $this->getCountQuery('', false);
         $qb->andWhere('tbl.' . $fieldName . ' = :' . $fieldName)
-           ->setParameter($fieldName, $fieldValue);
+            ->setParameter($fieldName, $fieldValue);
     
         if ($excludeId > 0) {
             $qb = $this->addExclusion($qb, [$excludeId]);
@@ -579,7 +579,7 @@ 
     
         $qb = $this->getEntityManager()->createQueryBuilder();
         $qb->select($selection)
-           ->from($this->mainEntityClass, 'tbl');
+            ->from($this->mainEntityClass, 'tbl');
     
         if (true === $useJoins) {
             $this->addJoinsToFrom($qb);
@@ -607,7 +607,7 @@ 
         if ($orderBy == 'RAND()') {
             // random selection
             $qb->addSelect('MOD(tbl.id, ' . mt_rand(2, 15) . ') AS HIDDEN randomIdentifiers')
-               ->add('orderBy', 'randomIdentifiers');
+                ->add('orderBy', 'randomIdentifiers');
     
             return $qb;
         }
@@ -626,12 +626,12 @@ 
         }
         if (false !== strpos($orderBy, 'tbl.createdBy')) {
             $qb->addSelect('tblCreator')
-               ->leftJoin('tbl.createdBy', 'tblCreator');
+                ->leftJoin('tbl.createdBy', 'tblCreator');
             $orderBy = str_replace('tbl.createdBy', 'tblCreator.uname', $orderBy);
         }
         if (false !== strpos($orderBy, 'tbl.updatedBy')) {
             $qb->addSelect('tblUpdater')
-               ->leftJoin('tbl.updatedBy', 'tblUpdater');
+                ->leftJoin('tbl.updatedBy', 'tblUpdater');
             $orderBy = str_replace('tbl.updatedBy', 'tblUpdater.uname', $orderBy);
         }
         $qb->add('orderBy', $orderBy);

Unused Use Statements +2 added lines, -3 removed lines

@@ -13,17 +13,16 @@
 namespace Zikula\RoutesModule\Entity\Repository\Base;
 
 use Doctrine\Common\Collections\ArrayCollection;
-use Gedmo\Sortable\Entity\Repository\SortableRepository;
-
 use Doctrine\ORM\Query;
 use Doctrine\ORM\QueryBuilder;
 use Doctrine\ORM\Tools\Pagination\Paginator;
+use Gedmo\Sortable\Entity\Repository\SortableRepository;
 use InvalidArgumentException;
 use Psr\Log\LoggerInterface;
 use Zikula\Common\Translator\TranslatorInterface;
-use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\RoutesModule\Entity\RouteEntity;
 use Zikula\RoutesModule\Helper\CollectionFilterHelper;
+use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 
 /**
  * Repository class used to implement own convenience methods for performing certain DQL queries.

src/system/RoutesModule/Helper/Base/AbstractControllerHelper.php

Doc Comments +2 added lines, -2 removed lines

@@ -88,7 +88,7 @@ 
      * @param string $context Usage context (allowed values: controllerAction, api, helper, actionHandler, block, contentType, util)
      * @param array  $args    Additional arguments
      *
-     * @return array List of allowed object types
+     * @return string[] List of allowed object types
      */
     public function getObjectTypes($context = '', array $args = [])
     {
@@ -381,7 +381,7 @@ 
      * @param string $context    Usage context (allowed values: controllerAction, api, actionHandler, block, contentType)
      * @param array  $args       Additional arguments
      *
-     * @return array List of template variables to be assigned
+     * @return string List of template variables to be assigned
      */
     public function addTemplateParameters($objectType = '', array $parameters = [], $context = '', array $args = [])
     {

src/system/RoutesModule/Listener/Base/AbstractEntityLifecycleListener.php

Doc Comments +1 added lines, -1 removed lines

@@ -262,7 +262,7 @@
      *
      * @param EntityAccess $entity The given entity
      *
-     * @return Event The created event instance
+     * @return string The created event instance
      */
     protected function createFilterEvent($entity)
     {

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Zikula\Core\Doctrine\EntityAccess;
 use Zikula\RoutesModule\RoutesEvents;
-use Zikula\RoutesModule\Event\FilterRouteEvent;
 
 /**
  * Event subscriber base class for entity lifecycle events.

src/system/RoutesModule/Helper/Base/AbstractCollectionFilterHelper.php

Indentation +6 added lines, -6 removed lines

@@ -171,14 +171,14 @@ 
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
+                            ->setParameter($k, substr($v, 1, strlen($v)-1));
                     } elseif (substr($v, 0, 1) == '%') {
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
-                           ->setParameter($k, '%' . $v . '%');
+                            ->setParameter($k, '%' . $v . '%');
                     } else {
                         $qb->andWhere('tbl.' . $k . ' = :' . $k)
-                           ->setParameter($k, $v);
-                   }
+                            ->setParameter($k, $v);
+                    }
                 }
             }
         }
@@ -282,10 +282,10 @@ 
     
         if (is_array($userId)) {
             $qb->andWhere('tbl.createdBy IN (:userIds)')
-               ->setParameter('userIds', $userId);
+                ->setParameter('userIds', $userId);
         } else {
             $qb->andWhere('tbl.createdBy = :userId')
-               ->setParameter('userId', $userId);
+                ->setParameter('userId', $userId);
         }
     
         return $qb;

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
                 if ((!is_numeric($v) && $v != '') || (is_numeric($v) && $v > 0)) {
                     if ($k == 'workflowState' && substr($v, 0, 1) == '!') {
                         $qb->andWhere('tbl.' . $k . ' != :' . $k)
-                           ->setParameter($k, substr($v, 1, strlen($v)-1));
+                           ->setParameter($k, substr($v, 1, strlen($v) - 1));
                     } elseif (substr($v, 0, 1) == '%') {
                         $qb->andWhere('tbl.' . $k . ' LIKE :' . $k)
                            ->setParameter($k, '%' . $v . '%');

Unused Use Statements -2 removed lines

@@ -17,8 +17,6 @@
 use Symfony\Component\HttpFoundation\RequestStack;
 use Zikula\UsersModule\Api\ApiInterface\CurrentUserApiInterface;
 use Zikula\UsersModule\Constant as UsersConstant;
-use Zikula\RoutesModule\Entity\RouteEntity;
-use Zikula\RoutesModule\Entity\Factory\RoutesFactory;
 
 /**
  * Entity collection filter helper base class.