Completed
Pull Request — master (#3991)
by Craig
05:41
created
src/system/RoutesModule/Form/Handler/Route/Base/AbstractEditHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -240,7 +240,7 @@
 block discarded – undo
240 240
                 return $this->router->generate($routePrefix . 'view');
241 241
             case 'userOwnView':
242 242
             case 'adminOwnView':
243
-                return $this->router->generate($routePrefix . 'view', [ 'own' => 1 ]);
243
+                return $this->router->generate($routePrefix . 'view', ['own' => 1]);
244 244
             case 'userDisplay':
245 245
             case 'adminDisplay':
246 246
                 if ('delete' !== $args['commandName'] && !('create' === $this->templateParameters['mode'] && 'cancel' === $args['commandName'])) {
Please login to merge, or discard this patch.
src/system/RoutesModule/Form/Type/Base/AbstractRouteType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -332,7 +332,7 @@
 block discarded – undo
332 332
             ->setDefaults([
333 333
                 // define class for underlying data (required for embedding forms)
334 334
                 'data_class' => RouteEntity::class,
335
-                'empty_data' => function (FormInterface $form) {
335
+                'empty_data' => function(FormInterface $form) {
336 336
                     return $this->entityFactory->createRoute();
337 337
                 },
338 338
                 'error_mapping' => [
Please login to merge, or discard this patch.
RoutesModule/Validator/Constraints/Base/AbstractListEntryValidator.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
 
52 52
         if ('workflowState' === $constraint->propertyName && in_array($value, ['initial', 'deleted'], true)) {
53 53
             return;
54
-    	}
54
+        }
55 55
 
56 56
         $listEntries = $this->listEntriesHelper->getEntries($constraint->entityName, $constraint->propertyName);
57 57
         $allowedValues = [];
Please login to merge, or discard this patch.
src/system/RoutesModule/Helper/Base/AbstractViewHelper.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@
 block discarded – undo
182 182
      *
183 183
      * @return string[] List of allowed template extensions
184 184
      */
185
-    protected function availableExtensions(string $type,  string$func): array
185
+    protected function availableExtensions(string $type, string$func): array
186 186
     {
187 187
         $extensions = [];
188 188
         $hasAdminAccess = $this->permissionHelper->hasComponentPermission($type, ACCESS_ADMIN);
Please login to merge, or discard this patch.
src/system/BlocksModule/Tests/Helper/InstallerHelperTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
             ->getMock();
55 55
         $kernel
56 56
             ->method('getModule')
57
-            ->willReturnCallback(function ($moduleName) {
57
+            ->willReturnCallback(function($moduleName) {
58 58
                 if ('ExceptionModule' === $moduleName) {
59 59
                     // mocks situation where module is not namespaced.
60 60
                     throw new Exception();
Please login to merge, or discard this patch.
src/system/MenuModule/Controller/NodeController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,8 @@
 block discarded – undo
61 61
                         $parent = $menuItemRepository->find($request->request->get('parent'));
62 62
                         $menuItemEntity->setParent($parent);
63 63
                         $menuItemEntity->setRoot($parent->getRoot());
64
-                    } elseif (empty($parentId) && $request->request->has('after')) { // sibling of top-level child
64
+                    } elseif (empty($parentId) && $request->request->has('after')) {
65
+// sibling of top-level child
65 66
                         /** @var MenuItemEntity $sibling */
66 67
                         $sibling = $menuItemRepository->find($request->request->get('after'));
67 68
                         $menuItemEntity->setParent($sibling->getParent());
Please login to merge, or discard this patch.
src/system/ThemeModule/Controller/ThemeController.php 1 patch
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -266,7 +266,7 @@
 block discarded – undo
266 266
      */
267 267
     public function creditsAction(ThemeEntityRepository $themeRepository, string $themeName): array
268 268
     {
269
-        if (!$this->hasPermission('ZikulaThemeModule::', "${themeName}::credits", ACCESS_EDIT)) {
269
+        if (!$this->hasPermission('ZikulaThemeModule::', "${themename}::credits", ACCESS_EDIT)) {
270 270
             throw new AccessDeniedException();
271 271
         }
272 272
         $themeInfo = $themeRepository->findOneBy(['name' => $themeName]);
Please login to merge, or discard this patch.
src/system/UsersModule/Controller/AccessController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -121,7 +121,8 @@
 block discarded – undo
121 121
                 $form = $this->createForm(DefaultLoginType::class, ['uid' => $uid]);
122 122
                 $loginFormEvent = new UserFormAwareEvent($form);
123 123
                 $eventDispatcher->dispatch(AccessEvents::AUTHENTICATION_FORM, $loginFormEvent);
124
-                if ($form->count() > 3) { // count > 3 means that the AUTHENTICATION_FORM event added some form children
124
+                if ($form->count() > 3) {
125
+// count > 3 means that the AUTHENTICATION_FORM event added some form children
125 126
                     $form->handleRequest($request);
126 127
                     if ($form->isSubmitted() && $form->isValid()) {
127 128
                         $uid = $form->get('uid')->getData();
Please login to merge, or discard this patch.
src/system/UsersModule/Entity/Repository/UserRepository.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,8 +51,8 @@
 block discarded – undo
51 51
         // the following process should be unnecessary because cascade = all but MySQL 5.7 not working with that (#3726)
52 52
         $qb = $this->_em->createQueryBuilder();
53 53
         $qb->delete(UserAttributeEntity::class, 'a')
54
-           ->where('a.user = :userId')
55
-           ->setParameter('userId', $user->getUid());
54
+            ->where('a.user = :userId')
55
+            ->setParameter('userId', $user->getUid());
56 56
         $query = $qb->getQuery();
57 57
         $query->execute();
58 58
         // end of theoretically unrequired process
Please login to merge, or discard this patch.